Merge pull request #1798 from Exiv2/mergify/bp/main/pr-1789

&bytes[0] (std::vector) will crash if bytes has zero elements (backport #1789)
This commit is contained in:
Kevin Backhouse
2021-07-25 22:08:52 +01:00
committed by GitHub
3 changed files with 34 additions and 12 deletions
@@ -0,0 +1,22 @@
# -*- coding: utf-8 -*-
from system_tests import CaseMeta, CopyTmpFiles, path, check_no_ASAN_UBSAN_errors
import unittest
@unittest.skip("Skipping test using option -pR (only for Debug mode)")
class ImagePrintIFDStructureZeroCountAssert(metaclass=CaseMeta):
"""
Regression test for the bug described in:
https://github.com/Exiv2/exiv2/security/advisories/GHSA-g44w-q3vm-gwjq
"""
url = "https://github.com/Exiv2/exiv2/security/advisories/GHSA-g44w-q3vm-gwjq"
filename = path("$data_path/issue_ghsa_g44w_q3vm_gwjq_poc.jpg")
commands = ["$exiv2 -pR $filename"]
stderr = ["""invalid type in tiff structure0
Exiv2 exception in print action for file $filename:
$kerInvalidTypeValue
"""]
retval = [1]
compare_stdout = check_no_ASAN_UBSAN_errors