third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add unit tests for the TimeValue class

Browse Source
This commit is contained in:
Luis Diaz Mas 2018-06-01 06:55:04 +02:00 committed by Luis Díaz Más
parent 59e84ed1ae
commit 0cf7d4fad8
2 changed files with 104 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
unitTests/CMakeLists.txt
View File

@ -7,6 +7,7 @@ add_executable(unit_tests mainTestRunner.cpp
test_safe_op.cpp
test_XmpKey.cpp
test_DateValue.cpp
test_TimeValue.cpp
test_cr2header_int.cpp
test_helper_functions.cpp
)

103
unitTests/test_TimeValue.cpp Normal file
View File

@ -0,0 +1,103 @@
#include "value.hpp"
#include "gtestwrapper.h"
using namespace Exiv2;
TEST(ATimeValue, isDefaultConstructed)
{
const TimeValue value;
ASSERT_EQ(0, value.getTime().hour);
ASSERT_EQ(0, value.getTime().minute);
ASSERT_EQ(0, value.getTime().second);
ASSERT_EQ(0, value.getTime().tzHour);
ASSERT_EQ(0, value.getTime().tzMinute);
}
TEST(ATimeValue, isConstructedWithArgs)
{
const TimeValue value (23, 55, 2);
ASSERT_EQ(23, value.getTime().hour);
ASSERT_EQ(55, value.getTime().minute);
ASSERT_EQ(2, value.getTime().second);
ASSERT_EQ(0, value.getTime().tzHour);
ASSERT_EQ(0, value.getTime().tzMinute);
}
/// \todo add tests to check what happen with values out of valid ranges
TEST(ATimeValue, canBeReadFromStringHMS)
{
TimeValue value;
const std::string hms("23:55:02");
ASSERT_EQ(0, value.read(hms));
ASSERT_EQ(23, value.getTime().hour);
ASSERT_EQ(55, value.getTime().minute);
ASSERT_EQ(2, value.getTime().second);
ASSERT_EQ(0, value.getTime().tzHour);
ASSERT_EQ(0, value.getTime().tzMinute);
}
TEST(ATimeValue, canBeReadFromWideString)
{
TimeValue value;
const std::string hms("23:55:02+04:04");
ASSERT_EQ(0, value.read(hms));
ASSERT_EQ(23, value.getTime().hour);
ASSERT_EQ(55, value.getTime().minute);
ASSERT_EQ(2, value.getTime().second);
ASSERT_EQ(4, value.getTime().tzHour);
ASSERT_EQ(4, value.getTime().tzMinute);
}
TEST(ATimeValue, canBeReadFromWideStringNegative)
{
TimeValue value;
const std::string hms("23:55:02-04:04");
ASSERT_EQ(0, value.read(hms));
ASSERT_EQ(23, value.getTime().hour);
ASSERT_EQ(55, value.getTime().minute);
ASSERT_EQ(2, value.getTime().second);
ASSERT_EQ(-4, value.getTime().tzHour);
ASSERT_EQ(-4, value.getTime().tzMinute);
}
/// \todo check what we should do here.
TEST(ATimeValue, canBeReadFromWideStringOther)
{
TimeValue value;
const std::string hms("23:55:02?04:04");
ASSERT_EQ(0, value.read(hms));
ASSERT_EQ(23, value.getTime().hour);
ASSERT_EQ(55, value.getTime().minute);
ASSERT_EQ(2, value.getTime().second);
ASSERT_EQ(4, value.getTime().tzHour);
ASSERT_EQ(4, value.getTime().tzMinute);
}
TEST(ATimeValue, cannotReadFromStringWithBadFormat)
{
TimeValue value;
ASSERT_EQ(1, value.read("aa:55:02")); // String with non-digit chars
ASSERT_EQ(1, value.read("25:55:02")); // Hours >= 24
ASSERT_EQ(1, value.read("23:65:02")); // Minutes >= 60
ASSERT_EQ(1, value.read("23:55:62")); // Seconds >= 60
ASSERT_EQ(1, value.read("23:55:02+25:04")); // tzHour >= 24
ASSERT_EQ(1, value.read("23:55:02+04:66")); // tzMinutes >= 60
/// \todo This one does not fail
//ASSERT_EQ(1, value.read("23:55:02+04:06:06")); // More components than expected
}
TEST(ATimeValue, isCopiedToBuffer)
{
const TimeValue value (23, 55, 2);
byte buffer[11];
ASSERT_EQ(11, value.copy(buffer));
const byte expectedDate[11] = {'2', '3', '5', '5', '0', '2',
'+', '0', '0', '0', '0'};
for (int i = 0; i < 11; ++i) {
ASSERT_EQ(expectedDate[i], buffer[i]) << "i: " << i;
}
}