third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF().

Browse Source
This commit is contained in:
clanmills 2021-03-10 08:59:17 +00:00
parent e3fd0c633e
commit 212f1b5ebb
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -793,6 +793,8 @@ Access to the bmff code is guarded in two ways. Firstly, you have to build the
EXIV2API bool enableBMFF(bool enable);
```
The return value of `enableBMFF()` reports the build status of bmff support. A return value of true indicates that the library has been built with bmff support.
Applications may wish the provide a preference setting to enable bmff support and thereby place the responsibility for the use of this code with the user of the application.
It is recommended that you enclose the call to `enableBMFF()` with the compile time macro EXIV2\_TEST\_VERSION to ensure that your code builds cleanly on earlier versions of Exiv2. It is recommended that you call enableBMFF() at process start-up as it is not threadsafe. A code snippet is provided in [2.14 Thread Safety](#2-14).

7
src/bmffimage.cpp
View File

@ -84,9 +84,10 @@ namespace Exiv2
#ifdef EXV_ENABLE_BMFF
enabled = enable;
return true;
#else
UNUSED(enable);
return false;
#endif // EXV_ENABLE_BMFF
enable = false; // unused
return enable;
}
std::string Iloc::toString() const
@ -172,7 +173,7 @@ namespace Exiv2
return result;
}
long BmffImage::boxHandler(std::ostream& out, Exiv2::PrintStructureOption option,int depth)
long BmffImage::boxHandler(std::ostream& out /* = std::cout*/ , Exiv2::PrintStructureOption option /* = kpsNone */,int depth /* =0 */)
{
long result = (long)io_->size();
long address = (long)io_->tell();