third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace for-loop with while to improve readability.

Browse Source 
Note that I also moved the std::string out of the loop so that we do not
need to allocate/deallocate the string several times.
This commit is contained in:
Luis Díaz Más 2019-09-14 12:42:34 +02:00 committed by Dan Čermák
parent c44188db9a
commit 23eb91aa6e
No known key found for this signature in database
GPG Key ID: E632C3380610D1C5
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
samples/taglist.cpp
View File

@ -46,14 +46,14 @@ int main(int argc, char* argv[])
if (item == "all" || item == "ALL" ) {
const GroupInfo* groupList = ExifTags::groupList();
if (groupList) {
std::string line;
while (groupList->tagList_) {
std::ostringstream tags;
ExifTags::taglist(tags,groupList->groupName_);
// https://en.cppreference.com/w/cpp/string/basic_string/getline
std::istringstream input(tags.str()) ;
for (std::string line,comma(","); std::getline(input, line); ) {
while (std::getline(input, line)) {
std::cout << groupList->groupName_ << "."
<< (item == "all" ? line.substr(0,line.find(comma)) : line)
<< (item == "all" ? line.substr(0,line.find(",")) : line)
<< std::endl;
}
groupList++;