third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clang-tidy: don't assign in if

Browse Source 
Found with bugprone-assignment-in-if-condition

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-02-10 18:18:47 -08:00
parent d1a2cd0b76
commit 35b6780d02
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
app/actions.cpp
View File

@ -1290,9 +1290,9 @@ void Modify::delMetadatum(Exiv2::Image* pImage, const ModifyCmd& modifyCmd) {
}
}
if (modifyCmd.metadataId_ == MetadataId::xmp) {
Exiv2::XmpData::iterator pos;
const Exiv2::XmpKey xmpKey(modifyCmd.key_);
if ((pos = xmpData.findKey(xmpKey)) != xmpData.end()) {
auto pos = xmpData.findKey(xmpKey);
if (pos != xmpData.end()) {
xmpData.eraseFamily(pos);
}
}

4
src/iptc.cpp
View File

@ -401,8 +401,8 @@ int IptcParser::decode(IptcData& iptcData, const byte* pData, size_t size) {
pRead += 2;
}
if (sizeData <= static_cast<size_t>(pEnd - pRead)) {
int rc = 0;
if ((rc = readData(iptcData, dataSet, record, pRead, sizeData)) != 0) {
int rc = readData(iptcData, dataSet, record, pRead, sizeData);
if (rc != 0) {
#ifndef SUPPRESS_WARNINGS
EXV_WARNING << "Failed to read IPTC dataset " << IptcKey(dataSet, record) << " (rc = " << rc << "); skipped.\n";
#endif