third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clang-tidy: replace memcpy with copy_n

Browse Source 
Found with bugprone-not-null-terminated-result

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-02-10 19:05:38 -08:00
parent 7f5430a7d4
commit 36e848d4fe
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/jpgimage.cpp
View File

@ -1001,7 +1001,7 @@ int ExvImage::writeHeader(BasicIo& outIo) const {
byte tmpBuf[7];
tmpBuf[0] = 0xff;
tmpBuf[1] = 0x01;
std::memcpy(tmpBuf + 2, exiv2Id_, 5);
std::copy_n(exiv2Id_, 5, tmpBuf + 2);
if (outIo.write(tmpBuf, 7) != 7)
return 4;
if (outIo.error())

2
src/value.cpp
View File

@ -471,7 +471,7 @@ size_t XmpValue::copy(byte* buf, ByteOrder /*byteOrder*/) const {
write(os);
std::string s = os.str();
if (!s.empty())
std::memcpy(buf, s.data(), s.size());
std::copy_n(s.data(), s.size(), buf);
return s.size();
}