third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

manual default member init

Browse Source 
clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-01-04 14:28:48 -08:00
parent a84df11bbb
commit 3e97850e97
2 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
include/exiv2/image.hpp
View File

@ -479,9 +479,13 @@ class EXIV2API Image {
private:
// DATA
ImageType imageType_; //!< Image type
uint16_t supportedMetadata_; //!< Bitmap with all supported metadata types
bool writeXmpFromPacket_; //!< Determines the source when writing XMP
ImageType imageType_; //!< Image type
uint16_t supportedMetadata_; //!< Bitmap with all supported metadata types
#ifdef EXV_HAVE_XMP_TOOLKIT
bool writeXmpFromPacket_{false}; //!< Determines the source when writing XMP
#else
bool writeXmpFromPacket_{true}; //!< Determines the source when writing XMP
#endif
ByteOrder byteOrder_{invalidByteOrder}; //!< Byte order
std::map<int, std::string> tags_; //!< Map of tags

9
src/image.cpp
View File

@ -128,14 +128,7 @@ std::string pathOfFileUrl(const std::string& url) {
// class member definitions
namespace Exiv2 {
Image::Image(ImageType type, uint16_t supportedMetadata, BasicIo::UniquePtr io) :
io_(std::move(io)),
imageType_(type),
supportedMetadata_(supportedMetadata),
#ifdef EXV_HAVE_XMP_TOOLKIT
writeXmpFromPacket_(false) {
#else
writeXmpFromPacket_(true) {
#endif
io_(std::move(io)), imageType_(type), supportedMetadata_(supportedMetadata) {
}
void Image::printStructure(std::ostream&, PrintStructureOption, size_t /*depth*/) {