third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix sign-compare warnings & use gtestwrapper.h

Browse Source
This commit is contained in:
Luis Diaz Mas 2019-07-25 07:27:08 +02:00
parent edb4bf78ca
commit 48d68c8271
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
unitTests/test_basicio.cpp
View File

@ -1,5 +1,6 @@
#include <exiv2/basicio.hpp>
#include <gtest/gtest.h>
#include "gtestwrapper.h"
using namespace Exiv2;
@ -19,7 +20,8 @@ TEST(MemIo, seek_out_of_bounds_00)
ASSERT_TRUE(io.eof());
// The seek was invalid, so the offset didn't change and this read still works.
ASSERT_EQ(io.read(tmp, sizeof(tmp)), sizeof(tmp));
const long sizeTmp = static_cast<long>(sizeof(sizeTmp));
ASSERT_EQ(io.read(tmp, sizeTmp), sizeTmp);
}
TEST(MemIo, seek_out_of_bounds_01)
@ -56,7 +58,8 @@ TEST(MemIo, seek_out_of_bounds_02)
ASSERT_EQ(io.seek(0x10000000, BasicIo::cur), 1);
ASSERT_TRUE(io.eof());
// The seek was invalid, so the offset didn't change and this read still works.
ASSERT_EQ(io.read(tmp, sizeof(tmp)), sizeof(tmp));
const long sizeTmp = static_cast<long>(sizeof(sizeTmp));
ASSERT_EQ(io.read(tmp, sizeTmp), sizeTmp);
}
TEST(MemIo, seek_out_of_bounds_03)
@ -73,5 +76,6 @@ TEST(MemIo, seek_out_of_bounds_03)
ASSERT_EQ(io.seek(-0x10000000, BasicIo::cur), 1);
ASSERT_FALSE(io.eof());
// The seek was invalid, so the offset didn't change and this read still works.
ASSERT_EQ(io.read(tmp, sizeof(tmp)), sizeof(tmp));
const long sizeTmp = static_cast<long>(sizeof(sizeTmp));
ASSERT_EQ(io.read(tmp, sizeTmp), sizeTmp);
}