third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

clang-tidy: no else after return

Browse Source 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2022-06-20 23:43:52 -07:00
parent c2be02145d
commit 84555f1ad5
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
app/exiv2.cpp
View File

@ -749,9 +749,8 @@ int Params::evalDelete(const std::string& optArg) {
if (rc > 0) {
target_ |= static_cast<CommonTarget>(rc);
return 0;
} else {
return 1;
}
return 1;
}
default:
std::cerr << progname() << ": " << _("Option -d is not compatible with a previous option\n");
@ -771,9 +770,8 @@ int Params::evalExtract(const std::string& optArg) {
if (rc > 0) {
target_ |= static_cast<CommonTarget>(rc);
return 0;
} else {
return 1;
}
return 1;
}
default:
std::cerr << progname() << ": " << _("Option -e is not compatible with a previous option\n");
@ -793,9 +791,8 @@ int Params::evalInsert(const std::string& optArg) {
if (rc > 0) {
target_ |= static_cast<CommonTarget>(rc);
return 0;
} else {
return 1;
}
return 1;
}
default:
std::cerr << progname() << ": " << _("Option -i is not compatible with a previous option\n");

3
src/types.cpp
View File

@ -178,7 +178,8 @@ byte* Exiv2::DataBuf::data(size_t offset) {
const byte* Exiv2::DataBuf::c_data(size_t offset) const {
if (pData_.empty()) {
return nullptr;
} else if (offset >= pData_.size()) {
}
if (offset >= pData_.size()) {
throw std::out_of_range("Overflow in Exiv2::DataBuf::c_data");
}
return &pData_[offset];