From 9569ef2fda8f0b4f9b1670e379ffd38d80b274dc Mon Sep 17 00:00:00 2001 From: tbeu Date: Fri, 3 Nov 2017 20:59:50 +0100 Subject: [PATCH] Use auxiliary variable V807 Decreased performance. Consider creating a reference to avoid using the 'image_.exifData()' expression repeatedly. preview.cpp 530 --- src/preview.cpp | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/src/preview.cpp b/src/preview.cpp index 572a9608..f12d3f15 100644 --- a/src/preview.cpp +++ b/src/preview.cpp @@ -524,22 +524,23 @@ namespace { : Loader(id, image) { offset_ = 0; - ExifData::const_iterator pos = image_.exifData().findKey(ExifKey(param_[parIdx].offsetKey_)); - if (pos != image_.exifData().end() && pos->count() > 0) { + const ExifData &exifData = image_.exifData(); + ExifData::const_iterator pos = exifData.findKey(ExifKey(param_[parIdx].offsetKey_)); + if (pos != exifData.end() && pos->count() > 0) { offset_ = pos->toLong(); } size_ = 0; - pos = image_.exifData().findKey(ExifKey(param_[parIdx].sizeKey_)); - if (pos != image_.exifData().end() && pos->count() > 0) { + pos = exifData.findKey(ExifKey(param_[parIdx].sizeKey_)); + if (pos != exifData.end() && pos->count() > 0) { size_ = pos->toLong(); } if (offset_ == 0 || size_ == 0) return; if (param_[parIdx].baseOffsetKey_) { - pos = image_.exifData().findKey(ExifKey(param_[parIdx].baseOffsetKey_)); - if (pos != image_.exifData().end() && pos->count() > 0) { + pos = exifData.findKey(ExifKey(param_[parIdx].baseOffsetKey_)); + if (pos != exifData.end() && pos->count() > 0) { offset_ += pos->toLong(); } }