third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Some performance tweaks (analysis by Vladimir Nadvornik)

Browse Source
This commit is contained in:
Andreas Huggel 2008-09-26 15:20:57 +00:00
parent 43b8c07176
commit bd1e9d239f
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/tags.cpp
View File

@ -47,6 +47,7 @@ EXIV2_RCSID("@(#) $Id$")
#include <cstdlib>
#include <cassert>
#include <cmath>
#include <cstring>
#ifdef EXV_HAVE_ICONV
# include <iconv.h>
@ -75,9 +76,11 @@ namespace Exiv2 {
return ifdId_ == ifdId;
}
bool IfdInfo::operator==(Item item) const
bool IfdInfo::operator==(const Item& item) const
{
return std::string(item_) == item.i_;
const char* i = item.i_.c_str();
if (i == 0) return false;
return (strlen(i) == strlen(item_) && 0 == strcmp(i, item_));
}
// Important: IFD item must be unique!
@ -1619,8 +1622,13 @@ namespace Exiv2 {
{
const TagInfo* ti = tagList(ifdId);
if (ti == 0) return 0;
const char* tn = tagName.c_str();
if (tn == 0) return 0;
for (int idx = 0; ti[idx].tag_ != 0xffff; ++idx) {
if (std::string(ti[idx].name_) == tagName) return &ti[idx];
if ( strlen(ti[idx].name_) == strlen(tn)
&& strcmp(ti[idx].name_, tn) == 0) {
return &ti[idx];
}
}
return 0;
} // ExifTags::tagInfo

2
src/tags.hpp
View File

@ -76,7 +76,7 @@ namespace Exiv2 {
struct EXIV2API IfdInfo {
struct Item;
bool operator==(IfdId ifdId) const; //!< Comparison operator for IFD id
bool operator==(Item item) const; //!< Comparison operator for IFD item
bool operator==(const Item& item) const; //!< Comparison operator for IFD item
IfdId ifdId_; //!< IFD id
const char* name_; //!< IFD name
const char* item_; //!< Related IFD item. This is also an IFD name, unique for each IFD.