From d2ddf228adda60beaa142686860eb5f1be385df5 Mon Sep 17 00:00:00 2001 From: Rosen Penev Date: Fri, 10 Feb 2023 17:07:52 -0800 Subject: [PATCH] replace switch with if/return Fixes warning C4702: unreachable code No other way to make all compilers gappy. Signed-off-by: Rosen Penev --- src/image.cpp | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/src/image.cpp b/src/image.cpp index 4a8dfcdf..9a235158 100644 --- a/src/image.cpp +++ b/src/image.cpp @@ -733,19 +733,15 @@ AccessMode ImageFactory::checkMode(ImageType type, MetadataId metadataId) { auto r = Exiv2::find(registry, type); if (!r) throw Error(ErrorCode::kerUnsupportedImageType, static_cast(type)); - switch (metadataId) { - case mdExif: - return r->exifSupport_; - case mdIptc: - return r->iptcSupport_; - case mdXmp: - return r->xmpSupport_; - case mdComment: - return r->commentSupport_; - default: - return amNone; - } - return {}; + if (metadataId == mdExif) + return r->exifSupport_; + if (metadataId == mdIptc) + return r->iptcSupport_; + if (metadataId == mdXmp) + return r->xmpSupport_; + if (metadataId == mdComment) + return r->commentSupport_; + return amNone; } bool ImageFactory::checkType(ImageType type, BasicIo& io, bool advance) {