From eca251865f07ca1868cfc342a5a4cd4cb428abc3 Mon Sep 17 00:00:00 2001 From: tbeu Date: Fri, 3 Nov 2017 21:20:02 +0100 Subject: [PATCH] Fix check (on comparing unsigned minus signed greater zero) V555 The expression 'object->sizeDataArea_ - buf.size_ > 0' will work as 'object->sizeDataArea_ != buf.size_'. tiffvisitor.cpp 911 --- src/tiffvisitor_int.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/tiffvisitor_int.cpp b/src/tiffvisitor_int.cpp index aa57ef27..4df1953e 100644 --- a/src/tiffvisitor_int.cpp +++ b/src/tiffvisitor_int.cpp @@ -905,7 +905,7 @@ namespace Exiv2 { #endif DataBuf buf = object->pValue()->dataArea(); memcpy(object->pDataArea_, buf.pData_, buf.size_); - if (object->sizeDataArea_ - buf.size_ > 0) { + if (object->sizeDataArea_ > static_cast(buf.size_)) { memset(object->pDataArea_ + buf.size_, 0x0, object->sizeDataArea_ - buf.size_); }