From f8962224fdb568019ff26eedc140bb91526ff406 Mon Sep 17 00:00:00 2001 From: Christoph Hasse Date: Thu, 3 Jun 2021 19:52:04 +0200 Subject: [PATCH] fix: prevent creation of nightly release with draf==true Sometime the nightly pre-release would be in "draft" status on github. It's hard to reproduce but I had the guess that maybe the deletion of old tag and release on the github side wasn't quite done when the new release was being created. Of course only speculation... But, moving the download of the artifacts in betweent these two steps seems to have fixed the symptom. --- .github/workflows/release.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8a627bf0..df0d397c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -151,9 +151,6 @@ jobs: permissions: contents: write steps: - - uses: actions/download-artifact@v2 - - name: List downloaded files - run: tree -L 3 - if: github.event_name == 'workflow_dispatch' run: echo "TAG_NAME=${{ github.event.inputs.tag_name }}" >> $GITHUB_ENV @@ -216,6 +213,9 @@ jobs: console.log( "Failed with error\n", error); } + - uses: actions/download-artifact@v2 + - name: List downloaded files + run: tree -L 3 - uses: softprops/action-gh-release@v1 env: