Commit Graph

45 Commits

Author SHA1 Message Date
Luis Díaz Más
f30022d73d
Fix issues detected with PVS-Studio + other little improvements (#1689)
* avoid re-declaration of constant variables

* Replace pthreads critical section with std::mutex

* ci - better naming

* cmake - increase minimum version to 3.11. Use project DESCRIPTION

* fix - do not treat string::find() return type as bool

* remove conditions that were always true

* remove condition that were always false

* Remove EXV_HAVE_GMTIME_R which is not used anymore

* pixelWidth_ was inherited from Exiv2::Image

The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...

* Remove superfluous if

* pvs:V766 item with identical key added already

* pvs:V730 not all members were initialized (time)

* pvs:V730 not all members are initialized

* pvs:v668 no point in testing pointer against null after new

* pvs:V1048 variable assigned the same value

* replace c-style dynamic vector with std one

* pvs:547 fakeData is always true

* Remove useless constructor in derived class

* pvs:V690 modern way to disable copy-ctor

* Replace malloc/free with new/delete. No need to check for null

* pvs:V1028 cast operands and not result

* Remove custom MIN/MAX functions

* pvs:V595 pointer used before verified against null

* pvs: index used before being checked

* pvs:V1028 possible overflow. Cast operands

* pvs:v575 potential null pointer passed to other functions

* pvs:V547 deal with always true/false expressions

* pvs:V560 part of conditional expressions always false or true

* pvs:V701 possible break in realloc -> move to std::vector

* Make some classes 'final'

* Replace sprintf with std::to_string()

* fix compilation on windows
2021-06-01 12:39:10 +02:00
Christoph Hasse
024830a72c
feat: Setup github actions workflow to build tagged release and nightly pre-release (#1676) 2021-05-31 16:50:11 +02:00
Luis Díaz Más
b83b2197c1 ci - Linux distros jobs being more explicit about options used 2021-05-18 14:39:17 +02:00
Luis Díaz Más
0d45de7519 ci - Replace debian:9 with debian:10 2021-05-18 14:39:17 +02:00
Luis Díaz Más
44256e8c5d ci - Win matrix jobs will also run on:push for main
The idea is to generate a conan cache on main that could be reused in
future PRs to main.
2021-05-17 07:31:45 +02:00
Luis Díaz Más
9241f60880 win - Only run tests on x64
On CI, pythonTests fail more or less consistently in the configuration
Arch:x86, BuildType:Relase, Shared:ON. I tried to reproduce this locally,
but I could not.

Since Win-x86 is marginal for Exiv2, we disable it from CI until
somebody raise concerns about it.
2021-05-17 07:31:45 +02:00
Luis Díaz Más
59a80eba2e mac - cmake_paths does not work directly on mac 2021-05-17 07:31:45 +02:00
Luis Díaz Más
4f057a84ee ci - Win builds without unicode + with warnings as errors 2021-05-17 07:31:45 +02:00
Luis Díaz Más
34945e39c4 ci - Use CTest for coverage builds 2021-05-15 19:03:14 +02:00
Luis Díaz Más
8d596283b1 ci - install tar in opensuse before checkout action 2021-05-15 19:03:14 +02:00
Luis Diaz Mas
d5782ea8fb ci - distros - fastTrue=False 2021-05-15 19:03:14 +02:00
Luis Díaz Más
f956a398ad ci - Use CTest in all the ci jobs 2021-05-15 16:58:24 +02:00
Luis Díaz Más
381a33b12d ci - Add new special build with all project options enabled 2021-05-15 16:58:24 +02:00
Luis Diaz Mas
b163158100 ci - Use ctest 2021-05-15 16:58:24 +02:00
Luis Díaz Más
d2083b3190 ci - Use generic cmake way to compile and install 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
e6bfa8eb7d ci - Use Ninja in rest of builds 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
fb17e75539 ci - mac uses ninja 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
1769d8988a ci - Linux uses ninja 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
44eb56102b ci - Add coverage run on main branch 2021-05-13 23:04:51 +02:00
Luis Díaz Más
9e43a89d1d ci - Do not create conanCache dir 2021-05-12 16:10:04 +02:00
Luis Diaz Mas
ad57cb4293 ci - cache conan packages on Windows builds 2021-05-12 16:10:04 +02:00
Luis Diaz Mas
f969fe88fc Fedora-MinGW build to Github Workflows 2021-05-12 16:10:04 +02:00
Luis Díaz Más
5e13f30104 ci - Add BMFF to windows matrix 2021-05-12 16:10:04 +02:00
Luis Díaz Más
e6e6c3c296 ci - coverage build - deal with SHA issue 2021-05-12 16:10:04 +02:00
Luis Díaz Más
1a383c46f5 ci - Special builds on Github actions 2021-05-12 16:10:04 +02:00
Luis Díaz Más
776d3a3efc Rename github workflows 2021-05-12 16:10:04 +02:00
Luis Díaz Más
012f05f9a1 ci - MacOS Matrix 2021-05-12 16:10:04 +02:00
Luis Díaz Más
2c3fcd3a59 No exe in executables 2021-05-12 16:10:04 +02:00
Luis Díaz Más
0d0c8ba0f3 Fixes in github actions 2021-05-12 16:10:04 +02:00
Luis Díaz Más
33facf01aa Github Actions - More builds on PRs 2021-05-12 16:10:04 +02:00
Luis Díaz Más
bfa297d587 MacOS build 2021-05-12 16:10:04 +02:00
Luis Diaz Mas
72798028f6 Less CI jobs on push 2021-05-12 16:10:04 +02:00
Luis Díaz Más
988fbe5653 ci - win: Use ninja and Visual Studio shell 2021-05-09 20:05:15 +02:00
Luis Díaz Más
102eef8097 Also test installation on Windows 2021-05-09 20:05:15 +02:00
Luis Diaz Mas
429ab8679a CiActions: Increasing matrix build for Windows 2021-05-09 20:05:15 +02:00
Christoph Hasse
404024791c fix archlinux ci build 2021-05-02 17:27:31 +02:00
Luis Díaz Más
e53da674d9 ci: add again arch linux & disable compilation&run of unit tests 2021-04-22 18:40:03 +02:00
Luis Díaz Más
3dbe445fbf ci: alpine linux support 2021-04-22 18:40:03 +02:00
Luis Díaz Más
6c5c2278cb ci: warnings_as_errors OFF 2021-04-22 18:40:03 +02:00
Luis Díaz Más
1cac0c3963 Do not treat warnings as errors 2021-04-22 18:40:03 +02:00
Luis Díaz Más
0e19de936d ci: update github actions
- Disable arch case which is suffering of a weird situation in which
CMake when trying to find GTest, it is failing with some error related
with GMock (which we do not use or install!)
- Updated ubuntu image to 20.04
- Use same CMake flags as we use on Travis
2021-04-22 18:40:03 +02:00
Kevin Backhouse
8e38b37fcb Add windows_distribution_check GitHub Action. 2021-04-22 18:40:03 +02:00
D4N
9a4eb0c624 Add linux_distribution_check github action 2021-04-22 18:40:03 +02:00
Robin Mills
848e580961 Fixed issue spotted in review. 2020-04-27 08:15:55 +01:00
Robin Mills
444a2680a3 fix_1121_CODEOWNERS_0.27 2020-04-27 07:26:00 +01:00