Luis Díaz Más
1f07715141
Revert "Delete dead code"
...
This reverts commit 1d6bac61f2 .
2022-02-08 07:57:22 +01:00
Luis Díaz Más
b96091880a
Merge pull request #2061 from Exiv2/main_pvs
...
Adding static analysis with PVS-Studio
2022-02-06 18:52:45 +01:00
Luis Díaz Más
ac9439e931
Merge pull request #2063 from Exiv2/main_iterators
...
Modernise code around iterators & smart pointers
2022-02-06 18:40:53 +01:00
Peter
46c329081f
Fix exiv2: verbose extract stdout mutli-file ( #2068 )
...
When using `exiv2 --verbose --extract` with stdout and multiple files, the output is concatenated together.
2022-02-05 16:43:34 +00:00
Luis Díaz Más
524fad42e1
Remove useless ops
2022-02-05 11:08:13 +01:00
Luis Díaz Más
93fe2086e4
Simplify TaskFactory
2022-02-05 11:02:58 +01:00
Luis Díaz Más
f18d04cb8f
Modern implementation of Singleton
...
With this implementation we also make the initialization of the Singleton instance thread-safe
2022-02-05 11:02:58 +01:00
Luis Díaz Más
d20f014807
Simplify cloning in actions
2022-02-05 11:02:56 +01:00
Luis Díaz Más
b67dee8a57
Fix build on linux
2022-02-05 11:02:04 +01:00
Luis Díaz Más
0f03e77634
Simplify code around UniquePtr(s) & use make_unique over new
2022-02-05 11:02:04 +01:00
Luis Díaz Más
db4b63937e
Add some TODO comments
2022-02-05 11:02:03 +01:00
Luis Díaz Más
9d8dd86945
Use auto to reduce verbosity around code dealing with iterators
2022-02-05 11:02:03 +01:00
Sturmflut
3b1d31e0af
Add Sigma 12-24mm F4 DG HSM Art lens for Nikon
2022-02-04 23:02:40 +01:00
Luis Díaz Más
a42501864a
Recover some documentation strings
2022-02-04 17:35:44 +01:00
Luis Díaz Más
c531c4abf5
More tests for IptcDataSets
2022-02-04 17:21:10 +01:00
Luis Díaz Más
476a254dfc
Remove dead code
...
No way to obtain nullptr DataSet* when we are checking already the 2
only existing DataSets above.
2022-02-04 17:21:10 +01:00
Luis Díaz Más
9b40f948eb
More tests
2022-02-04 17:21:10 +01:00
Luis Díaz Más
15e8c75a38
Delete unused IptcKey copy operator
2022-02-04 17:21:10 +01:00
Luis Díaz Más
d8fcbc4562
Add new tests for Iptc classes
2022-02-04 17:21:10 +01:00
Luis Díaz Más
df0b7c450d
Hide public details
2022-02-04 17:21:10 +01:00
Luis Díaz Más
8f9a780375
clang-format on datasets.cpp
2022-02-04 17:21:10 +01:00
Luis Díaz Más
1d6bac61f2
Delete dead code
2022-02-04 17:21:10 +01:00
Luis Díaz Más
071e73fa4d
Add many tests for datasets
2022-02-04 17:21:10 +01:00
Luis Díaz Más
a94d648d05
Rest of tests to have 100% coverage in BMP class
2022-02-04 17:21:10 +01:00
Luis Diaz
edf39e00dd
Add new BMP tests
2022-02-04 17:21:10 +01:00
Josh Soref
e56abfa10a
Spelling ( #2067 )
...
* spelling: accelerometer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: address
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: anonymous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: available
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: baby
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: buffer
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: build
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: builds
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: by inclusion
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: byte order
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: camera
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: command
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: consistency
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: constructor
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: continuously
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: correspond
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: decompression
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dedicated
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: denominator
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dependencies
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: detector
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dlighting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dragging
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: duplicate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: dynamic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: empty
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: enable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: endianness
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: examining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: exceed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: extension
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fact
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fails
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fixed
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: fluorescent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoint
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: focuspoints
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: from
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: happened
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: hierarchy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: initiate
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: interesting
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: internal
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: javascript
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: language
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libiconv
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: libraries
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: library
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: localization
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: macros
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: member
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: members
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: metadata
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: miscellaneous
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mnemonic
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: modified
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multiple
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: multithreaded
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: mysterious
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: photoshop
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: platforms
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: preliminary
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: priority
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: properties
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: qualifier
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognition
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: recognized
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: reentrancy
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remaining
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: remotetest
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: requested
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: sensitivity
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: standardize
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: successful
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: such
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: tags
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: temperature
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: test
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: the
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: these
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: third
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: this
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: transparent
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: unable
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: underwater
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: uninterpreted
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: using
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: utc - coordinated universal time
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: which
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
* spelling: with
Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <jsoref@users.noreply.github.com>
2022-02-04 08:53:04 +01:00
postscript-dev
da320f35a7
Remove experimental code from pr#2053
2022-01-11 11:36:05 +00:00
postscript-dev
6c59437319
Add IPTC 2021.1 source comments for pr#2053
2022-01-11 11:07:49 +00:00
postscript-dev
fe83240bb8
Update XMP IPTC tags to 2021.1 standard
...
Changes:
1. Add/update tags.
2. According to the standard, several tags in
`Xmp.iptc.<property>` and `Xmp.iptcExt.<property>`, had been
wrongly added, as they only exist as part of a struct used by a
tag. The incorrect tags have been marked as deprecated in the
label and description.
3. Update existing test with translated output.
Ref: [IPTC Photo Metadata Standard 2021.1](https://www.iptc.org/std/photometadata/specification/IPTC-PhotoMetadata-2021.1.html )
2022-01-10 15:55:53 +00:00
Luis Díaz Más
b0318c36be
Upgrade C++ standard to c++17 ( #2052 )
...
* Enable C++17 and use new inline specifier for const variable members
* Silence deprecation warning on MSVC
* Disable samples by default
* improvements after review
2022-01-09 20:09:34 +01:00
Peter
629442df9d
Merge pull request #1929 from postscript-dev/fix_exiv2_-pR
...
Fix `exiv2 -pR` for Sony images (#1805 )
2022-01-09 15:25:24 +00:00
Luis Díaz Más
825c0c72bc
Check array index before inspecting it
2022-01-07 09:38:42 +01:00
Luis Díaz Más
240a72468e
Clang-format in pngchunk_int.cpp
2022-01-07 09:38:42 +01:00
Luis Díaz Más
ec21f65dca
Replace magicValue with constant variable
2022-01-07 09:38:42 +01:00
Luis Díaz Más
ceae86899d
Initialize uninitialized variables
2022-01-07 09:38:42 +01:00
Luis Díaz Más
b96f5af037
Remove dead code
2022-01-07 09:38:42 +01:00
Luis Díaz Más
061df50cea
keyTXTChunk improvement
2022-01-07 09:38:42 +01:00
Luis Diaz
c19425f6a4
Add unit tests for PngChunk::keyTXTChunk
2022-01-07 09:38:42 +01:00
Luis Diaz
c898f56ab2
cmake: Add missing source file
2022-01-07 09:38:42 +01:00
Luis Díaz Más
813566526c
Revisiting cmake code for generating coverage reports ( #2047 )
...
* cmake: better usage of gcovr for coverage reports
* Add test for FileIo::setPath
* Remove useless seek() overload
* Add missing override specifiers
* ignore .vs folder
* Small refactors in BasicIo implementations
* Remove duplicated doxygen doc
* Refactor & add tests for MemIO
* Fix compilation warnings on windows
2022-01-06 12:52:01 +01:00
Kevin Backhouse
a094dde1de
Merge pull request #2040 from kevinbackhouse/TiffEntryBaseStorage
...
Use std::shared_ptr for storage in TiffEntryBase
2022-01-02 15:39:42 +00:00
Facundo
b52b6db39f
Output of -PV was not suitable for inputting to -m-, key was missing. ( #1970 )
...
* Output of -PV was not suitable for inputting to -m-, key was missing.
Fix #1969
* Make V flag to -P also print the type
This makes -PV work also for non-built-in tags (of which their type is
not known by exiv2).
* Adjust man to accomodate for the V flag change
2021-12-29 17:19:23 +01:00
Kevin Backhouse
9268279b47
Add comments.
2021-12-24 15:04:14 +00:00
Kevin Backhouse
b6a4fd1c67
Add storage parameter to setData.
2021-12-24 12:54:35 +00:00
Kevin Backhouse
29f7d0ccf0
Remove DataBuf::release() which is no longer used.
2021-12-24 12:35:46 +00:00
Kevin Backhouse
9f3240c91c
Delete TiffEntryBase::isMalloced_ field and use a std::shared_ptr instead.
2021-12-24 12:32:48 +00:00
Kevin Backhouse
29cc981180
Merge pull request #2028 from kevinbackhouse/FixIssue2027
...
Use memmove in TiffEncoder::updateDirEntry
2021-12-14 11:44:53 +00:00
Robin Mills
13a2cf336d
fix_1416_iptc_DateCreated ( #1547 )
...
* fix_1416_iptc_DateCreated
* Fix unit tests
* DateValue:read 2nd iteration on pre-condition
* test with ISO_8601 date format
* Use std::regex for ISO 8601 basic & extended date formats
* Use std::regex for ISO 8601 basic & extended time formats
* Add more tests & notes for DateValue & TimeValue
* Comment tests using local calendar times
* DateValue::write also adds padding to year field
Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
2021-12-14 11:20:02 +01:00
Kevin Backhouse
e34eacc467
Use memmove, rather than memcpy, because memory regions might overlap.
2021-12-13 12:22:54 +00:00
Miloš Komarčević
fd8447129c
Add more DNG 1.6 tags ( #2023 )
...
* Add more DNG 1.6 tags
* Update CinemaDNG, add more spec links
2021-12-11 09:29:53 +01:00