Commit Graph

335 Commits

Author SHA1 Message Date
Rosen Penev
e5894d71e1 default con/destructors in headers
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-19 23:31:50 -07:00
Rosen Penev
ff39473c18 clang-tidy: convert to static
Found with readability-convert-member-functions-to-static

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-19 14:45:20 +02:00
Rosen Penev
6da49fd29b more constexpr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-19 14:11:42 +02:00
Rosen Penev
036af68a71 remove pointless constructors
Replaced with Uniform initialization. Allows constexpr usage.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-19 14:11:42 +02:00
Rosen Penev
8564d0b394 clang-tidy: pass by value
Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-18 14:30:08 +02:00
Rosen Penev
f9d394adf0 clang-tidy: run through performance checks
Found with performance*

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-18 14:30:08 +02:00
Rosen Penev
4aa5566cf6 clang-tidy: make several member functions const
Found with readability-make-member-function-const

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-15 08:42:04 +02:00
Rosen Penev
674fdcd38b clang-tidy: fix declartation names
Found with readability-inconsistent-declaration-parameter-name

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-12 09:26:51 +02:00
Rosen Penev
2e73aa9dc0 default con/destructors in headers
Helps to optimize trivially destructable stuff.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-12 09:10:36 +02:00
Luis Díaz Más
b675c58bab Move include/CMake to src 2021-05-04 12:36:14 +02:00
tbeu
bf0d8114c9 #525: Update comment and fix variable name 2021-05-03 17:41:55 +02:00
tbeu
94420ab591 Remove custom rwlock in favor of std::mutex of C++11
Current design on Windows was broken anyway, since legacy class `RWLock` does not implement a proper rwlock (shared read and exclusive write)

Once we are allowed using C++14 features, we can replace the `std::mutex` by `std::shared_timed_mutex` and the read-access locks by `std::shared_lock`.
Once we are allowed using C++17 features, we can replace the `std::mutex` by `std::shared_mutex` and the read-acces locks by `std::shared_lock`.
2021-05-03 17:41:55 +02:00
Miloš Komarčević
bc37a6ccb4 Update bmffimage.hpp include order and path
No need to treat it differently since 206a2c495c

(could even back-port to 0.27 if there is RC3 coming)
2021-05-03 14:50:20 +02:00
Luis Díaz Más
d5240a4bda eps: Fix code after usage of unique_ptr. Remove deprecation tags 2021-04-22 18:39:31 +02:00
Luis Díaz Más
ed6cbf77b4 Revert "eps - do not install header"
This reverts commit 8f16196ad3.
2021-04-22 18:39:31 +02:00
Luis Díaz Más
8314030604 Revert "Remove deprecated EPS format"
This reverts commit 537cdad99e.
2021-04-22 18:39:31 +02:00
Luis Díaz Más
75e4bd9059 Remove rest of useless typedefs from datasets.hpp 2021-04-19 10:43:46 +02:00
Luis Díaz Más
75bf666d3b Remove typedef to Dictionary::const_iterator 2021-04-19 10:43:46 +02:00
Luis Díaz Más
83dda6ccd7 Fix warnings related to -Wdeprecated-copy 2021-04-18 18:49:58 +02:00
Luis Díaz Más
2de3bad869 Remove EXIV2_ENABLE_VIDEO and related stuff 2021-04-18 09:44:51 +02:00
Luis Díaz Más
3eb1eee7fe Remove deprecated RiffVideo support 2021-04-18 09:44:51 +02:00
Luis Díaz Más
061ec1a75d Remove deprecated QuickTime support 2021-04-18 09:44:51 +02:00
Luis Díaz Más
8dcc07887a Remove deprecated Matroska support 2021-04-18 09:44:51 +02:00
Luis Díaz Más
94b87a8dec Remove deprecated SSH support 2021-04-18 09:44:51 +02:00
Luis Díaz Más
384a5edfcf Remove deprecated ASF Video 2021-04-18 09:44:51 +02:00
Robin Mills
b19e79650f Only reveal class bmffimage in include/exiv2/bmffimage.hpp ifdef EXV_ENABLE_BMFF 2021-04-16 08:23:50 +02:00
Robin Mills
206a2c495c fix_enableBMFF_v1 2021-04-16 08:23:50 +02:00
Luis Díaz Más
8f16196ad3 eps - do not install header 2021-04-15 06:56:37 +02:00
Luis Díaz Más
0bbaa6eff3 cpp: Replace auto_ptr by unique_ptr 2021-04-15 06:56:11 +02:00
Luis Díaz Más
537cdad99e Remove deprecated EPS format 2021-04-15 06:56:11 +02:00
Robin Mills
d632988bbd Massive code prolog cleanup. 2021-03-17 13:34:21 +00:00
Robin Mills
9e2ac47cf9
Merge pull request #1475 from 1div0/BMFF
Base Media File Format
2021-03-10 10:34:21 +00:00
clanmills
e3fd0c633e Thank You @piponazo for the code review. I've made the changes you requested. 2021-03-09 14:10:52 +00:00
Miloš Komarčević
0da1a50afe Revert style changes 2021-03-08 18:18:17 +01:00
Miloš Komarčević
e09d093ccf Minor whitespace formatting 2021-03-08 11:58:06 +01:00
clanmills
ae66869695 Updated to adopt Review suggestions by @kmilos. Thank You, Milos. 2021-03-08 10:04:27 +00:00
postscript-dev
6cd9263fa7 Fix langAltValue::read() parsing
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
  + Some tests commented out as quotation marks are filtered, preventing them
    from running.
Closes #1481.
2021-03-06 18:59:31 +00:00
clanmills
0ad46453ed With good fortune, bmffimage is ready for review. 2021-03-06 16:12:02 +00:00
Robin Mills
71d29fe60b Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows. 2021-03-03 14:34:15 +00:00
Robin Mills
fd9cb67fb7 WIP: adding BmffImage::printStructure() and support for colr box. 2021-03-02 14:39:56 +00:00
Robin Mills
ea1c91874f Added parseXmp() to parse Xmp metadata. 2021-02-28 11:29:09 +00:00
Robin Mills
44d976c2a1 Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp 2021-02-26 10:21:12 +00:00
Robin Mills
5c77888037 Revised following code review by @hassec. Thank You, Christoph. 2021-02-25 18:10:48 +00:00
Peter Kovář
4d3af08ad8 Add CR3 image dimensions 2021-02-25 18:42:34 +01:00
Robin Mills
4ae0a1d2a3 Tidy up. Rename Tag::cr3_exif -> Tag:cmt2 2021-02-25 15:25:09 +00:00
Robin Mills
9515e4658b Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp. 2021-02-25 14:47:20 +00:00
Robin Mills
913ee33372 Parse Exif in .HEIC/.AVIF 2021-02-25 12:28:50 +00:00
Christoph Hasse
28b41f59bd run clang-format on new files 2021-02-25 10:42:38 +01:00
Christoph Hasse
29f3d5cac9 introduce parseTiff method to parse exif 2021-02-25 10:38:26 +01:00
Robin Mills
f190f496d1 Tidying up. 1. pixelHeight_. 2. refactored indenter() -> indent(). 3. EXIV2_DEBUG_MESSAGES outputs to std::cerr 2021-02-25 05:50:54 +00:00