Commit Graph

151 Commits

Author SHA1 Message Date
Colin Watson
f643d9bb5e Annotate some strings with xgettext:no-c-format
Some descriptions of location properties contain the text "100%
overlap".  When extracting text for translation, `xgettext`
misidentifies this as containing the C format string "% o", and tags it
as `c-format`.  Translation tools that are sensitive to this will
require that translations contain matching format strings; since in this
case the format string is nonsensical, that is often not reasonably
possible.  See:

  https://answers.launchpad.net/launchpad/+question/698762

The description of the DotRange tag contains the text "0% dot and 100%
dot", which is similarly misidentified.

To fix this, inform `xgettext` that the messages do not contain C format
strings, as documented here (towards the end):

  https://www.gnu.org/software/gettext/manual/html_node/c_002dformat-Flag.html
2021-09-17 11:35:28 +01:00
Kevin Backhouse
dc2c77ce81
Safer std::vector indexing. 2021-07-18 14:40:45 +01:00
Rosen Penev
2c57f214c5 clang-tidy: use nullptr
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-26 08:31:45 +02:00
Rosen Penev
86c71ae6c3 clang-tidy: avoid global non const variables
Found with cppcoreguidelines-avoid-non-const-global-variables

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-25 08:43:27 +02:00
Rosen Penev
6da49fd29b more constexpr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-19 14:11:42 +02:00
Rosen Penev
8564d0b394 clang-tidy: pass by value
Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-18 14:30:08 +02:00
Rosen Penev
b8712188bb clang-tidy: use auto
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-17 21:52:03 +02:00
Rosen Penev
1b9b77c51f clang-tidy: add ending namespace comments
Found with google-readability-namespace-comments

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-14 17:34:09 +02:00
Rosen Penev
8337462032 clang-tidy: use empty() instead of comparing size
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-11 22:02:47 +02:00
Rosen Penev
8128716287 clang-tidy: use = default
Found with modernize-use-equals-default

Ran through git clang-format

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-09 15:18:50 +02:00
tbeu
bf0d8114c9 #525: Update comment and fix variable name 2021-05-03 17:41:55 +02:00
tbeu
94420ab591 Remove custom rwlock in favor of std::mutex of C++11
Current design on Windows was broken anyway, since legacy class `RWLock` does not implement a proper rwlock (shared read and exclusive write)

Once we are allowed using C++14 features, we can replace the `std::mutex` by `std::shared_timed_mutex` and the read-access locks by `std::shared_lock`.
Once we are allowed using C++17 features, we can replace the `std::mutex` by `std::shared_mutex` and the read-acces locks by `std::shared_lock`.
2021-05-03 17:41:55 +02:00
Rosen Penev
4ceb325c8f clang-tidy: range for loop conversions
Found with modernize-loop-convert

Ran through git clang-format.

Also removed several questionable loops and replaced with simpler
algorithms.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-03 14:50:04 +02:00
Luis Díaz Más
83dda6ccd7 Fix warnings related to -Wdeprecated-copy 2021-04-18 18:49:58 +02:00
Luis Díaz Más
0bbaa6eff3 cpp: Replace auto_ptr by unique_ptr 2021-04-15 06:56:11 +02:00
Robin Mills
d632988bbd Massive code prolog cleanup. 2021-03-17 13:34:21 +00:00
clanmills
bf1be5cb50 fix_1473_LocationShown 2021-03-11 11:02:10 +00:00
Robin Mills
e887b6487f fix_1393_iptc_tags_web_0.27 2020-11-19 09:21:56 +00:00
clanmills
3ee25009ee fix_1033_0.27 2020-04-06 13:18:38 +01:00
Luis Díaz Más
113136e134 Replace DEBUG with EXIV2_DEBUG_MESSAGES
Fixes #926
2019-07-12 11:14:35 +02:00
Luis Díaz Más
603692a1d8 Copyright to Exiv2 authors 2018-09-12 19:22:31 +02:00
Dan Čermák
316548d2de Fix shadowing issues
- renamed variables that were shadowing a previously defined variables
2018-05-16 10:15:53 +02:00
Dan Čermák
2bf89f4854 Store pointers to Impl classes in auto_ptr
Pimpl class Impl is stored in raw pointers which are allocated on the heap in
the constructor. However, the constructor can throw an exception resulting in a
memory leak as the destructor is **not** invoked.
=> A smart pointer is however properly deallocated.
2018-04-25 00:13:26 +02:00
Luis Díaz Más
bf7047a71b clang-format XmpKey code 2018-04-07 20:04:22 +02:00
HumanDynamo
22a0b32c01 Fix typo of Xmp.video.AspectRatio's value type 2018-03-24 09:11:32 +01:00
Dan Čermák
efe2ccdcb6 Replaced all hardcoded error codes with ker... constants 2018-02-18 09:28:57 +01:00
tbeu
5b5987a596 Remove obsolete EXIV2_RCSID 2017-11-19 11:17:12 +01:00
tbeu
5df8b01b77 Remove obsolete svn revision 2017-11-19 11:17:11 +01:00
clanmills
935421c855 Refactoring autotools to support ADOBE_XMPSDK (Work in Progress) 2017-08-15 20:00:09 +01:00
Robin Mills
192a2a83cf #1279 Cleaned up doxygen warnings for doc and website. 2017-03-16 18:13:12 +00:00
Robin Mills
6d5c2c3256 Getting ready to release v0.26 2017-03-08 20:42:28 +00:00
Robin Mills
54cfc47346 class RWLock should not be in the Exiv2::Internal namespace 2017-03-07 21:30:05 +00:00
tbeu
d02560da36 Remove trailing blank from translation string 2016-08-18 20:15:33 +00:00
tbeu
26a94799f1 Fix encoding 2016-08-15 20:15:22 +00:00
Robin Mills
50def5c02d #1189 Code change provided by private email from Taras. Thank You Taras. 2016-07-20 19:23:56 +00:00
asp
1a8f8f6259 #1190 nested CRS properties from Darktable & Exiftool 2016-06-19 19:13:04 +00:00
asp
8acee2a341 #1190 additional CRS properties from Darktable & Exiftool 2016-06-19 15:28:20 +00:00
asp
c8a400e1c5 #1190 Add crss XMP namespace and properties 2016-06-15 21:15:15 +00:00
asp
a5bd6d84ce #1193 XMP Specification November 2014 updates 2016-06-15 19:59:47 +00:00
Robin Mills
b15a401569 #1187 Thank You to Taras for the patch. 2016-05-30 14:45:28 +00:00
Andreas Huggel
f5eb9b50a4 #1116: Register missing namespaces (audio, video), changed xapG to xmpG in accordance with the XMP specs. 2015-10-10 07:19:34 +00:00
asp
469b2e6df0 #1111 Deprecated NOT Depreciated. ExifEX typo. 2015-09-22 00:24:05 +00:00
Robin Mills
6767878fb8 #1116. Fix submitted. 2015-09-08 22:17:45 +00:00
Robin Mills
ed2751612d #640 Public API to reveal all namespaces known to Exiv2 and XMPsdk is XmpProperties::registeredNamespaces(Exiv2::Dictionary&) 2015-09-08 13:01:05 +00:00
asp
89fd2149c6 #1093 ExifEX fixed typo missing comma 2015-08-05 19:06:34 +00:00
asp
3ec3708f94 #1093 ExifEX for XMP namespace and properties 2015-08-05 17:39:12 +00:00
asp
699671605b #1085 typos. Thanks Anders Jonsson! 2015-05-20 01:27:32 +00:00
asp
b27a8e3288 Typos in XMP property labels and descriptions 2015-05-09 17:42:33 +00:00
Andreas Huggel
fd80993ab0 Updated copyright notice. 2015-05-02 11:55:40 +00:00
asp
0b4e20cccd website: re-order tags, document nested XMP properties 2015-04-27 05:09:17 +00:00