Commit Graph

8872 Commits

Author SHA1 Message Date
Kevin Backhouse
ddd7ccf722 Use std::is_signed and std::enable_if. 2022-10-31 17:17:37 -07:00
Kevin Backhouse
335e13251e Add #error so the build fails if mmap isn't supported. 2022-10-31 03:01:26 -07:00
Kevin Backhouse
5cabd97373 Fix issue 2380: bug in (unused) non-mmap code. 2022-10-31 03:01:26 -07:00
Kevin Backhouse
abd817d181 Use size_t for sizes and offsets. 2022-10-31 03:00:47 -07:00
Kevin Backhouse
c96bc47509 Change return type of getFileLength() to int64_t. 2022-10-31 02:59:34 -07:00
Kevin Backhouse
d599d36f8b
Merge pull request #2394 from kevinbackhouse/fix-issue-2393
stop looping when eof is hit
2022-10-30 14:24:32 +00:00
Rosen Penev
28d1880176 replace find/rfind with startsWith
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-10-28 11:05:23 -07:00
Kevin Backhouse
771ead8732
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52731
Stop looping when eof is hit.
2022-10-26 22:07:11 +01:00
Kevin Backhouse
951247edcc
Regression test for https://github.com/Exiv2/exiv2/issues/2393 2022-10-26 22:02:01 +01:00
Miloš Komarčević
761acafd69
Merge pull request #2216 from Exiv2/add_rf_lenses
Add more Canon RF lenses
2022-10-26 15:58:07 +02:00
Miloš Komarčević
c077a06ada Add more Canon RF lenses and camera IDs 2022-10-26 14:24:01 +02:00
Miloš Komarčević
75f7285487 Remove translatable mark from RF lenses 2022-10-26 14:12:53 +02:00
Miloš Komarčević
7efc733bf2 Add an RF lens regression test 2022-10-26 14:12:53 +02:00
Miloš Komarčević
ecfdaca525 Add more Canon RF lenses 2022-10-26 14:12:53 +02:00
Miloš Komarčević
1f5bc3b8a5
Avoid buffer reallocation (#2392) 2022-10-25 16:30:45 +02:00
Kevin Backhouse
fb6b769817
Merge pull request #2390 from kevinbackhouse/tiffvisitor-safe-add
Use Safe::add() in tiffvisitor_int.cpp
2022-10-24 12:59:37 +01:00
Miloš Komarčević
1ae3a83fcc
Merge pull request #2381 from Exiv2/jxl_brotli
Support brotli compressed boxes in JPEG XL
2022-10-24 13:13:54 +02:00
Miloš Komarčević
a58e52ed70 Use safe add to prevent overflow
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>

Use safe add to prevent overflow

Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
2022-10-24 12:32:52 +02:00
Miloš Komarčević
23cdcc48d7 Install deps for and bump CodeQL action 2022-10-24 12:32:52 +02:00
Miloš Komarčević
557a5cebd5 Make brotli dependency controllable 2022-10-24 12:32:52 +02:00
Miloš Komarčević
c334fa3ce9 Use local cmake module path the last 2022-10-24 12:32:52 +02:00
Miloš Komarčević
eada606992 Match Conan's cmake find module case for Brotli 2022-10-24 12:32:51 +02:00
Miloš Komarčević
1e395ff98f Update README for brotli dependency 2022-10-24 12:32:51 +02:00
Miloš Komarčević
9a6ee59421 Support brotli compressed boxes in JPEG XL 2022-10-24 12:32:51 +02:00
Miloš Komarčević
ee698689b4 Exif start can be at any byte in payload, not word aligned 2022-10-24 12:32:51 +02:00
Kevin Backhouse
62705a6615
Use Safe::add() in tiffvisitor_int.cpp 2022-10-23 20:04:42 +01:00
Peter
9767e375af
Update makernote model ID tags (#2389)
* Update `Exif.Sony(1|2).SonyModelID` values

* Update `Exif.Pentax.ModelID` values

* Update `Exif.Canon.ModelID` values

* Purge duplicates in `Exif.Canon.ModelID`

* Correct text in `Exif.Canon.ModelID`
2022-10-23 14:35:35 +01:00
Kevin Backhouse
3897f17b1e Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52355
Avoid integer overflow when temp == INT_MIN.
2022-10-22 10:41:11 -07:00
Kevin Backhouse
f3f66c56db Regression test for https://github.com/Exiv2/exiv2/issues/2385 2022-10-22 10:41:11 -07:00
Kevin Backhouse
03abb2c109
Merge pull request #2384 from kevinbackhouse/fix-issue-2383
Avoid null pointer deref
2022-10-22 17:03:26 +01:00
Kevin Backhouse
222c45c154
Merge pull request #2374 from norbertwg/update_easyAccessAPI
several keys added to easyaccess
2022-10-22 16:29:55 +01:00
Kevin Backhouse
6bb956ad80
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52382
Avoid null pointer deref.
2022-10-22 15:55:02 +01:00
Kevin Backhouse
baf1969ec7
Regression test for https://github.com/Exiv2/exiv2/issues/2383 2022-10-22 15:54:20 +01:00
Kevin Backhouse
b90426dda9
Merge pull request #2378 from kevinbackhouse/fix-issue-2376-2377
Fix bugs in QuickTimeVideo::userDataDecoder
2022-10-10 11:32:38 +01:00
norbertwg
3c87d82cd0 fix for GCC compiler error, test reference file 2022-10-09 15:55:58 +02:00
Kevin Backhouse
597e372b1c
clang-format 2022-10-08 22:33:48 +01:00
Kevin Backhouse
459910c36a
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51751
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52053
Avoid null pointer deref and heap buffer overflow.
2022-10-08 21:40:04 +01:00
Rosen Penev
fd7566fcd8 get rid of nested if conditions
Easier to read with lambdas.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-10-08 11:05:31 -07:00
norbertwg
1d291ba06d test reference files added 2022-10-08 16:22:23 +02:00
norbertwg
e38d3d9976 several keys added to easyaccess
sample easyaccess-test enhanced with additional optional arguments
"category" for easier definition of some tests
2022-10-07 18:25:25 +02:00
Peter
a2cb06a28e
Fix/add exceptions for BMFF based files (#2364)
* Fix BmffImage::writeMetadata() error id/message

* Add exceptions setting Exif/IPTC/XMP in BMFF

* Add missing header for new functions
2022-10-03 14:50:34 +01:00
Kevin Backhouse
a8a35345c8 Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51241
Fix bounds checking bug.
2022-09-28 21:23:38 -07:00
Kevin Backhouse
b1e2cc6129 Regression test for https://github.com/Exiv2/exiv2/issues/2352 2022-09-28 21:23:38 -07:00
Kevin Backhouse
b3bd36c749 clang-format 2022-09-28 21:22:35 -07:00
Kevin Backhouse
0db460c9b0 nul-terminate string 2022-09-28 21:22:35 -07:00
Kevin Backhouse
a38e124076 Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51707
Resize buf to avoid buffer overflow.
2022-09-28 21:22:35 -07:00
Kevin Backhouse
a94b02063a Regression test for https://github.com/Exiv2/exiv2/issues/2366 2022-09-28 21:22:35 -07:00
Rosen Penev
d856ca7d82 cland-tidy: simplify booleans
Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-09-27 06:40:37 -07:00
Peter
9dc34ad39c
Update Sony(1|2) tags (#2323)
* Update Sony(1|2) group (minor Minolta changes)

Transcribe all tags (except for `LensID`) from main ExifTool Sony
group into Exiv2.
Changes include:
- Rename `ColorReproduction` -> `CreativeStyle` and
  `LongExposureNoiseReduction` -> `FocusMode3` to reflect use.
- Rename `0x*` tagnames to equivalent ExifTool tags (e.g.,
  `0x2006` -> `Sharpness`).
- Remove tag entries that are Groups (e.g., `ShotInfo`).
- Separate some common Sony/Minolta data as the camera types use
  different values (e.g., `Quality`)
- Additional `exiv2-Sony*.exv` test files come from ExifTool Sony
  samples (https://exiftool.org/Sony.tar.gz).

ExifTool Sony tags sources:
https://www.exiftool.org/TagNames/Sony.html
1e17485cbb/lib/Image/ExifTool/Sony.pm

* Improve coverage of `Sony(1|2)` group

* Fix clang compilation on macOS

* Fix github-code-scanning warnings

* Fix minor `Exif.Sony(1|2)` problems

* Fix tests and update `Sony(1|2)` group coverage

* Fix testing

* Minor fixes and regenerate Regression data

* Update Sony tags with `getModel()`

Make finding the Sony model more resilient by also using
`SonyModelID`.

* Fix `Exif.Sony(1|2).AFPointsUsed` type

* Improve `Exif.Sony(1|2).*` coverage

* Fix types in Sony func `getFocusMode()`

* Update Regression tests for `Sony(1|2)`

* Minor fixes to `Sony(1|2)` tags

* Update `Sony(1|2)` tag coverage

* Improve `Sony(1|2)` tag coverage

* Update easyaccess with `Exif.Sony(1|2)` tags

* Update `SonyModelID` array comment

* Add Sony `LensSpec` tag to easyaccess

* Update `Sony(1|2)` label/descriptions

* Update `int` to `size_t` (credit:@kevinbackhouse)

* Fix Windows build warning in `src/tags_int.hpp`
2022-09-27 09:26:26 +01:00
Rosen Penev
84f566b4b7 use reference to work around MSVC bug
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-09-25 14:50:53 -07:00