b16cd52b88
Replace sprintf with snprintf.
2021-06-27 10:27:54 +02:00
2b84f4bd64
fix: zero initialize local variables. ( #1743 )
...
* Zero initialize local variables.
* Initialize xmpID_
2021-06-27 08:56:31 +02:00
f30022d73d
Fix issues detected with PVS-Studio + other little improvements ( #1689 )
...
* avoid re-declaration of constant variables
* Replace pthreads critical section with std::mutex
* ci - better naming
* cmake - increase minimum version to 3.11. Use project DESCRIPTION
* fix - do not treat string::find() return type as bool
* remove conditions that were always true
* remove condition that were always false
* Remove EXV_HAVE_GMTIME_R which is not used anymore
* pixelWidth_ was inherited from Exiv2::Image
The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...
* Remove superfluous if
* pvs:V766 item with identical key added already
* pvs:V730 not all members were initialized (time)
* pvs:V730 not all members are initialized
* pvs:v668 no point in testing pointer against null after new
* pvs:V1048 variable assigned the same value
* replace c-style dynamic vector with std one
* pvs:547 fakeData is always true
* Remove useless constructor in derived class
* pvs:V690 modern way to disable copy-ctor
* Replace malloc/free with new/delete. No need to check for null
* pvs:V1028 cast operands and not result
* Remove custom MIN/MAX functions
* pvs:V595 pointer used before verified against null
* pvs: index used before being checked
* pvs:V1028 possible overflow. Cast operands
* pvs:v575 potential null pointer passed to other functions
* pvs:V547 deal with always true/false expressions
* pvs:V560 part of conditional expressions always false or true
* pvs:V701 possible break in realloc -> move to std::vector
* Make some classes 'final'
* Replace sprintf with std::to_string()
* fix compilation on windows
2021-06-01 12:39:10 +02:00
2c57f214c5
clang-tidy: use nullptr
...
Found with modernize-use-nullptr
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-26 08:31:45 +02:00
743da1a564
clang-tidy: use C++ casting
...
Found with google-readability-casting
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-20 07:29:02 +02:00
cdbee3c26c
clang-tidy: init in member initializer
...
Found with cppcoreguidelines-prefer-member-initializer
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-19 14:11:42 +02:00
f9d394adf0
clang-tidy: run through performance checks
...
Found with performance*
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-18 14:30:08 +02:00
b8712188bb
clang-tidy: use auto
...
Found with modernize-use-auto
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-17 21:52:03 +02:00
4aa5566cf6
clang-tidy: make several member functions const
...
Found with readability-make-member-function-const
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-15 08:42:04 +02:00
fddb035106
clang-tidy: remove pointless const
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-13 16:02:18 +02:00
80595f8468
clang-tidy: remove duplicate public
...
Found with readability-redundant-access-specifiers
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-13 11:52:02 +02:00
15f0a600ed
clang-tidy: use default member init
...
Found with modernize-use-default-member-init
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-11 15:01:26 +02:00
bd6a996181
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-09 17:42:51 +02:00
8128716287
clang-tidy: use = default
...
Found with modernize-use-equals-default
Ran through git clang-format
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-09 15:18:50 +02:00
4ceb325c8f
clang-tidy: range for loop conversions
...
Found with modernize-loop-convert
Ran through git clang-format.
Also removed several questionable loops and replaced with simpler
algorithms.
Signed-off-by: Rosen Penev <rosenp@gmail.com >
2021-05-03 14:50:04 +02:00
83dda6ccd7
Fix warnings related to -Wdeprecated-copy
2021-04-18 18:49:58 +02:00
0bbaa6eff3
cpp: Replace auto_ptr by unique_ptr
2021-04-15 06:56:11 +02:00
4a8d365e80
fix_1508_enableBMMF_effort2
2021-04-03 11:03:31 +01:00
9da2aed5d2
Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code.
2021-04-02 16:58:20 +01:00
d632988bbd
Massive code prolog cleanup.
2021-03-17 13:34:21 +00:00
da1b02d644
fix_1268_GPSProcessingMethod
2020-08-29 12:10:50 +01:00
8f5b740270
put them back.
2020-05-02 19:05:25 +01:00
79b37ec3aa
Putting geotag.cpp back into the product (git strikes again)
2020-05-02 18:48:53 +01:00
cd9ee99567
Delete geotag.cpp
2020-05-02 18:33:10 +01:00
d994161e80
Added option -remove to samples/geotag.cpp
2020-05-01 17:40:20 +01:00
759ce9fffe
fix_1046_sample_geotag Take advantage of fix to #1046 in samples/geotag.cpp
2020-05-01 16:18:01 +01:00
13565be3d2
Change for solaris.
2020-04-15 16:53:03 +01:00
7844b11e4b
[xmpsdk] Add XMP Initialisation/Cleanup code to all main() programs
...
- update documentation
- Removed redundant calls to Exiv2::XmpParser::terminate() (legacy of our
discusssion with @tester0077).
- this fixes #976
2019-10-05 10:19:53 +02:00
113136e134
Replace DEBUG with EXIV2_DEBUG_MESSAGES
...
Fixes #926
2019-07-12 11:14:35 +02:00
2d1e1fe6ef
Reduce the scope of variables
2018-11-07 23:17:26 +01:00
dc7eb5008b
Add explicit to constructors with 1 argument
2018-11-07 23:17:26 +01:00
c43d998457
Fix cppcheck issues: passedByValue
2018-10-11 13:40:03 +02:00
989acd18c7
Fix cppcheck issues: uninitMemberVar & uninitVar
2018-10-11 13:40:03 +02:00
773bdfd14e
Create a header where to keep an unique definition of UNUSED
2018-05-31 14:44:24 +02:00
d55b2b1b65
Remove HAVE_STDLIB_H check and replace stdlib.h by cstdlib
2018-05-04 11:20:43 +02:00
548d7688c7
samples/geotag.cpp: fixed debugging code to be in the correct ifdef
2018-04-08 07:45:48 +02:00
5df8b01b77
Remove obsolete svn revision
2017-11-19 11:17:11 +01:00
038fe6cb94
#1233 Fixed bug in samples/geotag.cpp
2017-05-08 10:57:28 +01:00
1b536bd0ed
#2130 Don't build conntest. Build is broken when --enable-webready. Fixed issue with samples/geotag.cpp on Linux.
2016-09-29 17:06:02 +00:00
fcd0cb3e19
#1233 Correction to r4573
2016-09-27 18:52:18 +00:00
86028dd46e
#1233 Fixed issue on MacOS-X 10.4 (32 big big-endian PPC, 2003 OS) with realpath() and added additional images for future testing.
2016-09-27 18:47:54 +00:00
80fd8ee333
#1233 geotag.cpp added option -ascii. The degree sign in the output was upsetting test harness on some platforms.
2016-09-27 13:56:03 +00:00
24c032c2a2
#1233 Changes to geotag-test to avoid full paths. Added make geotag-test. Sanitized geotag.cpp code
2016-09-27 08:53:35 +00:00
bd16f3441e
#1233 Thank You to Anton for reporting this and providing a patch. I've updated the test suite.
2016-09-26 22:53:42 +00:00
a57317f685
Some API policing
2015-06-08 14:39:59 +00:00
4817df0a17
#936 . Fix header file.
2015-04-28 14:15:17 +00:00
856ddd323c
#1029 Spell separator correctly everywhere (not seperator).
2015-02-14 15:25:52 +00:00
0df8356a56
#1029 . Thank You, Thomas for reporting this and providing the patch.
2015-02-12 01:24:26 +00:00
d393b0fa7e
trunk: exiv2 v0.25
2014-12-25 13:55:57 +00:00
94e6dcbf50
Fix cygwin compilation warning on geotag.cpp
2014-10-07 21:33:02 +00:00
Kevin Backhouse