Commit Graph

4258 Commits

Author SHA1 Message Date
Rosen Penev
513b0e8bbd constexpr some constructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-22 06:11:10 -07:00
Rosen Penev
0aed79ff57 remove several constructors
Just direct initialize

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-22 06:11:10 -07:00
Rosen Penev
024e026bbb clang: small fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-22 06:11:10 -07:00
Rosen Penev
9ae339d39f clang: fix various documentation errors
Found with -Wdocumentation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-22 06:11:10 -07:00
Rosen Penev
22b12012a6 more SonarLint cleanups
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
d29001f2a4 clang-tidy: don't use non const refs
Found with: google-runtime-references

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
01aab49f6f don't assign an fs::path to a string
Seems to trip up MemorySanitizer on ARM32.

Also applied various simplifications to the code using std::filesystem

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
763cfaf2b4 MSVC warning fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
1f3d1f066f extern to static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
ca95edc6bd random fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
d6c1059485 gcc: ifdef
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
0a8fedf249 gcc: noexcept
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
1f21164085 gcc: remove redundant struct
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
9a1f37ecbe get rid of Key() move operations
Because of Impl, there's no way this can work properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
e854d93841 replace enable_if with if constexpr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
2fd523873b remove MSVC hacks
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
dc196e729e remove old MSVC workaround
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
4a26eba0d9 fix compilation under FreeBSD
sys headers must come before libprocstat

meson is missing a libprocstat dependency. iconv is also broken with
meson and freebsd.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-19 11:08:30 -07:00
Kevin Backhouse
5d11208aa0
Minor refactorings to stop UBSAN from complaining. 2023-03-18 17:26:00 +00:00
Rosen Penev
e2bf207477 add various moves
More efficient

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-13 23:01:14 -07:00
Rosen Penev
518c52c2af
Merge pull request #2544 from kevinbackhouse/fix-matroska-null-pointer-deref
Check that the pointer isn't NULL
2023-03-12 08:38:48 -07:00
Kevin Backhouse
e0ac920c87
Suggestion from @neheb 2023-03-12 10:54:01 +00:00
Kevin Backhouse
244799f480 Convert tail-recursion to loop to avoid stack exhaustion. 2023-03-11 22:47:47 -08:00
Kevin Backhouse
a783320520 Use enforce, not assert, to avoid crash. 2023-03-11 21:50:33 -08:00
Kevin Backhouse
65259d8936
Check that the pointer isn't NULL. 2023-03-11 23:29:48 +00:00
Rosen Penev
ff7bfb3798
Merge pull request #2422 from norbertwg/interpretation-for-Exif.Photo.LensSpecification
Interpretation for Exif.Photo.LensSpecification
2023-03-07 08:22:00 -08:00
norbertwg
10bbe3f4ae to avoid compiler warnings: 0.0 changed to 0.0f 2023-03-07 15:36:07 +01:00
norbertwg
db2f4ee377 interpretation for ExifPhoto.LensSpecification
printLensSpecification is copied from old Nikon3MakerNote::print0x0084
call of Nikon3MakerNote::print0x0084 replaced by printLensSpecification

add two lens tags to EasyAccess API
Exif.Photo.LensSpecification and Exif.Nikon3.Lens

handling of zero; more precision for focal length

silence compiler warnings
2023-03-06 11:01:18 +01:00
Kevin Backhouse
14e26b5abd
Fix integer overflow which enables enforce to be bypassed. 2023-03-04 22:06:14 +00:00
Kevin Backhouse
b5bf079444
Fix long-running loop 2023-03-04 16:37:49 +00:00
Rosen Penev
725875497b SonarLint cleanups 2023-03-03 19:35:42 -08:00
Mohamed Ali Chebbi
8b96ebc6b4 asfvideo fuzz issue : nb_headers should not exceed the max value of uint32 2023-03-03 17:04:17 -08:00
Rosen Penev
b9d94e61fe coverity: remove dead code
Found with: CID 1521533
Unsigned compared against 0 (NO_EFFECT)

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
03d34bee04 get rid of convertToUint64
same as getULongLong

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
afbd9e7a76 coverity: add move operations
CID 1521171: Missing move assignment operator

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
839c03fe37 use find()
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
3fe6d78014 Remove some constructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
2205a14a06 clang-tidy: default init various members
Found with cppcoreguidelines-pro-type-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
dd25d9999b direct init structs
No need to deal with individual members

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
48caa32017 close socket before return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
393150c0cd cast expression
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
f2c879333e fix off by 1 error
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Kevin Backhouse
230fbaf421 Use toInt64() for hours and minutes, because they should be integer valued. 2023-02-23 13:23:25 -08:00
Kevin Backhouse
c20ee1a7f5 Use double type to improve floating point accuracy. 2023-02-23 13:23:25 -08:00
Rosen Penev
9f21b78311 add contains function
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-14 00:48:41 -08:00
Rosen Penev
28358cd209 template second parameter for startsWith
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-14 00:48:41 -08:00
Rosen Penev
d7bf72634e use std::replace
shorter

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
0d50e444f2 use count_if
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
2d1691c1e2 replace array with vector
Using the constructor is one less line. Plus it seems to fix bugs in
Apple's clang.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
63b32ba3fb fix wrong snprintf format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00