third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
8,705 Commits 2 Branches 0 Tags 122 MiB
979ce8ab2a
Commit Graph

166 Commits

Author SHA1 Message Date
Peter
1f364be1fa
Fix seg fault when using iconv_open() (#2403) 
* Fix seg fault when using `iconv_open()`

- Fix failure condition for `iconv_open()`
- Add new exception when failing to change the text encoding of an
Exif comment

* Add testing for `iconv_open()` seg fault bug

* Fix Python test by changing log level
 2022-11-01 13:33:36 +00:00
Rosen Penev
88fcd234bb remove pointless x_default variable 
Just replace it with the string.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-08-17 02:25:10 -07:00
Rosen Penev
1602afef0a const conversions 
These were not const.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-08-05 01:01:25 -07:00
Rosen Penev
1d0530f04d misc sonarlint changes 
Mostly const changes.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-07-31 20:51:12 -07:00
Rosen Penev
5d2d47032b replace [0] with front() where applicable 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-07-27 11:29:57 -07:00
Kevin Backhouse
1958e70a71 Use int32_t in TimeValue 2022-07-26 23:13:42 -07:00
Rosen Penev
3ae1d3b48e return make_unique directly 
Simpler

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-07-24 23:00:02 -07:00
Rosen Penev
bae7da19ca clang-tidy: use default member init 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-07-03 12:24:41 -07:00
Rosen Penev
b4c90b5e16 clang-tidy: replace pointer magic with data() 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-05-21 17:14:58 -07:00
Rosen Penev
a8061e7ee9 clang-tidy: default member init 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-04-14 18:01:55 -07:00
Rosen Penev
fdfcde5e4b structured binding conversions 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-04-09 10:49:02 +02:00
Rosen Penev
b72e4b0e44 clang-tidy: use auto 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-04-01 16:37:51 -07:00
Rosen Penev
043547cbd0 remove various usages of memset 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-27 01:47:02 -07:00
Luis Díaz Más
d7f35e33f0 Remove useless static_casts 2022-03-25 08:43:37 +01:00
Luis Díaz Más
b05573fadc Remove most of the asserts from codebase 2022-03-23 16:55:18 +01:00
Luis Díaz Más
30bf563f4d Update .clang-format file & apply clang-format to whole project 2022-03-16 22:30:53 +01:00
Rosen Penev
b2b6d834ba
some std::array conversions (#2148) 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-15 10:17:06 +01:00
Luis Diaz
7576a2757b More size_t for sizes 2022-03-14 11:50:42 +01:00
Luis Diaz
62aad98d0b Change Metadatum::copy return value from long to size_t 2022-03-14 11:47:15 +01:00
Luis Díaz Más
96f7f2e4c5 Convert Exiv2::ErrorCode into an enum class 2022-03-12 16:58:40 +01:00
Luis Díaz Más
5d08bb9bec
Merge pull request #2146 from Exiv2/mainDatesWithZeros 
DateValue is now a bit more permissive with malformed dates
 2022-03-12 16:56:11 +01:00
Luis Díaz Más
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups 
Include what you use + more SPDX identifiers + few other cleanups
 2022-03-11 21:02:45 +01:00
Luis Diaz
56c52be8b5 DateValue is now a bit more permissive with malformed dates 2022-03-11 19:57:55 +01:00
Rosen Penev
8dadcdf72a manual nullptr removals 
unique_ptr has a bool overload. It's also easier to reason about.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-09 17:12:29 -08:00
Luis Díaz Más
b3a216310a Removing unused headers thanks to IWYU 2022-03-07 22:25:51 +01:00
Luis Díaz Más
2834fa5f05 Use [[maybe_unused]] 2022-03-07 22:25:51 +01:00
Rosen Penev
a25bbe133f constexpr string conversions 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-04 15:54:05 -08:00
Rosen Penev
04bacdedd6 clang-tidy: use auto 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-04 15:54:05 -08:00
Rosen Penev
118aa78aa0 clang-tidy: use braced init list 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2022-03-04 15:54:05 -08:00
Luis Díaz Más
b17828b454
Use SPDX for licenses (#2122) 
* Use SPDX identifier in header files

* Use SPDX identifier in rest of source files

* Fix usage of SPDX for files with 2 licenses

* Add global license file

* Fix compilation
 2022-03-04 11:44:39 +01:00
Luis Díaz Más
b9f9d041ea Several transformations on DataBuf + migration to size_t 
- Provide begin/end iterators to DataBuf and simplify code
- Adapt test output after last changes
- Replacing long by size_t in value.hpp
- Use size_t in some Photoshop functions
- Remove some static_casts
 2022-02-27 09:41:47 +01:00
Luis Díaz Más
59f4d0de27 cppcheck: reduce scope of variables 2022-02-18 18:01:02 +01:00
Luis Díaz Más
ea201ce613 Remove dead code 2022-02-18 18:01:02 +01:00
Kevin Backhouse
2a3dd2def9
Replace Value::toLong with Value::toInt64. (#2062) 
* Replace Value::toLong with Value::toInt64.

* Fix compiler warning.

* Fix compile error.

* Fix declaration of canonEv

* Fix compiler warning.

* Fix compiler warning.

* Use int64_t for offsets in tiffcomposite_int.cpp

* Fix compiler warning.

* Fix compiler warnings.

* Fix compiler warning.

* Fix compiler warning.

* Fix compiler warning.

* Fix compiler warning.

* Remove static_cast<long int> in TagDetails initializer.
 2022-02-12 21:16:18 +00:00
Luis Díaz Más
0f03e77634 Simplify code around UniquePtr(s) & use make_unique over new 2022-02-05 11:02:04 +01:00
Robin Mills
13a2cf336d
fix_1416_iptc_DateCreated (#1547) 
* fix_1416_iptc_DateCreated

* Fix unit tests

* DateValue:read 2nd iteration on pre-condition

* test with ISO_8601 date format

* Use std::regex for ISO 8601 basic & extended date formats

* Use std::regex for ISO 8601 basic & extended time formats

* Add more tests & notes for DateValue & TimeValue

* Comment tests using local calendar times

* DateValue::write also adds padding to year field

Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
 2021-12-14 11:20:02 +01:00
Kevin Backhouse
644aaaac92
Check that the string isn't empty 2021-08-01 23:31:56 +01:00
Kevin Backhouse
dc2c77ce81
Safer std::vector indexing. 2021-07-18 14:40:45 +01:00
Kevin Backhouse
d5ada325af
Check that type isn't an empty string. 2021-07-18 14:14:02 +01:00
Kevin Backhouse
a4c5bdac19 fix: stricter date parsing in value.cpp (#1720) 
* Regression test for issue 1713

* Stricter date parsing.

* Fix test failure caused by stdout mismatch.

(cherry picked from commit ab58026cff0e5edebc026261e9dc4b7db05b802d)
 2021-06-27 10:21:38 +02:00
mergify[bot]
1d64f482ff
fix: use vector::at() rather than operator[] (backport #1735) (#1741) 
* fix: use vector::at() rather than operator[] (#1735)

* Regression test for https://github.com/Exiv2/exiv2/issues/1706

* Use vector::at() rather than operator[].

* Print to stderr when exception is caught and EXIV2_DEBUG_MESSAGES is enabled.

* Check that it prints "Bad value" for the date.

(cherry picked from commit f4d3adbf91e6dc4e34aee5bac7b7fd9e127a5c00)

# Conflicts:
#	src/value.cpp

* fix merge conflicts from mergify backport

Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
Co-authored-by: Christoph Hasse <hassec@users.noreply.github.com>
 2021-06-27 09:33:56 +02:00
Kevin Backhouse
2b84f4bd64
fix: zero initialize local variables. (#1743) 
* Zero initialize local variables.

* Initialize xmpID_
 2021-06-27 08:56:31 +02:00
Kevin Backhouse
3e099da7b7 Remove obsolete snprintf macros. 2021-06-22 18:25:52 +02:00
Rosen Penev
2c57f214c5 clang-tidy: use nullptr 
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-26 08:31:45 +02:00
Rosen Penev
ff39473c18 clang-tidy: convert to static 
Found with readability-convert-member-functions-to-static

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:45:20 +02:00
Rosen Penev
b8712188bb clang-tidy: use auto 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 21:52:03 +02:00
Rosen Penev
20dfab8036 manual for range loop conversions 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 10:30:42 +02:00
Rosen Penev
c73dfa0106 clang-tidy: use uppercase numeric literals 
Found with readability-uppercase-literal-suffix

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-16 11:27:49 +02:00
Rosen Penev
2e73aa9dc0 default con/destructors in headers 
Helps to optimize trivially destructable stuff.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 09:10:36 +02:00
Rosen Penev
8337462032 clang-tidy: use empty() instead of comparing size 
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-11 22:02:47 +02:00