Kevin Backhouse
a5c521ea57
Merge pull request #2252 from neheb/2
...
clang-tidy: use default member init
2022-07-05 23:07:08 +01:00
Kevin Backhouse
b3f2ab5988
Fix some "signed shift" warnings.
2022-07-05 18:34:57 +01:00
Rosen Penev
bae7da19ca
clang-tidy: use default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-03 12:24:41 -07:00
Kevin Backhouse
ad4e13b827
Change return type of BasicIo::tell() to size_t.
2022-06-21 17:05:10 +01:00
Rosen Penev
a98954a98e
clang-tidy: add missing special member functions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-05-21 17:39:26 -07:00
Viktor Schneider
1ff09506e0
add missing header for std::unique_ptr in values.hpp
...
76f01fd4d3 removes the <memory> header
which is required to use std::unique_ptr for some builds
(e.g. archlinux using gcc 12.1.0).
2022-05-16 08:19:21 +02:00
Rosen Penev
19dc566889
use _v
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-05-02 09:27:55 +02:00
Luis Díaz Más
c9bdd6ed94
Merge pull request #2209 from Exiv2/mainTODOs
...
Improvements around TODO comments
2022-04-29 09:04:46 +02:00
Rosen Penev
a86bc386da
reference conversions
...
There's no nullptr here.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-18 13:53:14 -07:00
Rosen Penev
48f848f5bb
clang-tidy: remove const params in decls
...
Found with readability-avoid-const-params-in-decls
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-18 13:53:13 -07:00
Rosen Penev
a8061e7ee9
clang-tidy: default member init
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-14 18:01:55 -07:00
Luis Díaz Más
6964f5f9f2
DataBuf::c_data() returns nullptr when empty + avoid duplication
...
After the previous commit, I realized that std::vector::data() also
returns nullptr when the vector is empty. So I decided to emulate this
behavior in DataBuf::c_data().
Anyways, the changes done in the previous commit are valid and allow us
to avoid some processing when the DataBuf is empty.
2022-04-14 10:40:58 +02:00
Luis Díaz Más
25c47cd1cf
Merge pull request #2197 from Exiv2/mainRefactoringFormats
...
Refactoring in JpegImage and Photoshop classes
2022-04-10 13:23:33 +02:00
Luis Díaz Más
f942ba89bd
Move Photoshopb class to internal namespace
2022-04-10 10:55:10 +02:00
Luis Diaz
047f6b733e
Change logic to determine if segment has size
...
Note that the failing tests that had to be adapted were bad formed files
from FUZZERs. We should not consider invalid markers like 0x00 or 0x52
but only undefined APPn markers.
2022-04-10 10:53:36 +02:00
Luis Diaz
24d2a7b8f0
JpegBase::markerHasLength moved to implementation details
2022-04-10 10:53:35 +02:00
Luis Diaz
23fe743d4d
Move private constants to .cpp
2022-04-10 10:53:34 +02:00
Rosen Penev
b53ed72fd8
clang-tidy: manual special functions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-10 01:40:39 -07:00
Rosen Penev
a20ace20fc
clang-tidy: manual clang-tidy fixes
...
clang-tidy has issues applying these.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-10 01:40:39 -07:00
Rosen Penev
fdfcde5e4b
structured binding conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-09 10:49:02 +02:00
Luis Diaz
8ab7800477
Remove 2nd param from Photoshop::isIrb() since it is always hardcoded
2022-04-06 15:55:29 +02:00
Luis Diaz
a698c3fc08
Remove deprecated variable
2022-04-06 15:18:43 +02:00
Luis Diaz
459c73c0f6
doxygen: update doc style in Photoshop class
2022-04-06 15:18:42 +02:00
Rosen Penev
06d977d7bc
clang-tidy: use default
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-04-01 16:38:04 -07:00
Rosen Penev
fafe999c6e
remove unused var from deleted stuff
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-31 08:47:37 +02:00
Rosen Penev
c0868aff31
std::function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 21:04:23 -07:00
Rosen Penev
c4eedd6ae4
nodiscard addition
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 20:58:11 -07:00
Rosen Penev
389501462a
delete
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 20:54:12 -07:00
Rosen Penev
1fbe4b7bbd
use = delete and move to public
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 18:45:30 -07:00
Rosen Penev
c17e2a1a5a
add missing destructor
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 18:41:19 -07:00
Rosen Penev
7a4541cf50
use empty()
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 18:36:22 -07:00
Rosen Penev
02fe0181df
const variable
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 18:22:12 -07:00
Rosen Penev
b75239c52d
const member function
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-29 18:19:38 -07:00
Christoph Hasse
08cef207ab
add .git-blame-ignore-revs file and add clang-format commit to it ( #2170 )
...
* add .git-blame-ignore-revs file and add clang-format commit to it
* formatting fix follow up from #2158
* update .git-blame-ignore-revs
2022-03-28 09:55:11 +02:00
Rosen Penev
bad4712df8
static constexpr conversions
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-26 14:33:09 -07:00
Luis Díaz Más
d7f35e33f0
Remove useless static_casts
2022-03-25 08:43:37 +01:00
Luis Díaz Más
ae4df71233
Remove DataBuf::copyBytes and use std::copy instead
2022-03-23 17:17:29 +01:00
Luis Díaz Más
734b909721
Help for formatting enums & arrays with clang-format
2022-03-23 16:55:18 +01:00
Kevin Backhouse
15328aaa9f
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=45291
...
Use std::round() to handle fractions correctly.
2022-03-19 18:12:10 +00:00
Luis Díaz Más
30bf563f4d
Update .clang-format file & apply clang-format to whole project
2022-03-16 22:30:53 +01:00
Rosen Penev
b2b6d834ba
some std::array conversions ( #2148 )
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-15 10:17:06 +01:00
Luis Diaz
4355d635d4
More conversions to size_t while removing static_casts
2022-03-14 11:55:10 +01:00
Luis Diaz
7576a2757b
More size_t for sizes
2022-03-14 11:50:42 +01:00
Luis Diaz
137ea080b5
Change Metadatum::size() return value from long to size_t
2022-03-14 11:47:15 +01:00
Luis Diaz
62aad98d0b
Change Metadatum::copy return value from long to size_t
2022-03-14 11:47:15 +01:00
Luis Díaz Más
7119b7676f
remove templating & simplify error message
...
+ clang-format in Error files
+ Remove AnyError
2022-03-12 16:58:41 +01:00
Luis Díaz Más
96f7f2e4c5
Convert Exiv2::ErrorCode into an enum class
2022-03-12 16:58:40 +01:00
Luis Díaz Más
c115d4daf7
Merge pull request #2131 from Exiv2/mainCleanups
...
Include what you use + more SPDX identifiers + few other cleanups
2022-03-11 21:02:45 +01:00
Luis Díaz Más
85d6082d7f
Should fix build in some Linux distros
2022-03-08 11:21:24 +01:00
Rosen Penev
c2bcd4b08e
replace EXV_COUNTOF with std::size
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-03-08 00:26:33 -08:00