Commit Graph

3627 Commits

Author SHA1 Message Date
Luis Díaz Más
b0318c36be
Upgrade C++ standard to c++17 (#2052)
* Enable C++17 and use new inline specifier for const variable members

* Silence deprecation warning on MSVC

* Disable samples by default

* improvements after review
2022-01-09 20:09:34 +01:00
Peter
629442df9d
Merge pull request #1929 from postscript-dev/fix_exiv2_-pR
Fix `exiv2 -pR` for Sony images (#1805)
2022-01-09 15:25:24 +00:00
Luis Díaz Más
825c0c72bc Check array index before inspecting it 2022-01-07 09:38:42 +01:00
Luis Díaz Más
240a72468e Clang-format in pngchunk_int.cpp 2022-01-07 09:38:42 +01:00
Luis Díaz Más
ec21f65dca Replace magicValue with constant variable 2022-01-07 09:38:42 +01:00
Luis Díaz Más
ceae86899d Initialize uninitialized variables 2022-01-07 09:38:42 +01:00
Luis Díaz Más
b96f5af037 Remove dead code 2022-01-07 09:38:42 +01:00
Luis Díaz Más
061df50cea keyTXTChunk improvement 2022-01-07 09:38:42 +01:00
Luis Diaz
c19425f6a4 Add unit tests for PngChunk::keyTXTChunk 2022-01-07 09:38:42 +01:00
Luis Diaz
c898f56ab2 cmake: Add missing source file 2022-01-07 09:38:42 +01:00
Luis Díaz Más
813566526c
Revisiting cmake code for generating coverage reports (#2047)
* cmake: better usage of gcovr for coverage reports

* Add test for FileIo::setPath

* Remove useless seek() overload

* Add missing override specifiers

* ignore .vs folder

* Small refactors in BasicIo implementations

* Remove duplicated doxygen doc

* Refactor & add tests for MemIO

* Fix compilation warnings on windows
2022-01-06 12:52:01 +01:00
Kevin Backhouse
a094dde1de
Merge pull request #2040 from kevinbackhouse/TiffEntryBaseStorage
Use std::shared_ptr for storage in TiffEntryBase
2022-01-02 15:39:42 +00:00
Facundo
b52b6db39f
Output of -PV was not suitable for inputting to -m-, key was missing. (#1970)
* Output of -PV was not suitable for inputting to -m-, key was missing.

Fix #1969

* Make V flag to -P also print the type

This makes -PV work also for non-built-in tags (of which their type is
not known by exiv2).

* Adjust man to accomodate for the V flag change
2021-12-29 17:19:23 +01:00
Kevin Backhouse
9268279b47
Add comments. 2021-12-24 15:04:14 +00:00
Kevin Backhouse
b6a4fd1c67
Add storage parameter to setData. 2021-12-24 12:54:35 +00:00
Kevin Backhouse
29f7d0ccf0
Remove DataBuf::release() which is no longer used. 2021-12-24 12:35:46 +00:00
Kevin Backhouse
9f3240c91c
Delete TiffEntryBase::isMalloced_ field and use a std::shared_ptr instead. 2021-12-24 12:32:48 +00:00
Kevin Backhouse
29cc981180
Merge pull request #2028 from kevinbackhouse/FixIssue2027
Use memmove in TiffEncoder::updateDirEntry
2021-12-14 11:44:53 +00:00
Robin Mills
13a2cf336d
fix_1416_iptc_DateCreated (#1547)
* fix_1416_iptc_DateCreated

* Fix unit tests

* DateValue:read 2nd iteration on pre-condition

* test with ISO_8601 date format

* Use std::regex for ISO 8601 basic & extended date formats

* Use std::regex for ISO 8601 basic & extended time formats

* Add more tests & notes for DateValue & TimeValue

* Comment tests using local calendar times

* DateValue::write also adds padding to year field

Co-authored-by: Luis Díaz Más <piponazo@gmail.com>
2021-12-14 11:20:02 +01:00
Kevin Backhouse
e34eacc467
Use memmove, rather than memcpy, because memory regions might overlap. 2021-12-13 12:22:54 +00:00
Miloš Komarčević
fd8447129c
Add more DNG 1.6 tags (#2023)
* Add more DNG 1.6 tags

* Update CinemaDNG, add more spec links
2021-12-11 09:29:53 +01:00
Kevin Backhouse
65fad9db0e
Merge pull request #2007 from kevinbackhouse/FixIssue2006
Fix integer overflow in PanasonicMakerNote::printAccelerometer
2021-12-06 10:31:20 +00:00
Kevin Backhouse
aebb3fb2c0
Merge pull request #2015 from kevinbackhouse/SonyPreviewUndefined
Treat Exif.Sony1.PreviewImage as undefined tag
2021-12-05 19:16:30 +00:00
Kevin Backhouse
0a1fa497d5
Merge pull request #1999 from jim-easterbrook/bug_1998
Restore modified tags after TZ manipulation
2021-12-05 15:02:46 +00:00
Kevin Backhouse
a1ad29edf3
Treat Exif.Sony1.PreviewImage as undefined tag. 2021-12-05 14:41:57 +00:00
Kevin Backhouse
35f48ae5c9
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=41438
Replace weird sign-conversion code with a simple static_cast.
2021-11-28 14:41:22 +00:00
Kevin Backhouse
6758e7288d
Merge branch 'main' into fix_exiv2_-pR 2021-11-24 12:58:53 +00:00
Peter
797f86c226
Fix minor whitespace formatting
Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
2021-11-17 11:14:35 +00:00
postscript-dev
9c294ef4fd
Fix exiv2: verbose extract to stdout (see #1934)
Fix ignores `--verbose` when extracting to stdout.
2021-11-16 19:15:44 +00:00
Jim Easterbrook
02ce7e9aff Restore modified tags after TZ manipulation
This ensures that Xmp date/times that have been set by the user aren't
over written by the TZ restoration efforts. This fixes bug #1998
2021-11-15 10:18:05 +00:00
Kevin Backhouse
fde8ed07b3
Merge pull request #1967 from kevinbackhouse/ReadOrThrow
Add readOrThrow and seekOrThrow to BasicIo
2021-11-08 22:33:23 +00:00
Peter
1ae9f42cd8
Add camera models for NikonFl3 makernotes group (#1994)
* Add camera models for NikonFl3

* Python test for new NikonFl3 camera models
2021-11-08 17:45:14 +01:00
postscript-dev
562b10f2c7
Fix Exif.NikonFl7.FlashCompensation 2021-11-03 17:39:05 +00:00
postscript-dev
bd676bedc6
Fix exiv2 -pR for Sony images (#1805)
`exiv2 -pR` failed to process Sony makernotes. Fix checks if
makernotes header has Sony string, then uses correct offset.

Fix supplied by @clanmills
2021-11-02 16:08:39 +00:00
postscript-dev
277b1875f7
Fix Exif.NikonFl7.FlashGroupBCControlData output 2021-11-02 16:02:24 +00:00
postscript-dev
b3ca98c1e7
Fix Exif.NikonFl7.FlashCompensation pretty print 2021-11-02 16:02:23 +00:00
postscript-dev
8ebf10f921
Fix condition in Exif.NikonFl7.FlashCompensation 2021-11-02 16:02:23 +00:00
postscript-dev
f23d965643
Add limits check: Exif.NikonFl7.FlashCompensation 2021-11-02 16:02:23 +00:00
postscript-dev
f0f3c7e8a2
Fix compile issues for NikonFl7 makernotes group
+ Fix fuzzing CI errors of `exp2` and `round` not being in `std` by adding
  `#include <cmath>`
+ Fix Windows CI warning C4305 by explicitly defining value as a float
2021-11-02 16:02:22 +00:00
postscript-dev
eb134d1946
Add testing for NikonFl7 makernotes group 2021-11-02 16:02:21 +00:00
Kevin Backhouse
ab90d430c7
Merge pull request #1979 from postscript-dev/fix_exiv2_sample_thumb_stdout
Add exiv2 extract thumb to stdout (#1934)
2021-10-26 11:56:33 +01:00
Kevin Backhouse
68473d9d10
Remove static functions readOrThrow and seekOrThrow. 2021-10-21 10:18:21 +01:00
Kevin Backhouse
44542a9f94
Add readOrThrow and seekOrThrow to BasicIo. 2021-10-21 10:18:21 +01:00
Miloš Komarčević
8b7d8729b7 Expose unsupported CR3 previews as binary 2021-10-20 22:15:44 +02:00
postscript-dev
31a2467a61
Add exiv2 extract thumb to stdout (#1934): src 2021-10-20 15:33:25 +01:00
Miloš Komarčević
40e5021577 Limit CR3 previews to JPEG only 2021-10-20 16:17:24 +02:00
Kevin Backhouse
0ae85cc4ca
Merge pull request #1974 from dhoulder/skip-isobmff-boxes
Performance boost: don't read boxes we're not interested in
2021-10-20 11:35:46 +01:00
mergify[bot]
2d80891837
Only include expat.h when XMP is enabled. (#1973)
(cherry picked from commit 03cc59122249e79c5a72982b25dad88f4c2803d6)

Co-authored-by: Kevin Backhouse <kevinbackhouse@github.com>
2021-10-20 10:21:52 +02:00
David Houlder
4e587fa931 Performance boost: don't read boxes we're not interested in 2021-10-19 22:44:55 +11:00
David Houlder
b385f2db1c
Canon cr3 previews (#1958)
* Extract THMB and PRVW images from Canon CR3 file

* Added test for Canon CR3 preview extraction.

Added test data Canon-R6-pruned.CR3 (first 492016 bytes of https://raw.pixls.us/getfile.php/4659/nice/Canon%20-%20Canon%20EOS%20R6%20-%203:2.CR3).

See https://github.com/Exiv2/exiv2/issues/1893

* Fixed format specifier

* Update src/bmffimage.cpp

Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>

* Update src/bmffimage.cpp

Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>

* retrigger checks

Co-authored-by: Miloš Komarčević <4973094+kmilos@users.noreply.github.com>
2021-10-17 22:28:05 +01:00