Commit Graph

40 Commits

Author SHA1 Message Date
Kevin Backhouse
2b84f4bd64
fix: zero initialize local variables. (#1743)
* Zero initialize local variables.

* Initialize xmpID_
2021-06-27 08:56:31 +02:00
Kevin Backhouse
3e099da7b7 Remove obsolete snprintf macros. 2021-06-22 18:25:52 +02:00
Rosen Penev
2c57f214c5 clang-tidy: use nullptr
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-26 08:31:45 +02:00
Rosen Penev
86c71ae6c3 clang-tidy: avoid global non const variables
Found with cppcoreguidelines-avoid-non-const-global-variables

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-25 08:43:27 +02:00
Rosen Penev
743da1a564 clang-tidy: use C++ casting
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-20 07:29:02 +02:00
Rosen Penev
bd6a996181 clang-tidy: use using
Found with modernize-use-using

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-09 17:42:51 +02:00
Rosen Penev
4ceb325c8f clang-tidy: range for loop conversions
Found with modernize-loop-convert

Ran through git clang-format.

Also removed several questionable loops and replaced with simpler
algorithms.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2021-05-03 14:50:04 +02:00
Luis Díaz Más
01a3bc716d Fix warnings in VS 2021-04-19 10:43:46 +02:00
Luis Díaz Más
de4d43d4d1 Fix warnings EXIV2_TEAM_EXTRA_WARNINGS
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
2021-04-18 18:49:58 +02:00
Robin Mills
d632988bbd Massive code prolog cleanup. 2021-03-17 13:34:21 +00:00
Robin Mills
5240630849 fix_1353_mingw_toolchain_0.27 2020-10-13 15:55:07 +01:00
Luis Díaz Más
778479556f Include winsock2 at the beginning of http.cpp 2020-10-06 22:56:07 +02:00
Luis Díaz Más
b304244766 Move winsock2 inclusion to http.cpp 2020-10-06 22:01:01 +02:00
Robin Mills
604a268059 Second effort to unexpose winsock2.h from include <exiv2/exiv2.hpp> using EXIV2_BUILDING_EXIV2 mechanism. 2020-10-02 08:44:57 +01:00
clanmills
7ff0e0613a fix_1335_winsock2_0.27 2020-10-01 17:23:12 +01:00
Robin Mills
7bf40a2408 fix_1211_c++11_0.27. I'll explain this in the PR. 2020-05-28 14:16:08 +01:00
clanmills
0215608071 http.cpp doesn't compile with C++/98 on Cygwin and MinGW/msys2. 2020-05-20 06:50:29 +01:00
clanmills
ea28be68e9 Fixing fedora/mingw build breaker. https://gitlab.com/D4N/exiv2/-/jobs/555626122 Thanks to @D4N for this discovery. 2020-05-17 17:49:21 +01:00
clanmills
5f6738a098 get http.cpp to call WSAStartup() on Cygwin and MinGW 2020-05-15 15:55:20 +01:00
Kevin Backhouse
ae20c30805 Avoid null pointer exception due to NULL return value from strchr.
This fixes #793.
2019-05-04 15:45:10 +02:00
Natanael Copa
63f1fde85b Fix path for errno.h
Fix warnings when built with musl libc by using the correct path for
errno.h as defined in POSIX.

Fixes the following warning:
In file included from /home/ncopa/src/exiv2/src/http.cpp:74:
/usr/include/sys/errno.h:1:2: warning: #warning redirecting incorrect #include <sys/errno.h> to <errno.h> [-Wcpp]
 #warning redirecting incorrect #include <sys/errno.h> to <errno.h>
  ^~~~~~~
2018-12-25 16:09:00 +01:00
Luis Díaz Más
8bf9ca8e6d MSVC: Delete deprecated stuff related to MSVC < 2008 2018-11-11 12:27:26 +01:00
Luis Díaz Más
b9f913d5af Move implementation to .cpp files. Fix more issues related to visibility settings 2018-09-14 13:20:08 +02:00
Luis Díaz Más
603692a1d8 Copyright to Exiv2 authors 2018-09-12 19:22:31 +02:00
Luis Díaz Más
4161099b91 Fix warnings reported by MSVC 2018-09-10 10:31:00 +02:00
tbeu
12d0da619b Use clear to reset string
V815 Decreased performance. Consider replacing the expression 'token = ""' with 'token.clear()'. http.cpp 193
2018-06-02 09:43:20 +02:00
Dan Čermák
1d7dd0892c Fix errors not being passed by reference to error() function
- error was passed by value, but a new error message should be appended to it
  => error must be called by reference
- use default parameters of error() in http()
- rename variables to fix shadowing
2018-05-16 10:15:53 +02:00
Luis Díaz Más
d55b2b1b65 Remove HAVE_STDLIB_H check and replace stdlib.h by cstdlib 2018-05-04 11:20:43 +02:00
Robin Mills
559ace375b #1291 Reverting change in r4763 relating to windows.h as they break the Cygwin build. Retain changes in exiv2/exiv2.hpp and exv_msvc.h 2017-04-23 19:29:19 +00:00
Robin Mills
f36cccefa2 #1291 include header simplification 2017-04-23 17:31:57 +00:00
Robin Mills
73572aa54d #1291 Fix submitted. Thank You to T Modes for reporting this issue. 2017-04-23 11:57:05 +00:00
Robin Mills
6d5c2c3256 Getting ready to release v0.26 2017-03-08 20:42:28 +00:00
Robin Mills
f44f706478 MinGW changes following discussion about building with Qt5.6/MinGW 4.9.2 http://dev.exiv2.org/boards/3/topics/2705 2016-09-07 17:08:27 +00:00
Robin Mills
339bf9c0fd fixing mingw buildbreakers 2016-06-23 23:23:17 +00:00
Robin Mills
8ff86b6875 #1110. Xcode project moved to contrib/xcode. Interesting errors in samples/Makefile. Replaced gsoc13 Exiv2::dict_t with (identical twin) Exiv2::Dictionary 2015-09-23 20:43:16 +00:00
Andreas Huggel
533668808d Fixed cross-compiler warnings. 2015-06-21 14:21:21 +00:00
Andreas Huggel
fd80993ab0 Updated copyright notice. 2015-05-02 11:55:40 +00:00
Robin Mills
24cb148e11 #1004. Reviewed all include directives in src/*.cpp and samples/*.cpp
fixed svn_version.sh again!
change to test/build-test.py for MacOS-X/Xcode 6.
2015-01-06 12:40:31 +00:00
Robin Mills
d54b8cbdeb #1012. Thank You, Thomas for the patch. 2015-01-03 10:18:36 +00:00
Robin Mills
d393b0fa7e trunk: exiv2 v0.25 2014-12-25 13:55:57 +00:00