Commit Graph

8987 Commits

Author SHA1 Message Date
Rosen Penev
b3ff42f2d5 use if constexpr
Suggested by MSVC.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
629f94eea3 unreachable code
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
d2ddf228ad replace switch with if/return
Fixes warning C4702: unreachable code

No other way to make all compilers gappy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
dde8765a49 don't assign in while
Fixes MSVC's warning C4706: assignment within conditional expression

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
b324f80443 use numeric limits instead of -1
Fixes MSVC warning.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
a10c08ba1d swap variables
These are the wrong way around. MSVC warns with /W4.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Mohamed Ali Chebbi
b8b4a041a1 compilation issue on Windows 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
51ef600fe6 compilation issue on Mac OS 2 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
c7aec66195 compilation issue on Mac OS 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
bed8d3d93c rework of aspectRatio calculation for all video formats and rework the decoding of asf tags 2023-02-10 21:55:24 -08:00
Rosen Penev
4bdee6f4a4
Merge pull request #2504 from neheb/r
fixes
2023-02-10 10:07:32 -08:00
Rosen Penev
dee0598edf
clang-tidy fixes for recent stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:27 -08:00
Rosen Penev
f21b2a2170
std to Exiv2 find
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:18 -08:00
Rosen Penev
b665574634
simplify loop
Just use upper

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:18 -08:00
Rosen Penev
33e5ef5ffd
remove constructors
Just direct initialize

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:30:53 -08:00
Rosen Penev
aa16a54a7f
Merge pull request #2458 from mohamedchebbii/TestVideoData
Rework Asf, Riff video, test data and fix OSS-Fuzz issues
2023-02-09 12:56:06 -08:00
Mohamed Ali Chebbi
6690e2e8f3
Merge branch 'Exiv2:main' into TestVideoData 2023-02-09 21:27:49 +01:00
Rosen Penev
84c3c4758a meson CI: test static library as well
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-08 23:10:55 -08:00
Miloš Komarčević
13e6671de2
Update some Canon IDs (#2501) 2023-02-08 16:49:53 +01:00
Rosen Penev
be387a60c3 add missing &
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-08 07:42:31 -08:00
Rosen Penev
7e40da70c8 remove unused defines
Forgot to remove these

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-07 08:47:56 -08:00
Rosen Penev
0f30198d9b remove mmap/munmap checks
Just check the header

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-07 08:47:56 -08:00
Rosen Penev
2ddf00e7a2 use EXV_ICONV_CONST
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-07 08:47:56 -08:00
Mohamed Ali Chebbi
32576a3edf add test/data for video support : rework readStringWcharTag method 2 2023-02-07 12:12:15 +01:00
Mohamed Ali Chebbi
579cae8e77 add test/data for video support : rework readStringWcharTag method 2023-02-07 11:52:24 +01:00
Rosen Penev
6f72bf7973 meson: g++-[789] build
Test them as they are still supported.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-06 23:17:27 -08:00
Rosen Penev
8d3e0d6e73 add basic meson CI 2023-02-06 13:44:57 -08:00
Rosen Penev
063a99b3c3 add meson build
This is a fairly basic meson file that builds only the library. Useful
for stuff like WrapDB.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-06 13:44:57 -08:00
Mohamed Ali Chebbi
e388ba523f add test/data for video support : rename Xmp.video.Duration to Xmp.video.duration 2023-02-06 10:39:35 +01:00
Mohamed Ali Chebbi
3847a09359
Merge branch 'main' into TestVideoData 2023-02-06 09:23:43 +01:00
Mohamed Ali Chebbi
f22db635b0 Merge branch 'TestVideoData' of github.com:mohamedchebbii/exiv2 into TestVideoData 2023-02-06 09:10:24 +01:00
Mohamed Ali Chebbi
db14131262 add test/data for video support : enhance Debug messages 2023-02-06 09:08:42 +01:00
Rosen Penev
e309680a86 remove deleted members from static classes
This is a holdover from C++98. No need anymore

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
6a34d9e57d add missing member functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ddb42eb159 remove some overriden defaulted destructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
d248e1a2af more delete removals
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ef82f953c0 do the same for Io functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
3290fe6146 remove deleted Image member functions
The inherited Image class already has these same deleted functions.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
e7977554e2 default initializations
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:09 -08:00
Rosen Penev
7aaf6414f2 move initialization up
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:09 -08:00
Mohamed Ali Chebbi
2b2173aafe
Merge branch 'Exiv2:main' into TestVideoData 2023-02-05 00:50:17 +01:00
Mohamed Ali Chebbi
ada14ae292 add test/data for video support : use readStraingTag instead of read 2023-02-05 00:26:21 +01:00
Mohamed Ali Chebbi
bf6546ee82 add test/data for video support : restore Riff HeaderReader and reserve addtional byte in readStraingTag 2023-02-05 00:11:03 +01:00
Mohamed Ali Chebbi
acd71894b2 add test/data for video support : delete unused parameter from readList method 2023-02-05 00:01:36 +01:00
Mohamed Ali Chebbi
0f715288e7 add test/data for video support : delete riff HeaderReader 2023-02-04 23:46:18 +01:00
Mohamed Ali Chebbi
19f8b437c3 add test/data for video support : add enforce exceptions 2023-02-04 23:02:45 +01:00
Mohamed Ali Chebbi
340b46623d add test/data for video support : Fix codeQL warnings 2023-02-04 22:37:41 +01:00
Rosen Penev
0d353ac5f3 work around windows.h min/max macros
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-03 23:27:11 -08:00
Rosen Penev
b8d4b9c6ea remove manual math
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-03 07:21:13 -08:00
Mohamed Ali Chebbi
d288617759 add test/data for video support : Fix test issue 2023-02-03 12:37:18 +01:00