Commit Graph

7692 Commits

Author SHA1 Message Date
Dan Čermák
305d22136c Added reproducer for issue 1305 on exiv2 redmine
http://dev.exiv2.org/issues/1305
2017-12-07 09:09:10 +01:00
Luis Díaz Más
f36bea3801 exiv2::getEnv throws std::out_of_range on unexpected EnVar
This change define explicitly the behavior that exiv2::getEnv should have
on response to unexpected inputs.

There are some other minor changes:

- Use _putenv_s for the unit tests on Windows
- Add todo comment
- Remove deprecated note about freeing memory
2017-12-06 17:29:05 +01:00
Luis Díaz Más
8dc3c1f0a0 Replace malloc/free by new/delete. Use const char* for input arg 2017-12-06 17:29:05 +01:00
Luis Díaz Más
bfe057ca20 Auto-formatting done by the IDE while touching code in the previous commits 2017-12-06 17:29:05 +01:00
Luis Díaz Más
8b049922d7 Change exiv2::urlencode signature to return std::string
The goal of this change is to remove the responsibility from the client code to
free the memory of the returned string.
2017-12-06 17:29:05 +01:00
Luis Díaz Más
fd5f131f4e Add characterisation test for exiv2::urlencode 2017-12-06 17:29:05 +01:00
Luis Díaz Más
171c7970f9 Add characterization tests for exiv2::getEnv 2017-12-06 17:29:05 +01:00
Luis Diaz Mas
1657c7e53d Ignore build* folders and project file generated by QtCreator 2017-12-06 17:29:05 +01:00
Luis Diaz Mas
ec09c98adb add few characterisation tests for exiv2::strError 2017-12-06 17:29:05 +01:00
Luis Díaz Más
3984a197b3 Use specific conan version 2017-12-05 07:02:15 +01:00
Luis Díaz Más
76668a03b1 Disable Mac builds on travis 2017-12-05 07:02:15 +01:00
Luis Díaz Más
19136d508a Changes proposed by tbeu (To be squased before merging) 2017-12-03 17:00:04 +01:00
Luis Díaz Más
977c5f7a63 Add CONTRIBUTING.md file with main guidelines for contributions 2017-12-03 17:00:04 +01:00
Luis Díaz Más
cc7ff4122d Export all symbols when running unit tests. Add dummy test for private code.
I tried to use directly the private OBJECT library (exiv2lib_int) in the unit_tests targets, but the private objects have dependencies on the public symbols (circular dependency)
and therefore it is impossible to test the private code with that approach with the current design of the library.

Starting from CMake 3.3 we can use the variable CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS to export all the symbols of a shared library:
https://blog.kitware.com/create-dlls-on-windows-without-declspec-using-new-cmake-export-all-feature/

Even having the opportunity to use this variable (that will be only used when EXIV2_BUILD_UNIT_TESTS is enabled) the previous commits are still valid.
It is interesting to clearly differentiate between the public and private code of the library. Enforcing this, make us think twice before putting code in the public
part of the library.
2017-11-28 17:36:08 +01:00
Luis Díaz Más
8c010c903b Compile private part as an OBJECT library (CMake concept) 2017-11-28 17:36:08 +01:00
Luis Díaz Más
d3748152a7 add _int suffix to all the internal files 2017-11-28 17:36:08 +01:00
Luis Díaz Más
44fc9ec528 Move Cr2Header to a new .cpp file 2017-11-28 17:36:08 +01:00
Jakub Wilk
11a910561e Fix typos in Polish translation 2017-11-27 22:13:21 +01:00
D4N
558acfe982
Merge pull request #179 from D4N/testSuiteFixAgain
[WIP] Make the testsuite really fail when tests don't pass
2017-11-26 18:29:32 +01:00
Dan Čermák
307138c12c reportTest function returns 3 on failure
the Makefile only aborts if the return value is > 2
2017-11-26 12:14:47 +01:00
Luis Díaz Más
f0ee2b638c
Merge pull request #173 from piponazo/fixGtestWarningsOnWindows
Provide a gtestWrapper header to skip useless warnings
2017-11-25 09:28:03 +01:00
Luis Díaz Más
cfe614d8c3 Provide a gtestWrapper header to skip useless warnings 2017-11-25 08:33:15 +01:00
Luis Díaz Más
4c4f91e407
Merge pull request #152 from piponazo/clangFormat
Add clang-format file
2017-11-20 21:32:11 +01:00
Luis Diaz Mas
d48abab718 Apply clang-format to some lines of the file canonmn.cpp 2017-11-19 18:52:33 +01:00
Luis Diaz Mas
d0a1c6d19d Apply clang-format to bmpimage.cpp 2017-11-19 18:52:23 +01:00
Luis Diaz Mas
6d9e0b5b3e Add .clang-format file 2017-11-19 18:52:19 +01:00
Luis Díaz Más
5d13356055
Merge pull request #157 from tbeu/legacy-svn
Remove obsolete SVN revision and EXIV2_RCSID
2017-11-19 18:06:12 +01:00
tbeu
2efc2e79da Remove obsolete id 2017-11-19 11:17:12 +01:00
tbeu
5b5987a596 Remove obsolete EXIV2_RCSID 2017-11-19 11:17:12 +01:00
tbeu
5df8b01b77 Remove obsolete svn revision 2017-11-19 11:17:11 +01:00
D4N
f45fb51f51
Merge pull request #167 from D4N/testsuite-hotfix
Testsuite fails with non-zero exit code if a test does not pass
2017-11-19 11:08:47 +01:00
Dan Čermák
eb33dcd9de Add md5sha1sum package for md5sum for the mac build on travis 2017-11-19 08:40:55 +01:00
Dan Čermák
78c559475b Testsuite fails with non-zero exit code if a test does not pass 2017-11-19 08:40:55 +01:00
D4N
81518c9e43
Merge pull request #143 from D4N/jp2Image_Robins_changes
Jp2image Bugfixes
2017-11-19 08:38:46 +01:00
Robin Mills
e96e0daa8a Jp2Image::printStructure: Corrected used DataBuf for output 2017-11-19 08:29:06 +01:00
Robin Mills
befe8c64e3 Jp2Image::printStructure: only print output when bPrint is set 2017-11-19 08:29:06 +01:00
Robin Mills
13db7fdec2 Formatting changes 2017-11-19 08:29:06 +01:00
D4N
df504d2e82
Merge pull request #142 from D4N/reproducers_138_139_140
Added reproducers #138, #139 and #140
2017-11-19 08:28:17 +01:00
Dan Čermák
c2d1614e7c Updated bugfixes-test.out 2017-11-19 00:29:08 +01:00
Dan Čermák
2b3e3f878b Added reproducers for #138, #139 & #140
the issues correspond to CVE-2017-14858, CVE-2017-14861 and
CVE-2017-14866 respectively
2017-11-19 00:23:57 +01:00
D4N
13771c8757
Merge pull request #148 from Exiv2/documentation-changes
Documentation update for Michal.
2017-11-18 10:50:18 +01:00
clanmills
12e7d2a53f Documentation update for Michal. 2017-11-18 09:39:29 +01:00
Luis Díaz Más
a79b75a67b
Merge pull request #154 from D4N/stringFormat_update
stringFormat update / ammendment to #137
2017-11-12 10:35:57 +01:00
Luis Díaz Más
87a83c89d5
Merge branch 'master' into stringFormat_update 2017-11-12 10:21:33 +01:00
Luis Díaz Más
0816755854
Merge pull request #164 from piponazo/fixMsvcWarning
Fix conversion issue detected by MSVC
2017-11-12 10:20:50 +01:00
Luis Díaz Más
1fe8d5ba7f Fix conversion issue detected by MSVC 2017-11-12 09:54:17 +01:00
Luis Díaz Más
2ed661068c
Merge pull request #163 from piponazo/MsvcParallel
New MSVC flag to enable Object Level Parallelism in CMake code
2017-11-12 09:53:26 +01:00
Luis Díaz Más
d0c9b8920c New MSVC flag to enable Object Level Parallelism in CMake code 2017-11-12 09:25:27 +01:00
D4N
baeb664e28
Merge pull request #160 from D4N/fix_159
Fixed potential out of bounds file access in printIDFStructure
2017-11-10 22:48:20 +01:00
Dan Čermák
7bae890ebf Updated bugfixes-test.out 2017-11-10 15:18:47 +01:00