Commit Graph

12 Commits

Author SHA1 Message Date
Kevin Backhouse
e6ce13729b
Add workaround for conan outage: https://github.com/conan-io/conan/issues/9695 2021-10-01 10:32:00 +01:00
Kevin Backhouse
7a6acc4eca
Standardize on conan 1.39.0 2021-09-09 17:15:10 +01:00
Luis Díaz Más
f30022d73d
Fix issues detected with PVS-Studio + other little improvements (#1689)
* avoid re-declaration of constant variables

* Replace pthreads critical section with std::mutex

* ci - better naming

* cmake - increase minimum version to 3.11. Use project DESCRIPTION

* fix - do not treat string::find() return type as bool

* remove conditions that were always true

* remove condition that were always false

* Remove EXV_HAVE_GMTIME_R which is not used anymore

* pixelWidth_ was inherited from Exiv2::Image

The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...

* Remove superfluous if

* pvs:V766 item with identical key added already

* pvs:V730 not all members were initialized (time)

* pvs:V730 not all members are initialized

* pvs:v668 no point in testing pointer against null after new

* pvs:V1048 variable assigned the same value

* replace c-style dynamic vector with std one

* pvs:547 fakeData is always true

* Remove useless constructor in derived class

* pvs:V690 modern way to disable copy-ctor

* Replace malloc/free with new/delete. No need to check for null

* pvs:V1028 cast operands and not result

* Remove custom MIN/MAX functions

* pvs:V595 pointer used before verified against null

* pvs: index used before being checked

* pvs:V1028 possible overflow. Cast operands

* pvs:v575 potential null pointer passed to other functions

* pvs:V547 deal with always true/false expressions

* pvs:V560 part of conditional expressions always false or true

* pvs:V701 possible break in realloc -> move to std::vector

* Make some classes 'final'

* Replace sprintf with std::to_string()

* fix compilation on windows
2021-06-01 12:39:10 +02:00
Luis Díaz Más
59a80eba2e mac - cmake_paths does not work directly on mac 2021-05-17 07:31:45 +02:00
Luis Díaz Más
4f057a84ee ci - Win builds without unicode + with warnings as errors 2021-05-17 07:31:45 +02:00
Luis Díaz Más
f956a398ad ci - Use CTest in all the ci jobs 2021-05-15 16:58:24 +02:00
Luis Diaz Mas
b163158100 ci - Use ctest 2021-05-15 16:58:24 +02:00
Luis Díaz Más
d2083b3190 ci - Use generic cmake way to compile and install 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
e6bfa8eb7d ci - Use Ninja in rest of builds 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
fb17e75539 ci - mac uses ninja 2021-05-14 21:31:10 +02:00
Luis Diaz Mas
1769d8988a ci - Linux uses ninja 2021-05-14 21:31:10 +02:00
Luis Díaz Más
776d3a3efc Rename github workflows 2021-05-12 16:10:04 +02:00