third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,481 Commits 2 Branches 0 Tags 122 MiB
fa4ce38d77
Commit Graph

3408 Commits

Author SHA1 Message Date
Luis Díaz Más
f30022d73d
Fix issues detected with PVS-Studio + other little improvements (#1689) 
* avoid re-declaration of constant variables

* Replace pthreads critical section with std::mutex

* ci - better naming

* cmake - increase minimum version to 3.11. Use project DESCRIPTION

* fix - do not treat string::find() return type as bool

* remove conditions that were always true

* remove condition that were always false

* Remove EXV_HAVE_GMTIME_R which is not used anymore

* pixelWidth_ was inherited from Exiv2::Image

The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...

* Remove superfluous if

* pvs:V766 item with identical key added already

* pvs:V730 not all members were initialized (time)

* pvs:V730 not all members are initialized

* pvs:v668 no point in testing pointer against null after new

* pvs:V1048 variable assigned the same value

* replace c-style dynamic vector with std one

* pvs:547 fakeData is always true

* Remove useless constructor in derived class

* pvs:V690 modern way to disable copy-ctor

* Replace malloc/free with new/delete. No need to check for null

* pvs:V1028 cast operands and not result

* Remove custom MIN/MAX functions

* pvs:V595 pointer used before verified against null

* pvs: index used before being checked

* pvs:V1028 possible overflow. Cast operands

* pvs:v575 potential null pointer passed to other functions

* pvs:V547 deal with always true/false expressions

* pvs:V560 part of conditional expressions always false or true

* pvs:V701 possible break in realloc -> move to std::vector

* Make some classes 'final'

* Replace sprintf with std::to_string()

* fix compilation on windows
 2021-06-01 12:39:10 +02:00
Christoph Hasse
758dd6bbc6 refactor!: remove free() function from DataBuf to avoid potential problems, see #1542 2021-05-27 08:26:00 +02:00
Rosen Penev
2c57f214c5 clang-tidy: use nullptr 
Found with modernize-use-nullptr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-26 08:31:45 +02:00
Rosen Penev
86c71ae6c3 clang-tidy: avoid global non const variables 
Found with cppcoreguidelines-avoid-non-const-global-variables

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-25 08:43:27 +02:00
Rosen Penev
d1e116a8ef remove some pointless std::set 
Partially found by gcc's -fanalyzer

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-25 08:29:51 +02:00
Rosen Penev
4c4f8da338 remove initializers 
these were moved outside the constructor body.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-22 10:02:20 +02:00
Rosen Penev
e5894d71e1 default con/destructors in headers 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 23:31:50 -07:00
Rosen Penev
ce47de67b5 use auto in template 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 23:09:05 -07:00
Rosen Penev
c44c289d76 clang-tidy: fix ending namespace comnments 
Found with llvm-namespace-comment

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 23:08:08 -07:00
Rosen Penev
a74bceacb0 clang-tidy: remove pointless return 
Found with readability-redundant-control-flow

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 23:07:45 -07:00
Rosen Penev
743da1a564 clang-tidy: use C++ casting 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-20 07:29:02 +02:00
Rosen Penev
8dbc699858 clang-tidy: add missing explicit 
Found with google-explicit-constructor

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 16:48:44 +02:00
Rosen Penev
ff39473c18 clang-tidy: convert to static 
Found with readability-convert-member-functions-to-static

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:45:20 +02:00
Rosen Penev
6da49fd29b more constexpr 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:11:42 +02:00
Rosen Penev
cdbee3c26c clang-tidy: init in member initializer 
Found with cppcoreguidelines-prefer-member-initializer

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:11:42 +02:00
Rosen Penev
036af68a71 remove pointless constructors 
Replaced with Uniform initialization. Allows constexpr usage.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:11:42 +02:00
Rosen Penev
8564d0b394 clang-tidy: pass by value 
Found with modernize-pass-by-value

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-18 14:30:08 +02:00
Rosen Penev
f9d394adf0 clang-tidy: run through performance checks 
Found with performance*

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-18 14:30:08 +02:00
Rosen Penev
b8712188bb clang-tidy: use auto 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 21:52:03 +02:00
Rosen Penev
20dfab8036 manual for range loop conversions 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 10:30:42 +02:00
Rosen Penev
8e52032ee0 clang-tidy: range loop conversions 
Found with: modernize-loop-convert

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 08:53:39 +02:00
Rosen Penev
c73dfa0106 clang-tidy: use uppercase numeric literals 
Found with readability-uppercase-literal-suffix

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-16 11:27:49 +02:00
Rosen Penev
8e178e912e replace {} initialization with fill 
Old compilers don't implement {} correctly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-16 11:27:10 +02:00
Rosen Penev
fdf9d3799c clang-tidy: don't use else after return 
Found with llvm-else-after-return

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-15 17:32:56 +02:00
Rosen Penev
4aa5566cf6 clang-tidy: make several member functions const 
Found with readability-make-member-function-const

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-15 08:42:04 +02:00
Rosen Penev
24a8139233 clang-tidy: fix badly indented if 
Found with readability-misleading-indentation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-14 17:51:45 +02:00
Rosen Penev
1b9b77c51f clang-tidy: add ending namespace comments 
Found with google-readability-namespace-comments

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-14 17:34:09 +02:00
Rosen Penev
bf290e84e5 fix compilation with EXIV2_DEBUG_MESSAGES 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-14 17:23:10 +02:00
Miloš Komarčević
3416b631c5
Add Sony ARW compression to dict 2021-05-13 16:45:41 +02:00
Rosen Penev
fddb035106 clang-tidy: remove pointless const 
Found with readability-avoid-const-params-in-decls

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-13 16:02:18 +02:00
Rosen Penev
80595f8468 clang-tidy: remove duplicate public 
Found with readability-redundant-access-specifiers

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-13 11:52:02 +02:00
Kevin Backhouse
ca66136092 Use readOrThrow to check error conditions of iIo.read(). 
(cherry picked from commit 0f9eb74c44c908e170a64cab590949d53749af8e)
 2021-05-13 11:51:15 +02:00
Rosen Penev
5dc4292b40 fix bad for range loop 
This loop is supposed to break when it encounters a match.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-13 11:08:29 +02:00
Rosen Penev
091fd77885 clang-tidy: remove redundant member init 
Found with readability-redundant-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 16:45:12 +02:00
Rosen Penev
674fdcd38b clang-tidy: fix declartation names 
Found with readability-inconsistent-declaration-parameter-name

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 09:26:51 +02:00
Rosen Penev
2e73aa9dc0 default con/destructors in headers 
Helps to optimize trivially destructable stuff.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 09:10:36 +02:00
Rosen Penev
428c436629 clang-tidy: simplify boolean expression 
Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 07:12:15 +02:00
Rosen Penev
5d716c7df4 clang-tidy: empty() conversions 
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 07:12:15 +02:00
Rosen Penev
9642e3cceb clang-tidy: remove pointless string init 
Found with readability-redundant-string-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 07:12:15 +02:00
Rosen Penev
143a1fbbe2 clang-tidy: don't use string compare 
Found with readability-string-compare

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-12 07:12:15 +02:00
Rosen Penev
8337462032 clang-tidy: use empty() instead of comparing size 
Found with readability-container-size-empty

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-11 22:02:47 +02:00
Rosen Penev
af7b2430c5 clang-tidy: use override 
Found with modernize-use-override

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-11 17:39:59 +02:00
Rosen Penev
15f0a600ed clang-tidy: use default member init 
Found with modernize-use-default-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-11 15:01:26 +02:00
Kevin Backhouse
170b18db74
Merge pull request #1621 from Exiv2/mergify/bp/main/pr-1591 
Fix infinite loop caused by subBox with zero size. (backport #1591)
 2021-05-11 12:28:03 +01:00
Luis Díaz Más
b4b8061478 Early access is always compiled 2021-05-11 08:25:42 +02:00
Kevin Backhouse
566ea272a1 Prevent large allocation. 
(cherry picked from commit f154f0ae540deeb9251467187d01c2a5846d27b5)
 2021-05-10 15:55:35 +02:00
Kevin Backhouse
aac34630d4 Fix infinite loop caused by subBox with zero size. 
(cherry picked from commit 2736126e7b92c5654f56620c097f9a4580c0f73b)
 2021-05-10 09:06:19 +00:00
Luis Díaz Más
9dbffa719b Add missing public headers to install target 2021-05-09 21:42:52 +02:00
Rosen Penev
5a9c29303e clang-tidy: remove pointless static 
Found with readability-static-definition-in-anonymous-namespace

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-09 17:44:37 +02:00
Rosen Penev
bd6a996181 clang-tidy: use using 
Found with modernize-use-using

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-09 17:42:51 +02:00