Add reproducers for #253 and #246

tests/bugfixes/github/test_issue_246.py

@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+
+import system_tests
+
+class TestFirstPoC(system_tests.Case):
+    """
+    Regression test for the first bug described in:
+    https://github.com/Exiv2/exiv2/issues/246
+    """
+    url = "https://github.com/Exiv2/exiv2/issues/246"
+
+    filename = "{data_path}/1-string-format.jpg"
+    commands = ["{exiv2} -pS " + filename]
+    stdout = [
+        """STRUCTURE OF JPEG FILE: """ + filename + """
+ address | marker       |  length | data
+       0 | 0xffd8 SOI  
+       2 | 0xffe1 APP1  |      60 | Exif..II*.....0.i...........0000
+"""]
+
+
+    stderr = ["""{exiv2_exception_message} """ + filename + """:
+{kerNoImageInInputData}
+"""]
+    retval = [1]

tests/bugfixes/github/test_issue_253.py

@@ -0,0 +1,18 @@
+# -*- coding: utf-8 -*-
+
+import system_tests
+
+class TestFirstPoC(system_tests.Case):
+    """
+    Regression test for the first bug described in:
+    https://github.com/Exiv2/exiv2/issues/253
+    """
+    url = "https://github.com/Exiv2/exiv2/issues/253"
+
+    filename = "{data_path}/3-stringformat-outofbound-read"
+    commands = ["{exiv2} " + filename]
+    stdout = [""]
+    stderr = ["""{exiv2_exception_message} """ + filename + """:
+{kerNotAJpeg}
+"""]
+    retval = [1]

tests/suite.conf

@@ -19,6 +19,8 @@ kerFailedToReadImageData: Failed to read image data
 kerCorruptedMetadata: corrupted image metadata
 kerInvalidMalloc: invalid memory allocation request
 kerInvalidTypeValue: invalid type value detected in Image::printIFDStructure
+kerNotAJpeg : This does not look like a JPEG image
+kerNoImageInInputData: Input data does not contain a valid image
 addition_overflow_message: Overflow in addition
 exiv2_exception_message: Exiv2 exception in print action for file
 exiv2_overflow_exception_message: std::overflow_error exception in print action for file