third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix check (on comparing unsigned minus signed greater zero)

Browse Source 
V555 The expression 'object->sizeDataArea_ - buf.size_ > 0' will work as 'object->sizeDataArea_ != buf.size_'. tiffvisitor.cpp 911
This commit is contained in:
tbeu 2017-11-03 21:20:02 +01:00 committed by Dan Čermák
parent bb9034e029
commit eca251865f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/tiffvisitor_int.cpp
View File

@ -905,7 +905,7 @@ namespace Exiv2 {
#endif
DataBuf buf = object->pValue()->dataArea();
memcpy(object->pDataArea_, buf.pData_, buf.size_);
if (object->sizeDataArea_ - buf.size_ > 0) {
if (object->sizeDataArea_ > static_cast<uint32_t>(buf.size_)) {
memset(object->pDataArea_ + buf.size_,
0x0, object->sizeDataArea_ - buf.size_);
}