Commit Graph

8950 Commits

Author SHA1 Message Date
Rosen Penev
01aab49f6f don't assign an fs::path to a string
Seems to trip up MemorySanitizer on ARM32.

Also applied various simplifications to the code using std::filesystem

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
5ccb525dd3 remove inline function
Just make it part of the template

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
763cfaf2b4 MSVC warning fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
1f3d1f066f extern to static
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
ca95edc6bd random fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
d6c1059485 gcc: ifdef
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
0a8fedf249 gcc: noexcept
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
1f21164085 gcc: remove redundant struct
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
9a1f37ecbe get rid of Key() move operations
Because of Impl, there's no way this can work properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
a3baf7d3e9 clang-tidy: no _ in tests
Found with google-readability-avoid-underscore-in-googletest-name

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
e854d93841 replace enable_if with if constexpr
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
2fd523873b remove MSVC hacks
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
dc196e729e remove old MSVC workaround
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
4a26eba0d9 fix compilation under FreeBSD
sys headers must come before libprocstat

meson is missing a libprocstat dependency. iconv is also broken with
meson and freebsd.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-19 11:08:30 -07:00
Rosen Penev
6a3025dd72 meson CI: use vc++latest
Potentially more warnings

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-18 13:08:23 -07:00
Rosen Penev
4831c65e39
Merge pull request #2551 from kevinbackhouse/fix-issue-2539
Minor refactorings to stop UBSAN from complaining
2023-03-18 12:10:45 -07:00
Kevin Backhouse
5d11208aa0
Minor refactorings to stop UBSAN from complaining. 2023-03-18 17:26:00 +00:00
Rosen Penev
66e904e61e
Merge pull request #2548 from neheb/fa
add various moves
2023-03-14 07:10:10 -07:00
Rosen Penev
e2bf207477 add various moves
More efficient

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-13 23:01:14 -07:00
Rosen Penev
518c52c2af
Merge pull request #2544 from kevinbackhouse/fix-matroska-null-pointer-deref
Check that the pointer isn't NULL
2023-03-12 08:38:48 -07:00
Kevin Backhouse
e0ac920c87
Suggestion from @neheb 2023-03-12 10:54:01 +00:00
Kevin Backhouse
244799f480 Convert tail-recursion to loop to avoid stack exhaustion. 2023-03-11 22:47:47 -08:00
Kevin Backhouse
a783320520 Use enforce, not assert, to avoid crash. 2023-03-11 21:50:33 -08:00
Kevin Backhouse
65259d8936
Check that the pointer isn't NULL. 2023-03-11 23:29:48 +00:00
Rosen Penev
1697417c27
Merge pull request #2540 from neheb/r
github CI: update conan
2023-03-08 06:27:51 -08:00
Rosen Penev
3d2bcf19dc
Merge pull request #2536 from neheb/s
meson updates
2023-03-07 23:05:02 -08:00
Rosen Penev
7bb890f394
github CI: update conan
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-07 16:05:42 -08:00
Rosen Penev
20b160d936
meson: update wraps
Fix dllexport/import mismatch. Fixes MSVC/MinGW warnings.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-07 13:18:39 -08:00
Rosen Penev
ff7bfb3798
Merge pull request #2422 from norbertwg/interpretation-for-Exif.Photo.LensSpecification
Interpretation for Exif.Photo.LensSpecification
2023-03-07 08:22:00 -08:00
norbertwg
10bbe3f4ae to avoid compiler warnings: 0.0 changed to 0.0f 2023-03-07 15:36:07 +01:00
norbertwg
979ce8ab2a Merge branch 'interpretation-for-Exif.Photo.LensSpecification' of https://github.com/norbertwg/exiv2 into interpretation-for-Exif.Photo.LensSpecification 2023-03-07 11:43:59 +01:00
Rosen Penev
605304680e github CI: remove NoConan
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-06 06:59:13 -08:00
Rosen Penev
48ea6ebecc github CI: update conan
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-06 06:59:13 -08:00
norbertwg
db2f4ee377 interpretation for ExifPhoto.LensSpecification
printLensSpecification is copied from old Nikon3MakerNote::print0x0084
call of Nikon3MakerNote::print0x0084 replaced by printLensSpecification

add two lens tags to EasyAccess API
Exif.Photo.LensSpecification and Exif.Nikon3.Lens

handling of zero; more precision for focal length

silence compiler warnings
2023-03-06 11:01:18 +01:00
Kevin Backhouse
93f5acbbff Enable video support by default 2023-03-05 11:41:29 -08:00
Kevin Backhouse
3b0398ab20
Merge pull request #2534 from kevinbackhouse/asfvideo-fix-int-overflow
Fix integer overflow which enables enforce to be bypassed
2023-03-05 07:43:41 +00:00
Kevin Backhouse
14e26b5abd
Fix integer overflow which enables enforce to be bypassed. 2023-03-04 22:06:14 +00:00
Kevin Backhouse
2a03d8b630
Merge pull request #2533 from kevinbackhouse/asfvideo-remaining-size
Fix long-running loop
2023-03-04 21:44:26 +00:00
Kevin Backhouse
b5bf079444
Fix long-running loop 2023-03-04 16:37:49 +00:00
Rosen Penev
725875497b SonarLint cleanups 2023-03-03 19:35:42 -08:00
Mohamed Ali Chebbi
8b96ebc6b4 asfvideo fuzz issue : nb_headers should not exceed the max value of uint32 2023-03-03 17:04:17 -08:00
Rosen Penev
b9d94e61fe coverity: remove dead code
Found with: CID 1521533
Unsigned compared against 0 (NO_EFFECT)

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
03d34bee04 get rid of convertToUint64
same as getULongLong

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
afbd9e7a76 coverity: add move operations
CID 1521171: Missing move assignment operator

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
b6f07ba102 github CI: test x86 on Windows
32-bit MSVC is available and should be tested.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-26 13:58:04 -08:00
Rosen Penev
a1005c7c76 github CI: use ilammy/msvc-dev-cmd
Small simplification

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-26 13:58:04 -08:00
Kevin Backhouse
4a6d786256 Fix test failures on 32-bit platforms. 2023-02-26 09:00:33 -08:00
Rosen Penev
a653043110 github CI: remove EXIV2_ENABLE_VIDEO
This is already default.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-26 08:58:48 -08:00
Rosen Penev
ae1381ede3 github CI: use env
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-26 08:58:48 -08:00
Rosen Penev
2a23a43bc2 meson CI: add /analyze for MSVC
Useful in CI.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-26 08:58:48 -08:00