Commit Graph

8725 Commits

Author SHA1 Message Date
Mohamed Ali Chebbi 1c764358bb Encapsulate video support with compilation variable EXV_ENABLE_VIDEO (#2448)
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add variable to unit test files

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: encapsulate in makefile

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: fix PR windows matrix

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: activate only for concerned CI tests

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: desable for linux release

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add to Fuzz PR
2023-01-04 13:01:34 +01:00
Kevin Backhouse 346e11493f Merge pull request #2443 from kevinbackhouse/inih-from-library3
Remove libinih from codebase and add it as a dependency instead
2023-01-04 10:44:47 +00:00
Rosen Penev b31b4abbaf fix __cplusplus check for MSVC
Because of an MSVC bug, __cplusplus is always 199711L. Use _MSVC_LANG
which gets set properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev f515799a53 use some if constexpr
MSVC suggests this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev bb311ba728 clang-tidy on Windows
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev f981c51eea get rid of -fanalyzer memory leaks
Don't use make_shared inside a function. Instead, change constructor to
value to have std::move.

Also move shared_ptrs everywhere. It's fairly expensive to copy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev d458bf2540 clang-tidy: apply to newly merged stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev e87de698f3 static_cast make_unsigned
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev 85a2b8c63b use some future C++ stuff when possible
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Mohamed Ali Chebbi 7fac35e19a 1748 Video Support in V1.0: part 3/3 : support Asfvideo (#2416)
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings

* code review and clean up some code
2022-12-31 18:20:31 +01:00
Rosen Penev f145fae33b replace any_of with find
Removes need for lambda.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev 304b13c271 use find instead of std::find_if
There's already an operator==

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev ff0491a102 clang-tidy: use make_unique
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev ce8920a0ea clang-tidy: various fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Mohamed Ali Chebbi d755fc18b5 1748 Video Support in V1.0: part 2/3 : support Riffvideo (#2415)
* 1748 Video Support in V1.0: part 2/3 : support RiffVideo

* limit the buffer_size

* Update exiv2.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* Code Review and cleanUp code

* Update riffvideo.hpp

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2022-12-31 10:45:45 +01:00
Mohamed Ali Chebbi 1280f3b849 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo (#2413)
* 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo

* Simplify the code of matroskavideo

* protect conevrtuint64 method from overflow

* use size_t instead of uint64_t
2022-12-30 15:58:07 +01:00
norbertwg 9ca161d1e5 Rename resp. remove duplicate exif keys (#2434)
* rename resp. remove duplicate Exif keys

Duplicate key names with different tag are renamed
Following most of the existing entries, the key with higher tag number
is renamed to ...2.
Exceptions: Canon.CustomFunctions,Olympus.ImageHeight,Olympus.ImageWidth
In the available images samples only the key with higher tag number is
used, so changing the other has less impact on test data and also on
users.
Canon.WhiteBalanceTable with tag 0x00a4 was listed twice, once with
description "SharpnessTable". The entry with the deviating description
is deleted.

* clang format

* adjust test output files (after merge with Exiv2)

* add Exif.NikonLd4.FocusDistance to EasyAccess API

* clang format
2022-12-30 14:37:05 +01:00
Kevin Backhouse ba258cb1ae cmake fatal error if inih library is not found. 2022-12-29 13:04:07 -06:00
Miloš Komarčević 5bbd7021eb Merge pull request #2444 from norbertwg/Lens-Recognition-HD-PENTAX-DA-11-18mm-F2.8-ED-DC-AW
Lens Recognition HD PENTAX-DA* 11-18mm F2.8 ED DC AW
2022-12-29 10:52:13 +01:00
Kevin Backhouse cccf265eab Update .github/workflows/on_PR_windows_matrix.yml 2022-12-28 10:44:36 -05:00
Kevin Backhouse a4164ce866 Remove libinih from codebase and add it as a dependency instead. 2022-12-28 09:33:08 -06:00
norbertwg 8d8ac99be0 Lens Recognition HD PENTAX-DA* 11-18mm F2.8 ED DC AW 2022-12-27 17:53:20 +01:00
Miloš Komarčević 0f65c857a7 Merge pull request #2440 from Exiv2/png_exif
Prefer writing PNG eXIf chunk
2022-12-27 15:18:18 +01:00
Miloš Komarčević b52ade814b Prefer writing PNG eXIf chunk 2022-12-26 12:34:20 +01:00
Luis Díaz Más 13ecfbc233 Update ubuntu-latest tag to ubuntu-22.04 (#2439)
* Update ubuntu-latest tag to ubuntu-22.04

Everytime a CI service such a GitHub actions update the images
corresponding to their 'latest' tags, pipelines tend to have some
hipcups due to changes in the distribution default packages.

By fixing the images to a specific one, we should be more resilient to
changes in the Github actions environment.

* Use same build directory used in CMake presets
2022-12-23 08:36:47 +01:00
Robin Mills aa635fddc8 Merge pull request #2437 from Exiv2/codesee-arch-diagram-workflow-1671443521697
Install the CodeSee workflow.
2022-12-19 09:55:16 +00:00
codesee-maps[bot] 519b56e050 Install the CodeSee workflow. Learn more at https://docs.codesee.io 2022-12-19 09:52:02 +00:00
Luis Díaz Más 3dd881fb12 Merge pull request #2433 from Exiv2/fixCygwin
Replace cygwin github action
2022-11-30 19:16:17 +01:00
Luis Diaz Mas 773265b6dc Replace cygwin github action 2022-11-30 18:46:50 +01:00
Luis Díaz Más cabcd5eee9 Merge pull request #2431 from Exiv2/ciEnableWorkflowDispatchOnWindowsBuilds
Enable Workflow dispatch on Windows CI jobs
2022-11-29 22:38:04 +01:00
Luis Diaz Mas 665e1cfb5c Enable Workflow dispatch on Windows CI jobs 2022-11-29 21:53:55 +01:00
Kevin Backhouse 3551cebd76 Merge pull request #2428 from kevinbackhouse/fix-issue-2427
Fix memory leak in BmffImage::brotliUncompress
2022-11-27 18:10:16 +00:00
Kevin Backhouse 2739d90073 Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52767
Add wrapper class to automatically call BrotliDecoderDestroyInstance() on exit.
2022-11-27 15:36:00 +00:00
Kevin Backhouse 9a133856ba Regression test for https://github.com/Exiv2/exiv2/issues/2427 2022-11-27 15:35:57 +00:00
Kevin Backhouse dcc203b2bf Merge pull request #2424 from kevinbackhouse/fix-issue-2423
Fix long-running loop in QuickTimeVideo::sampleDesc
2022-11-27 13:52:40 +00:00
Kevin Backhouse 9d044d30b1 Use Safe::add 2022-11-23 12:37:09 +00:00
Kevin Backhouse 292082df6f Add break to loop to fix issue 2423, plus some other cleanups. 2022-11-23 12:37:09 +00:00
Kevin Backhouse 7d9deba071 Regression test for https://github.com/Exiv2/exiv2/issues/2423 2022-11-23 12:37:08 +00:00
Luis Díaz Más a700a9c1ab Merge pull request #2426 from Exiv2/ciConan
Remove deprecated option in conan
2022-11-21 22:41:58 +01:00
Luis Diaz Mas 861625c4e7 Remove deprecated option in conan 2022-11-21 21:52:54 +01:00
Rosen Penev 67df85135d early exit
less indentation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-11-20 20:00:15 -08:00
Miloš Komarčević cf15cc52e0 Merge pull request #2417 from Exiv2/kmilos-patch-1
Add Canon R6m2 ID
2022-11-18 09:06:31 +01:00
norbertwg 74720d8044 Remove duplicate tag info entries fujifilm (#2412)
* remove duplicate Fuijifilm TagInfo entries

* test data added for some Fujifilm tags

* remove unknown tag 0x1200

* fix typo: SzeneRecognition to SceneRecognition
2022-11-13 19:26:57 +00:00
Peter 83d7915d00 Update Exif.SonyMisc3c.* and Exif.Sony(1|2).SonyModelID (#2420)
* Update `Exif.SonyMisc3c group`

* Update `Exif.Sony(1|2).SonyModelID`
2022-11-13 08:56:49 +00:00
Miloš Komarčević 026cee3e6a Merge pull request #2419 from Exiv2/ci_concurrency
CI: improved in-progress job canceling
2022-11-09 17:10:43 +01:00
Miloš Komarčević 74e41d982d CI: bump clang-format actions 2022-11-09 16:44:47 +01:00
Miloš Komarčević 66b009a57b CI: bump conan version 2022-11-09 16:23:57 +01:00
Miloš Komarčević 4915a6ba8c CI: improved in-progress job canceling 2022-11-09 16:17:38 +01:00
Miloš Komarčević 5949ec9293 Add Canon R6m2 ID 2022-11-07 17:03:42 +01:00
Peter faa7cc36a9 Update README.md wrt BMFF (#2405)
* Update README.md wrt BMFF

* Fix minor issues in documentation
2022-11-03 08:00:49 +00:00