Commit Graph

7600 Commits

Author SHA1 Message Date
Kevin Backhouse
2d5cccd488
Enable fuzzing of bmffimage.cpp 2021-07-23 15:28:04 +01:00
Kevin Backhouse
78e9c8aa82
address + box_length == box_end 2021-07-23 15:24:59 +01:00
Kevin Backhouse
02d4ef2c5e
Support for 64-bit box lengths looked broken. 2021-07-23 15:06:57 +01:00
Kevin Backhouse
8c64e9abba
Add pbox_end param to BmffImage::boxHandler to enforce box nesting. 2021-07-23 13:23:56 +01:00
Kevin Backhouse
adb586ae9a
Regression test for https://github.com/Exiv2/exiv2/issues/1793 2021-07-23 12:40:50 +01:00
Kevin Backhouse
82057a6a1d
Merge pull request #1777 from postscript-dev/update_sony2fp_tags
Update Sony2Fp tags
2021-07-18 14:21:33 +01:00
postscript-dev
510a38e27d
Move all startsWith() funcs to Util namespace
The function checks if a string is in the beginning of another. This
is intended for use until the move to C++20 when
`std::basic_string<>::starts_with()` becomes available. Suggested in
https://github.com/Exiv2/exiv2/pull/1777 .

Separate identical definitions have been moved into a single copy.
2021-07-18 12:00:05 +01:00
Kevin Backhouse
6373fe3195
Merge pull request #1780 from Exiv2/mergify/bp/main/pr-1778
Fix infinite loop in Image::printIFDStructure (backport #1778)
2021-07-16 14:37:55 +01:00
Kevin Backhouse
8f126c0664
Merge pull request #1781 from kevinbackhouse/filter_xmpsdk
Ignore results in the xmpsdk directory
2021-07-16 12:28:17 +01:00
Kevin Backhouse
8c80d060f0
Ignore results in the xmpsdk directory. 2021-07-16 12:04:27 +01:00
postscript-dev
0827a76b6a
Update Sony2Fp makernote functions
Minor changes using suggestions in #1777:
+ Simplify loop conditions
+ Add startsWith() in SonyMakerNote class
+ Change `if`/`else` to `switch`
2021-07-16 11:04:13 +01:00
Kevin Backhouse
e4e3362284
Defensive programming in Image::printIFDStructure 2021-07-15 22:27:10 +01:00
Kevin Backhouse
caf08b229e
dirLength == 0 can cause an infinite loop. 2021-07-15 22:15:30 +01:00
Kevin Backhouse
093dca0281
Regression test for https://github.com/Exiv2/exiv2/security/advisories/GHSA-m479-7frc-gqqg 2021-07-15 22:15:30 +01:00
Kevin Backhouse
0208b508a0
Merge pull request #1773 from kevinbackhouse/fuzz
Add fuzz target
2021-07-15 21:55:31 +01:00
Kevin Backhouse
fa52d7e2cb Better way to print the error message. 2021-07-15 19:25:37 +02:00
Kevin Backhouse
6685b8db4a Print message to stderr when EXIV2_DEBUG_MESSAGES is enabled. 2021-07-15 19:25:37 +02:00
Kevin Backhouse
f724f4e2fc Don't crash if s > size. 2021-07-15 19:25:37 +02:00
Kevin Backhouse
c310e2c41f Regression test for https://github.com/Exiv2/exiv2/security/advisories/GHSA-mv9g-fxh2-m49m 2021-07-15 19:25:37 +02:00
Kevin Backhouse
5d164005d4
Merge pull request #1771 from kevinbackhouse/codeql-unsafe-vector-access
CodeQL query to detect unsafe uses of std::vector::operator[]
2021-07-15 10:57:13 +01:00
Kevin Backhouse
86e7dbd3c1
Merge pull request #1775 from kevinbackhouse/MultToLargerType
Fix code scanning alert: "Multiplication result converted to larger type"
2021-07-15 10:56:37 +01:00
postscript-dev
e821404d69
Merge branch 'update_sony2fp_tags' of https://github.com/postscript-dev/exiv2 into update_sony2fp_tags 2021-07-14 12:12:28 +01:00
postscript-dev
4a21b45e60
Update Sony2Fp makernote tag selector function
In C++20, std::string has a starts_with() function. Add a startsWith()
function now, which can be replaced when the project moves to C++20.

Suggested in https://github.com/Exiv2/exiv2/pull/1777
2021-07-14 12:08:16 +01:00
Peter
670c89b2bd
Merge branch 'Exiv2:main' into update_sony2fp_tags 2021-07-13 16:55:16 +01:00
postscript-dev
4ac8ac9ba0
Update Sony2Fp makernote tags (tag 9402)
Changes:
+ Add pretty printing for all tags
+ Add camera selector, to prevent incompatible models using tags
+ Update testing with new values

Source: Exiftool (https://exiftool.org/TagNames/Sony.html)
2021-07-13 16:53:15 +01:00
Kevin Backhouse
e157fd63cb
Add -workers option to use all cores. 2021-07-13 13:13:45 +01:00
Kevin Backhouse
6798be637f
Merge pull request #1774 from Exiv2/mergify/bp/main/pr-1745
fix: avoid processing MOV (quicktime) files when BMFF is enabled (backport #1745)
2021-07-13 11:40:38 +01:00
Kevin Backhouse
7b3dd26c23
Merge pull request #1718 from opengisch/ios
Fix building for ios
2021-07-13 10:16:50 +01:00
Kevin Backhouse
51b5616fc0
Merge pull request #1772 from postscript-dev/add_SonyMisc1_tags
Add SonyMisc1 (Tag 0x9403) makernote tags
2021-07-13 10:15:53 +01:00
Kevin Backhouse
b13585a697
Fix code scanning alert: "Multiplication result converted to larger type".
9284b58bfc/samples/Jzon.cpp (L61-L61)
2021-07-13 10:11:20 +01:00
postscript-dev
eb22591cea
Fix formatting of sonyMisc1 makernote tags 2021-07-12 20:40:55 +01:00
Christoph Hasse
3e681c6730 fix: avoid processing MOV (quicktime) files when BMFF is enabled
(cherry picked from commit 1b6895927f293855e5bb437ad28f31da2c2cfe54)
2021-07-12 18:17:20 +00:00
Kevin Backhouse
7eef360295
Try with sudo. 2021-07-12 15:59:17 +01:00
Kevin Backhouse
b4448fcd52
Fix indentation 2021-07-12 14:40:03 +01:00
Kevin Backhouse
f4a0335d79
Add workflow_dispatch for manual trigger 2021-07-12 14:29:51 +01:00
Kevin Backhouse
95397cc17a
Action that runs fuzzer for short amount of time on PRs. 2021-07-12 13:14:24 +01:00
Kevin Backhouse
a7602639ea
Add printing and writing to fuzzer. 2021-07-12 10:56:04 +01:00
Kevin Backhouse
a3e4efe6b4
Rename fuzz target 2021-07-12 10:53:04 +01:00
Kevin Backhouse
bf786f4cc6
Updates to make fuzzing work. 2021-07-11 21:14:08 +01:00
postscript-dev
87e72adba4
Add SonyMisc1 tag group to docs 2021-07-11 17:13:27 +01:00
postscript-dev
5d2d6037c7
Add python test for SonyMisc1 2021-07-11 16:50:24 +01:00
postscript-dev
2b8856dcea
Add SonyMisc1 (Tag 0x9403) makernote tags
Source: Exiftool (https://exiftool.org/TagNames/Sony.html)
2021-07-11 16:32:38 +01:00
Kevin Backhouse
a2854f358a
CodeQL query to detect unsafe uses of std::vector::operator[]. 2021-07-11 15:49:51 +01:00
Kevin Backhouse
9284b58bfc
Merge pull request #1767 from kevinbackhouse/fix-issue-1763
Fix null iterator deref in printCsLensTypeByMetadata
2021-07-09 16:11:30 +01:00
Jeka Pats
b2cdf2a535
Add libFuzzer integration + report bug
This commit places the basics for libFuzzer integration with one
fuzzer which fuzzes the readMetadata function. The fuzzer is
located at fuzz/read-metadata.

To add more fuzzers please add them to ./fuzz directory as
described in the README.

Also a memory corruption bug is found using this fuzzer which
might lead to additional bugs after fix is pushed.
2021-07-09 12:32:21 +01:00
Kevin Backhouse
033175e127
Don't deref end iterator. 2021-07-09 10:41:13 +01:00
Kevin Backhouse
f8ae9297c7
Regression test for https://github.com/Exiv2/exiv2/issues/1763 2021-07-09 10:41:13 +01:00
Kevin Backhouse
c7757d7c08
Merge pull request #1768 from kevinbackhouse/codeql-null-iterator-deref
Add custom CodeQL query for null iterator deref
2021-07-09 10:12:24 +01:00
Kevin Backhouse
fb824ac052
Add custom CodeQL query for null iterator deref. 2021-07-08 16:50:55 +01:00
Kevin Backhouse
9b3ed3f956
Merge pull request #1756 from ffontaine/main
add BUILD_WITH_STACK_PROTECTOR option
2021-07-08 11:34:20 +01:00