Commit Graph

8595 Commits

Author SHA1 Message Date
Rosen Penev
71dc04ebb1 misc sonarlint stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-22 23:00:32 -07:00
Rosen Penev
89d7798f1d Add more MIME type mappings for TIFF-based raws
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:18 -07:00
Rosen Penev
2fa84f4bab remove using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:18 -07:00
Rosen Penev
235b1e0d19 move structured bindings up
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:12 -07:00
Rosen Penev
88fcd234bb remove pointless x_default variable
Just replace it with the string.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-17 02:25:10 -07:00
Rosen Penev
b6c2062fae std::to_string conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-17 02:25:10 -07:00
Rosen Penev
10a62b2350 replace custom gcd function with std
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-16 05:58:09 -07:00
Peter
7a96867f31
Add request for exiv2 version/source (bug report) (#2331) 2022-08-16 12:09:39 +01:00
Kevin Backhouse
3ac7608282
Merge pull request #2321 from kevinbackhouse/fix-issue-2320
Fix integer overflow in printDegrees
2022-08-09 13:25:17 -04:00
Rosen Penev
75f54e093f cmakelists.txt: run through cmake-format
Just whitespace changes

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00
Rosen Penev
e151daa0fc fix compilation without mmap and non win32
buf was refactored not to be a pointer.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00
Rosen Penev
6cf06c6534 remove constructor
It can be implicitly generated.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00
Kevin Backhouse
fe4f56d979
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=49894
Check that `60 * rem` won't overflow.
2022-08-08 23:48:16 -04:00
Kevin Backhouse
df59a6bb67
Regression test for https://github.com/Exiv2/exiv2/issues/2320 2022-08-08 23:47:11 -04:00
Rosen Penev
fc840405cc revert std::function back to function pointers
The former has too much overhead. No point in it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 19:24:47 -07:00
Rosen Penev
9aaeb893ee don't use w32 sockets for cygwin
Not needed.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 19:19:05 -07:00
Rosen Penev
350541f22a manual replacement of [0] with front()
Avoids implicit array decay.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 19:18:22 -07:00
Rosen Penev
5c90684441 simplify some defines
As far as I can tell, _WIN32 is defined for true Windows platforms.
Cygwin is a POSIX platform.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Rosen Penev
f3b572d211 fix iconv handling and windows
WIN32 as a define is wrong. _WIN32 is the correct one.

Which opens up the issue of the used functions and the wrong logic.
Changed the function logic to use if and elif, as done later in the
code.

Also changed all usages of WIN32 with _WIN32

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Rosen Penev
e41dd1d227 remove pointless UNUSED statement
Does not compile as it is no longer present.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Rosen Penev
2b8ca5a9d7 fix compilation with mingw iconv
The parameter there is const. Use the appropriate macro.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Luis Díaz Más
2c5e1d8cac
Merge pull request #2314 from Exiv2/updateConan
ci: Upgrade conan to version 1.51.0
2022-08-08 08:23:20 +02:00
Luis Diaz Mas
dea611c2a0 ci: Upgrade conan to version 1.51.0 2022-08-08 07:22:32 +02:00
Miloš Komarčević
7fa6d7378f Add Nikon3.WhiteBalanceBias2 2022-08-05 13:51:30 -07:00
Rosen Penev
306424f589 remove c_str for fs stuff
fs::path is convertable to a string.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
b8855fb3b5 misc sonarlint cleanups
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
1602afef0a const conversions
These were not const.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
5e20467e5c default init static variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
d4f04296e4 remove explicit constructor
No need.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
c64ed25c13 remove unused using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
7b9ba51c4e enum class conversion
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Rosen Penev
6e3db99755 simplify switch statement with returns
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-05 01:01:25 -07:00
Kevin Backhouse
2e8ce712ec Use emplace(). 2022-08-04 11:07:18 -07:00
Kevin Backhouse
166b5b834d Replace TiffTreeStruct with std::pair 2022-08-04 11:07:18 -07:00
Kevin Backhouse
3d38e11300 Remove unneeded constructor 2022-08-04 11:07:18 -07:00
Kevin Backhouse
67270c2b11 Use std::unordered_map for TiffTreeStruct lookup. 2022-08-04 11:07:18 -07:00
Kevin Backhouse
be1c00c916 Suggestions from @neheb and @piponazo 2022-08-04 11:05:35 -07:00
Kevin Backhouse
71dfff5a69 Use a switch 2022-08-04 11:05:35 -07:00
Kevin Backhouse
7ec15d247e Use std::unordered_set for tiffImageTags 2022-08-04 11:05:35 -07:00
Rosen Penev
12b94bc420 get rid of extern const
Looks like some pre C++11 thing.

Also fix formatting of these by adding , at the end of the arrays.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-03 20:00:33 -07:00
Kevin Backhouse
e831219d5c Correct error from #2301 2022-08-03 20:00:20 -07:00
Rosen Penev
938964f4d0 remove GroupName struct
No point in this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-03 19:59:13 -07:00
Kevin Backhouse
cc604780be
Merge pull request #2283 from kevinbackhouse/printStructure-depth
Convert type of depth parameter to size_t
2022-08-03 16:38:03 +01:00
Kevin Backhouse
09f61bc3d1 Suggestions from @neheb and @piponazo. 2022-08-03 01:36:55 -07:00
Kevin Backhouse
1fccceeba1 Use std::map for faster lookup. 2022-08-03 01:36:55 -07:00
Rosen Penev
e74feff4d8 strcmp to == conversions
Does the same thing.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-03 01:36:19 -07:00
Rosen Penev
d5e42da39e replace structs with std::pair
Simpler.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-03 01:35:59 -07:00
Luis Díaz Más
0256775408
Merge pull request #1949 from VJSchneid/main
add support for more fujifilm tags
2022-08-03 08:34:58 +02:00
Kevin Backhouse
ee5dae4ddd Fix implicit cast warning. 2022-08-01 16:28:36 -07:00
Kevin Backhouse
4410f46214 Change the return type of the 2Data functions to size_t. 2022-08-01 16:28:36 -07:00