third_party/exiv2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
7,675 Commits 2 Branches 0 Tags 122 MiB
8f889c132e
Commit Graph

72 Commits

Author SHA1 Message Date
Peter Kovář
8f889c132e Corrected JPEG XL file type 2021-08-01 13:56:48 +02:00
Kevin Backhouse
5eb464271e
Fix format specifier. 2021-07-23 16:55:47 +01:00
Kevin Backhouse
43d95b8a75
Fix compiler warnings. 2021-07-23 16:25:55 +01:00
Kevin Backhouse
3019fbee4f
Extra protection against large allocations. 2021-07-23 16:19:26 +01:00
Kevin Backhouse
78e9c8aa82
address + box_length == box_end 2021-07-23 15:24:59 +01:00
Kevin Backhouse
02d4ef2c5e
Support for 64-bit box lengths looked broken. 2021-07-23 15:06:57 +01:00
Kevin Backhouse
8c64e9abba
Add pbox_end param to BmffImage::boxHandler to enforce box nesting. 2021-07-23 13:23:56 +01:00
Christoph Hasse
3e681c6730 fix: avoid processing MOV (quicktime) files when BMFF is enabled 
(cherry picked from commit 1b6895927f293855e5bb437ad28f31da2c2cfe54)
 2021-07-12 18:17:20 +00:00
Kevin Backhouse
2b84f4bd64
fix: zero initialize local variables. (#1743) 
* Zero initialize local variables.

* Initialize xmpID_
 2021-06-27 08:56:31 +02:00
Luis Díaz Más
f30022d73d
Fix issues detected with PVS-Studio + other little improvements (#1689) 
* avoid re-declaration of constant variables

* Replace pthreads critical section with std::mutex

* ci - better naming

* cmake - increase minimum version to 3.11. Use project DESCRIPTION

* fix - do not treat string::find() return type as bool

* remove conditions that were always true

* remove condition that were always false

* Remove EXV_HAVE_GMTIME_R which is not used anymore

* pixelWidth_ was inherited from Exiv2::Image

The width & height variables in the TiffImage class need to be mutable
to be able to change their values on the getters pixelHeight() and
pixelWidth() ... Do not ask me why ...

* Remove superfluous if

* pvs:V766 item with identical key added already

* pvs:V730 not all members were initialized (time)

* pvs:V730 not all members are initialized

* pvs:v668 no point in testing pointer against null after new

* pvs:V1048 variable assigned the same value

* replace c-style dynamic vector with std one

* pvs:547 fakeData is always true

* Remove useless constructor in derived class

* pvs:V690 modern way to disable copy-ctor

* Replace malloc/free with new/delete. No need to check for null

* pvs:V1028 cast operands and not result

* Remove custom MIN/MAX functions

* pvs:V595 pointer used before verified against null

* pvs: index used before being checked

* pvs:V1028 possible overflow. Cast operands

* pvs:v575 potential null pointer passed to other functions

* pvs:V547 deal with always true/false expressions

* pvs:V560 part of conditional expressions always false or true

* pvs:V701 possible break in realloc -> move to std::vector

* Make some classes 'final'

* Replace sprintf with std::to_string()

* fix compilation on windows
 2021-06-01 12:39:10 +02:00
Rosen Penev
743da1a564 clang-tidy: use C++ casting 
Found with google-readability-casting

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-20 07:29:02 +02:00
Rosen Penev
cdbee3c26c clang-tidy: init in member initializer 
Found with cppcoreguidelines-prefer-member-initializer

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-19 14:11:42 +02:00
Rosen Penev
b8712188bb clang-tidy: use auto 
Found with modernize-use-auto

Signed-off-by: Rosen Penev <rosenp@gmail.com>
 2021-05-17 21:52:03 +02:00
Kevin Backhouse
8388223deb Check that the string is properly terminated. 2021-04-22 11:38:49 +02:00
Kevin Backhouse
e8422732af Fix LGTM warning about format specifier 
https://lgtm.com/projects/g/Exiv2/exiv2/rev/pr-6633ad1cc6e6c36bffd6655165c299c53e934b22
 2021-04-22 11:38:49 +02:00
Kevin Backhouse
e97a9ff88a Fix signed/unsigned compiler warning. 2021-04-22 11:38:49 +02:00
Kevin Backhouse
27e349e063 Fix signed/unsigned compiler warning. 2021-04-22 11:38:49 +02:00
Kevin Backhouse
285e7a4e72 Fix out-of-bounds read in bmffimage.cpp 2021-04-22 11:38:49 +02:00
Luis Díaz Más
f85f7f717a Replace many of the iterators types with auto 2021-04-19 10:43:46 +02:00
Luis Díaz Más
01a3bc716d Fix warnings in VS 2021-04-19 10:43:46 +02:00
Luis Díaz Más
0a1bf46a1c revert changes that are affecting to VS 2021-04-18 18:49:58 +02:00
Luis Díaz Más
de4d43d4d1 Fix warnings EXIV2_TEAM_EXTRA_WARNINGS 
Most of the warnings fixed were:
- Hiding of local variables
- Hiding of globals
- Useless casts
- Conversions between float/double
 2021-04-18 18:49:58 +02:00
Robin Mills
206a2c495c fix_enableBMFF_v1 2021-04-16 08:23:50 +02:00
Luis Díaz Más
0bbaa6eff3 cpp: Replace auto_ptr by unique_ptr 2021-04-15 06:56:11 +02:00
Robin Mills
aef9cf76f7 fix_1503_JXL_bmff 2021-04-03 15:20:37 +01:00
Robin Mills
49cfe45323
Merge pull request #1513 from Exiv2/fix_1508_enableBMFF 
Fix 1508 enable bmff
 2021-04-02 21:12:07 +01:00
Robin Mills
9da2aed5d2 Use the documented 5 line prolog in every sample application. Tidy up sample prologs and header code. 2021-04-02 16:58:20 +01:00
Robin Mills
190106ca78 fix_1507_avif_size0x0 2021-04-02 16:02:41 +01:00
Miloš Komarčević
f95d97a0bf Add mif1 brand to heif mime type 2021-03-12 09:20:14 +01:00
Miloš Komarčević
fcb3066950 Include a few more BMFF major brands 2021-03-11 22:30:03 +01:00
Miloš Komarčević
e3c78623f7 Include HEIC type explicitly 2021-03-10 22:23:01 +01:00
clanmills
212f1b5ebb Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF(). 2021-03-10 08:59:17 +00:00
clanmills
e3fd0c633e Thank You @piponazo for the code review. I've made the changes you requested. 2021-03-09 14:10:52 +00:00
clanmills
2f2dd7d56c Fix ICC profile handling (my bad, iOS files are correct). 2021-03-07 20:23:50 +00:00
clanmills
0ad46453ed With good fortune, bmffimage is ready for review. 2021-03-06 16:12:02 +00:00
clanmills
ee4d14340a Fix box.length == to use bigEndian decode! Fix toAscii() to emit on ascii 32-127 bytes. 2021-03-05 18:21:16 +00:00
Robin Mills
71d29fe60b Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows. 2021-03-03 14:34:15 +00:00
clanmills
55d2201892 Changed CI build default -DEXIV2_ENABLE_BMFF=On. Fixed suite to run with/without bmff. -pS and -pR same for bmff. 2021-03-03 10:40:08 +00:00
Robin Mills
c84274ec19 Cosmetic change to -pR/-pS output. 2021-03-02 19:36:33 +00:00
Robin Mills
fd9cb67fb7 WIP: adding BmffImage::printStructure() and support for colr box. 2021-03-02 14:39:56 +00:00
Robin Mills
4ca05ed34a Fix .CR3 files to call parseXmp(). 2021-02-28 13:51:20 +00:00
Robin Mills
ea1c91874f Added parseXmp() to parse Xmp metadata. 2021-02-28 11:29:09 +00:00
Robin Mills
44d976c2a1 Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp 2021-02-26 10:21:12 +00:00
Robin Mills
5c77888037 Revised following code review by @hassec. Thank You, Christoph. 2021-02-25 18:10:48 +00:00
Peter Kovář
4d3af08ad8 Add CR3 image dimensions 2021-02-25 18:42:34 +01:00
Robin Mills
4ae0a1d2a3 Tidy up. Rename Tag::cr3_exif -> Tag:cmt2 2021-02-25 15:25:09 +00:00
Robin Mills
9515e4658b Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp. 2021-02-25 14:47:20 +00:00
Robin Mills
913ee33372 Parse Exif in .HEIC/.AVIF 2021-02-25 12:28:50 +00:00
Peter Kovář
108670b309 Corrected format string 2021-02-25 11:18:51 +01:00
Christoph Hasse
28b41f59bd run clang-format on new files 2021-02-25 10:42:38 +01:00