Commit Graph

566 Commits

Author SHA1 Message Date
Rosen Penev
9ae339d39f clang: fix various documentation errors
Found with -Wdocumentation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-22 06:11:10 -07:00
Miloš Komarčević
18e11ac1b6
Explicitly include stdint (#2558) 2023-03-22 11:55:52 +01:00
Rosen Penev
22b12012a6 more SonarLint cleanups
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
5ccb525dd3 remove inline function
Just make it part of the template

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
763cfaf2b4 MSVC warning fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
ca95edc6bd random fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
1f21164085 gcc: remove redundant struct
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
9a1f37ecbe get rid of Key() move operations
Because of Impl, there's no way this can work properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
dc196e729e remove old MSVC workaround
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-03-20 08:01:22 -07:00
Rosen Penev
725875497b SonarLint cleanups 2023-03-03 19:35:42 -08:00
Rosen Penev
03d34bee04 get rid of convertToUint64
same as getULongLong

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
afbd9e7a76 coverity: add move operations
CID 1521171: Missing move assignment operator

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-27 07:05:08 -08:00
Rosen Penev
3fe6d78014 Remove some constructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
2205a14a06 clang-tidy: default init various members
Found with cppcoreguidelines-pro-type-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
dd25d9999b direct init structs
No need to deal with individual members

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
3426eaaadf default init variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
31165b6a01 remove base constructor
Maybe works now

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:30:11 -08:00
Rosen Penev
3e6ba8f241 clang-tidy: add explicit
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
1a40f9660e replace standard check with feature test macro
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Mohamed Ali Chebbi
51ef600fe6 compilation issue on Mac OS 2 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
bed8d3d93c rework of aspectRatio calculation for all video formats and rework the decoding of asf tags 2023-02-10 21:55:24 -08:00
Rosen Penev
dee0598edf
clang-tidy fixes for recent stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:27 -08:00
Mohamed Ali Chebbi
3847a09359
Merge branch 'main' into TestVideoData 2023-02-06 09:23:43 +01:00
Rosen Penev
e309680a86 remove deleted members from static classes
This is a holdover from C++98. No need anymore

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ddb42eb159 remove some overriden defaulted destructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ef82f953c0 do the same for Io functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
3290fe6146 remove deleted Image member functions
The inherited Image class already has these same deleted functions.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Mohamed Ali Chebbi
bf6546ee82 add test/data for video support : restore Riff HeaderReader and reserve addtional byte in readStraingTag 2023-02-05 00:11:03 +01:00
Mohamed Ali Chebbi
acd71894b2 add test/data for video support : delete unused parameter from readList method 2023-02-05 00:01:36 +01:00
Mohamed Ali Chebbi
0f715288e7 add test/data for video support : delete riff HeaderReader 2023-02-04 23:46:18 +01:00
Mohamed Ali Chebbi
d288617759 add test/data for video support : Fix test issue 2023-02-03 12:37:18 +01:00
Mohamed Ali Chebbi
a36e4dd1e8 Merge branch 'main' into TestVideoData 2023-02-02 16:58:45 +01:00
Mohamed Ali Chebbi
cb7a48f84a Rework Asf and Riff formats ; add test/data for video support 2023-02-02 16:31:16 +01:00
Rosen Penev
805a1e5601 move inline to declaration
Fixes warning under Windows:

redeclared inline; 'dllimport' attribute ignored [-Wignored-attributes]

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-29 08:45:15 -08:00
Miloš Komarčević
c9f7a9f34e
Merge pull request #2479 from Exiv2/export_qtvid
Export QuickTimeVideo
2023-01-27 15:33:29 +01:00
Rosen Penev
db0da461ee static_cast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-27 06:06:57 -08:00
Miloš Komarčević
4e8dca45a3 Export QuickTimeVideo 2023-01-27 12:34:43 +01:00
Rosen Penev
a87c59be51 remove unused variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Mohamed Ali Chebbi
bbb3f5afa8 add test/data for video support : gix issue in riff video and reference data test 2023-01-23 01:39:16 +01:00
Mohamed Ali Chebbi
82ea6bef52 add test/data for video support : make asfvideo more readable and fix some issues 2023-01-23 00:21:04 +01:00
Rosen Penev
3e97850e97 manual default member init
clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Kevin Backhouse
346e11493f
Merge pull request #2443 from kevinbackhouse/inih-from-library3
Remove libinih from codebase and add it as a dependency instead
2023-01-04 10:44:47 +00:00
Rosen Penev
b31b4abbaf fix __cplusplus check for MSVC
Because of an MSVC bug, __cplusplus is always 199711L. Use _MSVC_LANG
which gets set properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
f515799a53 use some if constexpr
MSVC suggests this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
bb311ba728 clang-tidy on Windows
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
d458bf2540 clang-tidy: apply to newly merged stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
e87de698f3 static_cast make_unsigned
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
85a2b8c63b use some future C++ stuff when possible
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Mohamed Ali Chebbi
7fac35e19a
1748 Video Support in V1.0: part 3/3 : support Asfvideo (#2416)
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings

* code review and clean up some code
2022-12-31 18:20:31 +01:00
Rosen Penev
ff0491a102 clang-tidy: use make_unique
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00