Commit Graph

4130 Commits

Author SHA1 Message Date
Mohamed Ali Chebbi
bbb3f5afa8 add test/data for video support : gix issue in riff video and reference data test 2023-01-23 01:39:16 +01:00
Mohamed Ali Chebbi
82ea6bef52 add test/data for video support : make asfvideo more readable and fix some issues 2023-01-23 00:21:04 +01:00
Mohamed Ali Chebbi
5deee73141
Merge branch 'Exiv2:main' into TestVideoData 2023-01-21 00:15:10 +01:00
Kevin Backhouse
b55a0a564a
Silence unused parameter warning when EXV_ENABLE_INIH is undefined. 2023-01-17 08:51:12 +00:00
Kevin Backhouse
43c9ec0f50
Add EXIV2_ENABLE_INIH flag to enable building without libinih. 2023-01-16 10:33:25 +00:00
Mohamed Ali Chebbi
1bd52de0a9 add test/data for video support : delete filename (unuseful) 2023-01-06 23:44:35 +01:00
Rosen Penev
842ef05ee6 return nullptr instead of reset
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
ce8691bba3 remove double libintl check
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
d6e1b90a23 avoid reassignment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
dd3b3d4ff4 add const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
3e97850e97 manual default member init
clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Mohamed Ali Chebbi
1c764358bb
Encapsulate video support with compilation variable EXV_ENABLE_VIDEO (#2448)
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add variable to unit test files

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: encapsulate in makefile

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: fix PR windows matrix

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: activate only for concerned CI tests

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: desable for linux release

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add to Fuzz PR
2023-01-04 13:01:34 +01:00
Kevin Backhouse
346e11493f
Merge pull request #2443 from kevinbackhouse/inih-from-library3
Remove libinih from codebase and add it as a dependency instead
2023-01-04 10:44:47 +00:00
Rosen Penev
bb311ba728 clang-tidy on Windows
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
f981c51eea get rid of -fanalyzer memory leaks
Don't use make_shared inside a function. Instead, change constructor to
value to have std::move.

Also move shared_ptrs everywhere. It's fairly expensive to copy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
d458bf2540 clang-tidy: apply to newly merged stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Mohamed Ali Chebbi
7fac35e19a
1748 Video Support in V1.0: part 3/3 : support Asfvideo (#2416)
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings

* code review and clean up some code
2022-12-31 18:20:31 +01:00
Rosen Penev
f145fae33b replace any_of with find
Removes need for lambda.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
304b13c271 use find instead of std::find_if
There's already an operator==

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
ff0491a102 clang-tidy: use make_unique
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
ce8920a0ea clang-tidy: various fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Mohamed Ali Chebbi
d755fc18b5
1748 Video Support in V1.0: part 2/3 : support Riffvideo (#2415)
* 1748 Video Support in V1.0: part 2/3 : support RiffVideo

* limit the buffer_size

* Update exiv2.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* Code Review and cleanUp code

* Update riffvideo.hpp

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2022-12-31 10:45:45 +01:00
Mohamed Ali Chebbi
1280f3b849
1748 Video Support in V1.0: part 1/3 : support MatroskaViedo (#2413)
* 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo

* Simplify the code of matroskavideo

* protect conevrtuint64 method from overflow

* use size_t instead of uint64_t
2022-12-30 15:58:07 +01:00
norbertwg
9ca161d1e5
Rename resp. remove duplicate exif keys (#2434)
* rename resp. remove duplicate Exif keys

Duplicate key names with different tag are renamed
Following most of the existing entries, the key with higher tag number
is renamed to ...2.
Exceptions: Canon.CustomFunctions,Olympus.ImageHeight,Olympus.ImageWidth
In the available images samples only the key with higher tag number is
used, so changing the other has less impact on test data and also on
users.
Canon.WhiteBalanceTable with tag 0x00a4 was listed twice, once with
description "SharpnessTable". The entry with the deviating description
is deleted.

* clang format

* adjust test output files (after merge with Exiv2)

* add Exif.NikonLd4.FocusDistance to EasyAccess API

* clang format
2022-12-30 14:37:05 +01:00
Kevin Backhouse
ba258cb1ae
cmake fatal error if inih library is not found. 2022-12-29 13:04:07 -06:00
Kevin Backhouse
a4164ce866
Remove libinih from codebase and add it as a dependency instead. 2022-12-28 09:33:08 -06:00
norbertwg
8d8ac99be0 Lens Recognition HD PENTAX-DA* 11-18mm F2.8 ED DC AW 2022-12-27 17:53:20 +01:00
Miloš Komarčević
b52ade814b Prefer writing PNG eXIf chunk 2022-12-26 12:34:20 +01:00
Kevin Backhouse
2739d90073
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52767
Add wrapper class to automatically call BrotliDecoderDestroyInstance() on exit.
2022-11-27 15:36:00 +00:00
Kevin Backhouse
9d044d30b1
Use Safe::add 2022-11-23 12:37:09 +00:00
Kevin Backhouse
292082df6f
Add break to loop to fix issue 2423, plus some other cleanups. 2022-11-23 12:37:09 +00:00
Rosen Penev
67df85135d early exit
less indentation

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-11-20 20:00:15 -08:00
Miloš Komarčević
cf15cc52e0
Merge pull request #2417 from Exiv2/kmilos-patch-1
Add Canon R6m2 ID
2022-11-18 09:06:31 +01:00
norbertwg
74720d8044
Remove duplicate tag info entries fujifilm (#2412)
* remove duplicate Fuijifilm TagInfo entries

* test data added for some Fujifilm tags

* remove unknown tag 0x1200

* fix typo: SzeneRecognition to SceneRecognition
2022-11-13 19:26:57 +00:00
Peter
83d7915d00
Update Exif.SonyMisc3c.* and Exif.Sony(1|2).SonyModelID (#2420)
* Update `Exif.SonyMisc3c group`

* Update `Exif.Sony(1|2).SonyModelID`
2022-11-13 08:56:49 +00:00
Miloš Komarčević
5949ec9293
Add Canon R6m2 ID 2022-11-07 17:03:42 +01:00
Peter
1f364be1fa
Fix seg fault when using iconv_open() (#2403)
* Fix seg fault when using `iconv_open()`

- Fix failure condition for `iconv_open()`
- Add new exception when failing to change the text encoding of an
Exif comment

* Add testing for `iconv_open()` seg fault bug

* Fix Python test by changing log level
2022-11-01 13:33:36 +00:00
Kevin Backhouse
ddd7ccf722 Use std::is_signed and std::enable_if. 2022-10-31 17:17:37 -07:00
Kevin Backhouse
335e13251e Add #error so the build fails if mmap isn't supported. 2022-10-31 03:01:26 -07:00
Kevin Backhouse
5cabd97373 Fix issue 2380: bug in (unused) non-mmap code. 2022-10-31 03:01:26 -07:00
Kevin Backhouse
abd817d181 Use size_t for sizes and offsets. 2022-10-31 03:00:47 -07:00
Kevin Backhouse
c96bc47509 Change return type of getFileLength() to int64_t. 2022-10-31 02:59:34 -07:00
Kevin Backhouse
d599d36f8b
Merge pull request #2394 from kevinbackhouse/fix-issue-2393
stop looping when eof is hit
2022-10-30 14:24:32 +00:00
Rosen Penev
28d1880176 replace find/rfind with startsWith
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-10-28 11:05:23 -07:00
Kevin Backhouse
771ead8732
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=52731
Stop looping when eof is hit.
2022-10-26 22:07:11 +01:00
Miloš Komarčević
c077a06ada Add more Canon RF lenses and camera IDs 2022-10-26 14:24:01 +02:00
Miloš Komarčević
75f7285487 Remove translatable mark from RF lenses 2022-10-26 14:12:53 +02:00
Miloš Komarčević
ecfdaca525 Add more Canon RF lenses 2022-10-26 14:12:53 +02:00
Miloš Komarčević
1f5bc3b8a5
Avoid buffer reallocation (#2392) 2022-10-25 16:30:45 +02:00
Kevin Backhouse
fb6b769817
Merge pull request #2390 from kevinbackhouse/tiffvisitor-safe-add
Use Safe::add() in tiffvisitor_int.cpp
2022-10-24 12:59:37 +01:00