Commit Graph

546 Commits

Author SHA1 Message Date
Mohamed Ali Chebbi
bed8d3d93c rework of aspectRatio calculation for all video formats and rework the decoding of asf tags 2023-02-10 21:55:24 -08:00
Rosen Penev
dee0598edf
clang-tidy fixes for recent stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:27 -08:00
Mohamed Ali Chebbi
3847a09359
Merge branch 'main' into TestVideoData 2023-02-06 09:23:43 +01:00
Rosen Penev
e309680a86 remove deleted members from static classes
This is a holdover from C++98. No need anymore

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ddb42eb159 remove some overriden defaulted destructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
ef82f953c0 do the same for Io functions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Rosen Penev
3290fe6146 remove deleted Image member functions
The inherited Image class already has these same deleted functions.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-05 22:38:44 -08:00
Mohamed Ali Chebbi
bf6546ee82 add test/data for video support : restore Riff HeaderReader and reserve addtional byte in readStraingTag 2023-02-05 00:11:03 +01:00
Mohamed Ali Chebbi
acd71894b2 add test/data for video support : delete unused parameter from readList method 2023-02-05 00:01:36 +01:00
Mohamed Ali Chebbi
0f715288e7 add test/data for video support : delete riff HeaderReader 2023-02-04 23:46:18 +01:00
Mohamed Ali Chebbi
d288617759 add test/data for video support : Fix test issue 2023-02-03 12:37:18 +01:00
Mohamed Ali Chebbi
a36e4dd1e8 Merge branch 'main' into TestVideoData 2023-02-02 16:58:45 +01:00
Mohamed Ali Chebbi
cb7a48f84a Rework Asf and Riff formats ; add test/data for video support 2023-02-02 16:31:16 +01:00
Rosen Penev
805a1e5601 move inline to declaration
Fixes warning under Windows:

redeclared inline; 'dllimport' attribute ignored [-Wignored-attributes]

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-29 08:45:15 -08:00
Miloš Komarčević
c9f7a9f34e
Merge pull request #2479 from Exiv2/export_qtvid
Export QuickTimeVideo
2023-01-27 15:33:29 +01:00
Rosen Penev
db0da461ee static_cast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-27 06:06:57 -08:00
Miloš Komarčević
4e8dca45a3 Export QuickTimeVideo 2023-01-27 12:34:43 +01:00
Rosen Penev
a87c59be51 remove unused variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Mohamed Ali Chebbi
bbb3f5afa8 add test/data for video support : gix issue in riff video and reference data test 2023-01-23 01:39:16 +01:00
Mohamed Ali Chebbi
82ea6bef52 add test/data for video support : make asfvideo more readable and fix some issues 2023-01-23 00:21:04 +01:00
Rosen Penev
3e97850e97 manual default member init
clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Kevin Backhouse
346e11493f
Merge pull request #2443 from kevinbackhouse/inih-from-library3
Remove libinih from codebase and add it as a dependency instead
2023-01-04 10:44:47 +00:00
Rosen Penev
b31b4abbaf fix __cplusplus check for MSVC
Because of an MSVC bug, __cplusplus is always 199711L. Use _MSVC_LANG
which gets set properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
f515799a53 use some if constexpr
MSVC suggests this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
bb311ba728 clang-tidy on Windows
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
d458bf2540 clang-tidy: apply to newly merged stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
e87de698f3 static_cast make_unsigned
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
85a2b8c63b use some future C++ stuff when possible
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Mohamed Ali Chebbi
7fac35e19a
1748 Video Support in V1.0: part 3/3 : support Asfvideo (#2416)
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings

* code review and clean up some code
2022-12-31 18:20:31 +01:00
Rosen Penev
ff0491a102 clang-tidy: use make_unique
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
ce8920a0ea clang-tidy: various fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Mohamed Ali Chebbi
d755fc18b5
1748 Video Support in V1.0: part 2/3 : support Riffvideo (#2415)
* 1748 Video Support in V1.0: part 2/3 : support RiffVideo

* limit the buffer_size

* Update exiv2.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* Code Review and cleanUp code

* Update riffvideo.hpp

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2022-12-31 10:45:45 +01:00
Mohamed Ali Chebbi
1280f3b849
1748 Video Support in V1.0: part 1/3 : support MatroskaViedo (#2413)
* 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo

* Simplify the code of matroskavideo

* protect conevrtuint64 method from overflow

* use size_t instead of uint64_t
2022-12-30 15:58:07 +01:00
Kevin Backhouse
a4164ce866
Remove libinih from codebase and add it as a dependency instead. 2022-12-28 09:33:08 -06:00
Kevin Backhouse
292082df6f
Add break to loop to fix issue 2423, plus some other cleanups. 2022-11-23 12:37:09 +00:00
Peter
1f364be1fa
Fix seg fault when using iconv_open() (#2403)
* Fix seg fault when using `iconv_open()`

- Fix failure condition for `iconv_open()`
- Add new exception when failing to change the text encoding of an
Exif comment

* Add testing for `iconv_open()` seg fault bug

* Fix Python test by changing log level
2022-11-01 13:33:36 +00:00
Miloš Komarčević
9a6ee59421 Support brotli compressed boxes in JPEG XL 2022-10-24 12:32:51 +02:00
Peter
a2cb06a28e
Fix/add exceptions for BMFF based files (#2364)
* Fix BmffImage::writeMetadata() error id/message

* Add exceptions setting Exif/IPTC/XMP in BMFF

* Add missing header for new functions
2022-10-03 14:50:34 +01:00
Peter
ccebe7936e
Update Nikon flash tags (#2274) 2022-08-28 10:02:18 +01:00
Christoph Hasse
e4adf388aa fix(quicktimevideo) cleanup and hardening as suggested in review by @kevinbackhouse 2022-08-24 17:39:42 +02:00
Christoph Hasse
0577057548 fix(quicktimevideo) silence windows warnings 2022-08-24 17:39:42 +02:00
Christoph Hasse
3456f30988 fix(video) clang-format quicktimevideo 2022-08-24 17:39:42 +02:00
Christoph Hasse
0a948c6a7d feat(video) revive quicktime.{h,cpp} and adapt to codebase changes. 2022-08-24 17:39:42 +02:00
Rosen Penev
71dc04ebb1 misc sonarlint stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-22 23:00:32 -07:00
Rosen Penev
10a62b2350 replace custom gcd function with std
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-16 05:58:09 -07:00
Rosen Penev
fc840405cc revert std::function back to function pointers
The former has too much overhead. No point in it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 19:24:47 -07:00
Rosen Penev
5c90684441 simplify some defines
As far as I can tell, _WIN32 is defined for true Windows platforms.
Cygwin is a POSIX platform.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Rosen Penev
f3b572d211 fix iconv handling and windows
WIN32 as a define is wrong. _WIN32 is the correct one.

Which opens up the issue of the used functions and the wrong logic.
Changed the function logic to use if and elif, as done later in the
code.

Also changed all usages of WIN32 with _WIN32

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 15:31:05 -07:00
Rosen Penev
938964f4d0 remove GroupName struct
No point in this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-03 19:59:13 -07:00
Kevin Backhouse
cc604780be
Merge pull request #2283 from kevinbackhouse/printStructure-depth
Convert type of depth parameter to size_t
2022-08-03 16:38:03 +01:00