Commit Graph

8633 Commits

Author SHA1 Message Date
norbertwg
e38d3d9976 several keys added to easyaccess
sample easyaccess-test enhanced with additional optional arguments
"category" for easier definition of some tests
2022-10-07 18:25:25 +02:00
Peter
a2cb06a28e
Fix/add exceptions for BMFF based files (#2364)
* Fix BmffImage::writeMetadata() error id/message

* Add exceptions setting Exif/IPTC/XMP in BMFF

* Add missing header for new functions
2022-10-03 14:50:34 +01:00
Kevin Backhouse
a8a35345c8 Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51241
Fix bounds checking bug.
2022-09-28 21:23:38 -07:00
Kevin Backhouse
b1e2cc6129 Regression test for https://github.com/Exiv2/exiv2/issues/2352 2022-09-28 21:23:38 -07:00
Kevin Backhouse
b3bd36c749 clang-format 2022-09-28 21:22:35 -07:00
Kevin Backhouse
0db460c9b0 nul-terminate string 2022-09-28 21:22:35 -07:00
Kevin Backhouse
a38e124076 Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51707
Resize buf to avoid buffer overflow.
2022-09-28 21:22:35 -07:00
Kevin Backhouse
a94b02063a Regression test for https://github.com/Exiv2/exiv2/issues/2366 2022-09-28 21:22:35 -07:00
Rosen Penev
d856ca7d82 cland-tidy: simplify booleans
Found with readability-simplify-boolean-expr

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-09-27 06:40:37 -07:00
Peter
9dc34ad39c
Update Sony(1|2) tags (#2323)
* Update Sony(1|2) group (minor Minolta changes)

Transcribe all tags (except for `LensID`) from main ExifTool Sony
group into Exiv2.
Changes include:
- Rename `ColorReproduction` -> `CreativeStyle` and
  `LongExposureNoiseReduction` -> `FocusMode3` to reflect use.
- Rename `0x*` tagnames to equivalent ExifTool tags (e.g.,
  `0x2006` -> `Sharpness`).
- Remove tag entries that are Groups (e.g., `ShotInfo`).
- Separate some common Sony/Minolta data as the camera types use
  different values (e.g., `Quality`)
- Additional `exiv2-Sony*.exv` test files come from ExifTool Sony
  samples (https://exiftool.org/Sony.tar.gz).

ExifTool Sony tags sources:
https://www.exiftool.org/TagNames/Sony.html
1e17485cbb/lib/Image/ExifTool/Sony.pm

* Improve coverage of `Sony(1|2)` group

* Fix clang compilation on macOS

* Fix github-code-scanning warnings

* Fix minor `Exif.Sony(1|2)` problems

* Fix tests and update `Sony(1|2)` group coverage

* Fix testing

* Minor fixes and regenerate Regression data

* Update Sony tags with `getModel()`

Make finding the Sony model more resilient by also using
`SonyModelID`.

* Fix `Exif.Sony(1|2).AFPointsUsed` type

* Improve `Exif.Sony(1|2).*` coverage

* Fix types in Sony func `getFocusMode()`

* Update Regression tests for `Sony(1|2)`

* Minor fixes to `Sony(1|2)` tags

* Update `Sony(1|2)` tag coverage

* Improve `Sony(1|2)` tag coverage

* Update easyaccess with `Exif.Sony(1|2)` tags

* Update `SonyModelID` array comment

* Add Sony `LensSpec` tag to easyaccess

* Update `Sony(1|2)` label/descriptions

* Update `int` to `size_t` (credit:@kevinbackhouse)

* Fix Windows build warning in `src/tags_int.hpp`
2022-09-27 09:26:26 +01:00
Rosen Penev
84f566b4b7 use reference to work around MSVC bug
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-09-25 14:50:53 -07:00
Kevin Backhouse
640b0fbf5d
Merge pull request #2346 from kevinbackhouse/fix-issue-2345
Fix buffer overflow in QuickTimeVideo::tagDecoder
2022-09-21 14:54:37 +01:00
Kevin Backhouse
56249bb1a0 Use getULong to read unsigned numbers. 2022-09-19 14:57:56 -07:00
Kevin Backhouse
250586e18b
Merge pull request #2361 from kevinbackhouse/conan-1.52.0
Bump conan version to 1.52.0
2022-09-19 13:33:21 +01:00
Kevin Backhouse
e97dc16738
Bump conan version to 1.52.0 2022-09-18 22:45:21 +01:00
Kevin Backhouse
d2253c91f5
Merge pull request #2348 from kevinbackhouse/fix-issue-2270
Don't allow zero width/height in WebPImage::inject_VP8X
2022-09-08 12:08:01 +01:00
Kevin Backhouse
248215976d
Merge pull request #2347 from kevinbackhouse/quicktimevideo-size-calc
Avoid potential integer overflow in QuickTimeVideo::userDataDecoder
2022-09-07 08:07:25 +01:00
Kevin Backhouse
bf151a17a3
Don't allow zero width/height in WebPImage::inject_VP8X 2022-09-05 23:43:35 +01:00
Kevin Backhouse
344764a7de
Fix clang-format error. 2022-09-05 17:53:46 +01:00
Kevin Backhouse
bf4f28b727
Avoid potential integer overflow. 2022-09-05 17:48:28 +01:00
Kevin Backhouse
d3651fdbd3
Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50901
Resize buf to avoid buffer overflow.
2022-09-05 17:33:43 +01:00
Kevin Backhouse
760a6c54f9
Regression test for https://github.com/Exiv2/exiv2/issues/2345 2022-09-04 20:17:09 +01:00
Christoph Hasse
175e609ad0 fix(doc) mention video support in exiv2.md 2022-08-31 16:32:11 +02:00
Christoph Hasse
6cc44ae8b1 test(quicktimevideo) add poc for #2340 2022-08-31 16:32:11 +02:00
Christoph Hasse
337fe1854f fix(quicktimevideo) avoid out of bounds read, closes #2340 2022-08-31 16:32:11 +02:00
Kevin Backhouse
7a92e1bd0f Credit to OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=50315
Don't allow INT_MIN (0x80000000) because it can cause a UBSAN failure in std::gcd().
2022-08-28 23:15:55 -07:00
Kevin Backhouse
d15fdee91e Regression test for https://github.com/Exiv2/exiv2/issues/2339 2022-08-28 23:15:55 -07:00
Peter
557c26ad33
Update git feature request (#2342) 2022-08-28 19:16:25 +01:00
Peter
3ab996b090
Update git issue report (#2334) 2022-08-28 10:04:59 +01:00
Peter
ccebe7936e
Update Nikon flash tags (#2274) 2022-08-28 10:02:18 +01:00
Christoph Hasse
e4adf388aa fix(quicktimevideo) cleanup and hardening as suggested in review by @kevinbackhouse 2022-08-24 17:39:42 +02:00
Christoph Hasse
0577057548 fix(quicktimevideo) silence windows warnings 2022-08-24 17:39:42 +02:00
Christoph Hasse
ce4b9f0ff9 fix(video) dont throw in isQTimeType 2022-08-24 17:39:42 +02:00
Christoph Hasse
3456f30988 fix(video) clang-format quicktimevideo 2022-08-24 17:39:42 +02:00
Christoph Hasse
9afb877324 test(video) add small video file to execute some code in quicktimevideo.cpp 2022-08-24 17:39:42 +02:00
Christoph Hasse
393815ffb0 fix(video) filetype detection: handle video via quicktimevideo.cpp and other ftyp files in bmffimage 2022-08-24 17:39:42 +02:00
Christoph Hasse
0a948c6a7d feat(video) revive quicktime.{h,cpp} and adapt to codebase changes. 2022-08-24 17:39:42 +02:00
Christoph Hasse
30dbd13982 fix(video) bmffimage can not currently handle mp42 files so skip those 2022-08-24 17:39:42 +02:00
Rosen Penev
71dc04ebb1 misc sonarlint stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-22 23:00:32 -07:00
Rosen Penev
89d7798f1d Add more MIME type mappings for TIFF-based raws
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:18 -07:00
Rosen Penev
2fa84f4bab remove using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:18 -07:00
Rosen Penev
235b1e0d19 move structured bindings up
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-21 14:37:12 -07:00
Rosen Penev
88fcd234bb remove pointless x_default variable
Just replace it with the string.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-17 02:25:10 -07:00
Rosen Penev
b6c2062fae std::to_string conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-17 02:25:10 -07:00
Rosen Penev
10a62b2350 replace custom gcd function with std
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-16 05:58:09 -07:00
Peter
7a96867f31
Add request for exiv2 version/source (bug report) (#2331) 2022-08-16 12:09:39 +01:00
Kevin Backhouse
3ac7608282
Merge pull request #2321 from kevinbackhouse/fix-issue-2320
Fix integer overflow in printDegrees
2022-08-09 13:25:17 -04:00
Rosen Penev
75f54e093f cmakelists.txt: run through cmake-format
Just whitespace changes

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00
Rosen Penev
e151daa0fc fix compilation without mmap and non win32
buf was refactored not to be a pointer.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00
Rosen Penev
6cf06c6534 remove constructor
It can be implicitly generated.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-08-08 23:23:31 -07:00