Commit Graph

9008 Commits

Author SHA1 Message Date
Rosen Penev
a87c59be51 remove unused variable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Rosen Penev
6976aab5bd replace substr with resize/pop_back
Shorter and more efficient.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Rosen Penev
dd445e6c8d use find instead of count
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Rosen Penev
0169739a4e add missing const
Found with cppcheck

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Rosen Penev
aefd901bef fix copy constructors
clang-tidy couldn't transform these because of missing members

Found with cppcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-26 22:44:43 -08:00
Mohamed Ali Chebbi
b8f800ee4d add test/data for video support : format issue 2023-01-23 17:26:52 +01:00
Mohamed Ali Chebbi
bbb3f5afa8 add test/data for video support : gix issue in riff video and reference data test 2023-01-23 01:39:16 +01:00
Mohamed Ali Chebbi
82ea6bef52 add test/data for video support : make asfvideo more readable and fix some issues 2023-01-23 00:21:04 +01:00
Mohamed Ali Chebbi
5deee73141
Merge branch 'Exiv2:main' into TestVideoData 2023-01-21 00:15:10 +01:00
Miloš Komarčević
ed673727a9
Merge pull request #2468 from Exiv2/ci_windows_inih
CI: inih now available for Cygwin
2023-01-18 18:59:43 +01:00
Miloš Komarčević
fe327e136b CI: inih now available for Cygwin 2023-01-18 15:27:02 +01:00
Kevin Backhouse
d5afb08725
Merge pull request #2466 from kevinbackhouse/readExiv2Config-unused-param
Silence unused parameter warning when EXV_ENABLE_INIH is undefined
2023-01-17 09:30:04 +00:00
Kevin Backhouse
b55a0a564a
Silence unused parameter warning when EXV_ENABLE_INIH is undefined. 2023-01-17 08:51:12 +00:00
Kevin Backhouse
2b2111ff41
Merge pull request #2465 from kevinbackhouse/enable-inih
Add EXIV2_ENABLE_INIH flag to enable building without libinih
2023-01-16 16:45:20 +00:00
Kevin Backhouse
43c9ec0f50
Add EXIV2_ENABLE_INIH flag to enable building without libinih. 2023-01-16 10:33:25 +00:00
Kevin Backhouse
b8dda34648
Merge pull request #2457 from kevinbackhouse/inih-release-workflow
Add inih dependency to release workflow
2023-01-15 15:06:08 +00:00
Robin Mills
0107f3078a
Merge pull request #2461 from Exiv2/Fix_2460-delete-contrib-organize
Delete contrib/organize directory
2023-01-14 07:54:38 +00:00
Robin Mills
007137939e
Delete contrib/organize directory
#2460
2023-01-12 12:52:34 +00:00
Mohamed Ali Chebbi
1bd52de0a9 add test/data for video support : delete filename (unuseful) 2023-01-06 23:44:35 +01:00
Mohamed Ali Chebbi
c1d79c17f6 add test/data for video support 2023-01-06 23:17:43 +01:00
Kevin Backhouse
072c3ba31a
Add inih dependency 2023-01-06 12:16:00 +00:00
Rosen Penev
842ef05ee6 return nullptr instead of reset
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
ce8691bba3 remove double libintl check
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
d6e1b90a23 avoid reassignment
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
dd3b3d4ff4 add const
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
3e97850e97 manual default member init
clang-tidy suggests this but fails to apply it.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-05 23:29:31 -08:00
Rosen Penev
a84df11bbb wmain: build as c++ instead of c
Allows to keep exiv2 c++ only.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 14:17:47 -08:00
Alan01
ce2eb6daad Update da.po 2023-01-04 14:17:30 -08:00
Mohamed Ali Chebbi
1c764358bb
Encapsulate video support with compilation variable EXV_ENABLE_VIDEO (#2448)
* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add variable to unit test files

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: encapsulate in makefile

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: fix PR windows matrix

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: activate only for concerned CI tests

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: desable for linux release

* Encapsulate video support with compilation variable EXV_ENABLE_VIDEO: add to Fuzz PR
2023-01-04 13:01:34 +01:00
Kevin Backhouse
346e11493f
Merge pull request #2443 from kevinbackhouse/inih-from-library3
Remove libinih from codebase and add it as a dependency instead
2023-01-04 10:44:47 +00:00
Rosen Penev
b31b4abbaf fix __cplusplus check for MSVC
Because of an MSVC bug, __cplusplus is always 199711L. Use _MSVC_LANG
which gets set properly.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
f515799a53 use some if constexpr
MSVC suggests this.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
bb311ba728 clang-tidy on Windows
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-04 01:40:27 -08:00
Rosen Penev
f981c51eea get rid of -fanalyzer memory leaks
Don't use make_shared inside a function. Instead, change constructor to
value to have std::move.

Also move shared_ptrs everywhere. It's fairly expensive to copy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
d458bf2540 clang-tidy: apply to newly merged stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
e87de698f3 static_cast make_unsigned
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Rosen Penev
85a2b8c63b use some future C++ stuff when possible
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-01-03 01:24:04 -08:00
Mohamed Ali Chebbi
7fac35e19a
1748 Video Support in V1.0: part 3/3 : support Asfvideo (#2416)
* 1748 Video Support in V1.0: part 3/3 : support AsfVideo

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : fix Mac Os error compile

* 1748 Video Support in V1.0: part 3/3 : support AsfVideo : delete unuseful warnings

* code review and clean up some code
2022-12-31 18:20:31 +01:00
Rosen Penev
f145fae33b replace any_of with find
Removes need for lambda.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
304b13c271 use find instead of std::find_if
There's already an operator==

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
ff0491a102 clang-tidy: use make_unique
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Rosen Penev
ce8920a0ea clang-tidy: various fixes
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-12-31 02:12:17 -08:00
Mohamed Ali Chebbi
d755fc18b5
1748 Video Support in V1.0: part 2/3 : support Riffvideo (#2415)
* 1748 Video Support in V1.0: part 2/3 : support RiffVideo

* limit the buffer_size

* Update exiv2.md

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>

* Code Review and cleanUp code

* Update riffvideo.hpp

Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
2022-12-31 10:45:45 +01:00
Mohamed Ali Chebbi
1280f3b849
1748 Video Support in V1.0: part 1/3 : support MatroskaViedo (#2413)
* 1748 Video Support in V1.0: part 1/3 : support MatroskaViedo

* Simplify the code of matroskavideo

* protect conevrtuint64 method from overflow

* use size_t instead of uint64_t
2022-12-30 15:58:07 +01:00
norbertwg
9ca161d1e5
Rename resp. remove duplicate exif keys (#2434)
* rename resp. remove duplicate Exif keys

Duplicate key names with different tag are renamed
Following most of the existing entries, the key with higher tag number
is renamed to ...2.
Exceptions: Canon.CustomFunctions,Olympus.ImageHeight,Olympus.ImageWidth
In the available images samples only the key with higher tag number is
used, so changing the other has less impact on test data and also on
users.
Canon.WhiteBalanceTable with tag 0x00a4 was listed twice, once with
description "SharpnessTable". The entry with the deviating description
is deleted.

* clang format

* adjust test output files (after merge with Exiv2)

* add Exif.NikonLd4.FocusDistance to EasyAccess API

* clang format
2022-12-30 14:37:05 +01:00
Kevin Backhouse
ba258cb1ae
cmake fatal error if inih library is not found. 2022-12-29 13:04:07 -06:00
Miloš Komarčević
5bbd7021eb
Merge pull request #2444 from norbertwg/Lens-Recognition-HD-PENTAX-DA-11-18mm-F2.8-ED-DC-AW
Lens Recognition HD PENTAX-DA* 11-18mm F2.8 ED DC AW
2022-12-29 10:52:13 +01:00
Kevin Backhouse
cccf265eab
Update .github/workflows/on_PR_windows_matrix.yml 2022-12-28 10:44:36 -05:00
Kevin Backhouse
a4164ce866
Remove libinih from codebase and add it as a dependency instead. 2022-12-28 09:33:08 -06:00
norbertwg
8d8ac99be0 Lens Recognition HD PENTAX-DA* 11-18mm F2.8 ED DC AW 2022-12-27 17:53:20 +01:00