Commit Graph

3293 Commits

Author SHA1 Message Date
Robin Mills
d632988bbd Massive code prolog cleanup. 2021-03-17 13:34:21 +00:00
Robin Mills
99600c6aaf exiv2 --verbose --version was reporting have_strerror_r twice! 2021-03-17 11:50:26 +00:00
Robin Mills
6fad24cd11
Merge pull request #1491 from Exiv2/fix_1486_effort2
fix_1486_effort2
2021-03-12 13:59:53 +00:00
Robin Mills
717fc098be fix_1486_effort2 https://github.com/Exiv2/exiv2/pull/1486#discussion_r593161473 2021-03-12 13:16:17 +00:00
Miloš Komarčević
f95d97a0bf Add mif1 brand to heif mime type 2021-03-12 09:20:14 +01:00
Miloš Komarčević
fcb3066950 Include a few more BMFF major brands 2021-03-11 22:30:03 +01:00
Miloš Komarčević
b3dfabdde0
Merge pull request #1486 from Exiv2/fix_1484_empty_ascii
Terminate empty ASCII strings
2021-03-11 21:43:20 +01:00
clanmills
ba6a577ab9 https://github.com/Exiv2/exiv2/pull/1486#issuecomment-796843835 2021-03-11 18:31:52 +00:00
Robin Mills
09567b477b
Merge pull request #1487 from kmilos/housekeep_bmff
Include HEIC type explicitly
2021-03-11 15:07:40 +00:00
Miloš Komarčević
fa41e52c8a Add comment and test case 2021-03-11 14:26:50 +01:00
clanmills
bf1be5cb50 fix_1473_LocationShown 2021-03-11 11:02:10 +00:00
Miloš Komarčević
e3c78623f7 Include HEIC type explicitly 2021-03-10 22:23:01 +01:00
Miloš Komarčević
26ba26e241 Terminate empty ASCII strings as well 2021-03-10 21:44:12 +01:00
Robin Mills
9e2ac47cf9
Merge pull request #1475 from 1div0/BMFF
Base Media File Format
2021-03-10 10:34:21 +00:00
Robin Mills
02477faf4e Following review by @hassec, I use static base64_encoding vector in both Exiv2::base64encode() and Exiv2::base64decode().
I'm a little uneasy about changes to the API of the shared object/DLL.  I will investigate #890 during the release process.  So I have a plan to identify this if it's an issue.  I think it's OK.

```
703 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm --demangle lib/libexiv2.dylib  | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
00000000001c33a0 s Exiv2::base64_encode
704 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm -g --demangle lib/libexiv2.dylib  | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
705 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $
```
2021-03-10 10:02:01 +00:00
clanmills
212f1b5ebb Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF(). 2021-03-10 08:59:17 +00:00
clanmills
e3fd0c633e Thank You @piponazo for the code review. I've made the changes you requested. 2021-03-09 14:10:52 +00:00
postscript-dev
5f563b5255 Fix spelling mistakes in LangAltValue::read()
Removed unneeded comments and empty space.
2021-03-09 12:13:48 +00:00
Miloš Komarčević
0da1a50afe Revert style changes 2021-03-08 18:18:17 +01:00
clanmills
4c52861a74 Fix msvc build breaker. 2021-03-08 16:01:26 +00:00
Miloš Komarčević
e09d093ccf Minor whitespace formatting 2021-03-08 11:58:06 +01:00
postscript-dev
282d1d6995 Add static to LangAltValue::read() const values 2021-03-08 10:27:11 +00:00
clanmills
f1303cbcda Another effort to fix base64decode and associated unit test. 2021-03-08 08:58:24 +00:00
clanmills
87e536dadf Fix #1358. This should be in a different PR. Keep changes to base64 encode/decode together. 2021-03-08 08:45:45 +00:00
clanmills
db9bec3e01 Restore -pC --binary to output everything. Test suite updated to suit. 2021-03-07 20:26:09 +00:00
clanmills
21c610e952 Restoring i < dataLength trigraph that I should not have removed. 2021-03-07 20:25:04 +00:00
clanmills
2f2dd7d56c Fix ICC profile handling (my bad, iOS files are correct). 2021-03-07 20:23:50 +00:00
clanmills
c59c53acf5 Trick to avoid msvc issue with final line of base64 data. 2021-03-06 21:18:58 +00:00
clanmills
1eeeecea50 Replaced Exiv2::base64encode() because last effort failed unit test on msvc. 2021-03-06 20:23:19 +00:00
postscript-dev
6cd9263fa7 Fix langAltValue::read() parsing
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
  + Some tests commented out as quotation marks are filtered, preventing them
    from running.
Closes #1481.
2021-03-06 18:59:31 +00:00
clanmills
80e20304cb Fix Linux build breakers. 2021-03-06 18:38:09 +00:00
clanmills
5410395576 Replaced the ugly code in Exiv2::base64encode() and update the test suite. 2021-03-06 18:13:30 +00:00
clanmills
0ad46453ed With good fortune, bmffimage is ready for review. 2021-03-06 16:12:02 +00:00
clanmills
ee4d14340a Fix box.length == to use bigEndian decode! Fix toAscii() to emit on ascii 32-127 bytes. 2021-03-05 18:21:16 +00:00
clanmills
df68648dc3 refactored setModeAndPrintStructure() to respect class Task.binary_ when printing ICC profiles. 2021-03-05 17:06:52 +00:00
clanmills
b983a9db75 Re-awaken obsolete command-line argument --binary and store class Task. 2021-03-05 17:05:24 +00:00
Robin Mills
71d29fe60b Fix MSVC build breaker and modify test_pr_1475_HIF.py to run on Windows. 2021-03-03 14:34:15 +00:00
clanmills
55d2201892 Changed CI build default -DEXIV2_ENABLE_BMFF=On. Fixed suite to run with/without bmff. -pS and -pR same for bmff. 2021-03-03 10:40:08 +00:00
Robin Mills
c84274ec19 Cosmetic change to -pR/-pS output. 2021-03-02 19:36:33 +00:00
Robin Mills
fd9cb67fb7 WIP: adding BmffImage::printStructure() and support for colr box. 2021-03-02 14:39:56 +00:00
Miloš Komarčević
2b38d221dc Adding DNG 1.6 triple-illuminant calibration tags 2021-03-02 08:59:19 +01:00
Robin Mills
4ca05ed34a Fix .CR3 files to call parseXmp(). 2021-02-28 13:51:20 +00:00
Robin Mills
ea1c91874f Added parseXmp() to parse Xmp metadata. 2021-02-28 11:29:09 +00:00
Robin Mills
44d976c2a1 Remove bmffimage::printStructure() as discussed in review with @hassec. Corpse removal and cleanup in bmpfimage.hpp 2021-02-26 10:21:12 +00:00
Peter Kovář
dcfe538a09 Revert "Add artist tag"
This reverts commit c46e800c0a.
2021-02-25 20:08:46 +01:00
Peter Kovář
c46e800c0a Add artist tag 2021-02-25 19:40:18 +01:00
Robin Mills
5c77888037 Revised following code review by @hassec. Thank You, Christoph. 2021-02-25 18:10:48 +00:00
Peter Kovář
4d3af08ad8 Add CR3 image dimensions 2021-02-25 18:42:34 +01:00
Robin Mills
4ae0a1d2a3 Tidy up. Rename Tag::cr3_exif -> Tag:cmt2 2021-02-25 15:25:09 +00:00
Robin Mills
9515e4658b Cleanup. 1. Recursively process uuid/cano box. 2. Fix LGTM/CI sprintf grumbles. 3. Comment parseTiff() in bmffimage.hpp. 2021-02-25 14:47:20 +00:00