Commit Graph

8525 Commits

Author SHA1 Message Date
Kevin Backhouse 0f1ea7571b Refactor printTiffStructure depth increment 2022-07-30 21:31:20 -04:00
Kevin Backhouse 46f2ef8009 Refactor printIFDStructure depth increment 2022-07-30 21:31:19 -04:00
Kevin Backhouse 39239cef68 Merge pull request #2296 from kevinbackhouse/tiff-offset-size_t
Use size_t for the offset argument in TiffComponent
2022-07-30 17:23:57 +01:00
Kevin Backhouse 89040ad1de Fix implicit type conversions. 2022-07-28 22:46:17 -04:00
Kevin Backhouse d8bd05f4e8 Use size_t 2022-07-27 22:54:41 -04:00
Kevin Backhouse beaee05062 Change type of sizeDataArea_ 2022-07-27 22:50:07 -04:00
Kevin Backhouse 30debd2635 Use size_t for the offset. 2022-07-27 17:26:18 -04:00
Rosen Penev e34395e095 replace shared_ptr with make_shared
The former creates a nullptr. The latter actually allocates.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev d873af44a5 clang-tidy: avoid C casts
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev c03af98725 clang-tidy: use auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev 5b737ca541 sonarlint: add an empty do while loop
Avoids warnings regarding unnecessary semicolons.

Remove _fileno as it is unused.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev 5a08e33fd8 sonarlint: replace loop with find_if
Sonarlint complains about this loop for some reason. Convert to find_if
to fix.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev aae02babba sonarlint: replace lock_guard with scoped_lock
C++17 allows scoped_lock, which sonarlint recommends.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev 5d2d47032b replace [0] with front() where applicable
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-27 11:29:57 -07:00
Rosen Penev 9fbcdb4841 po: update files
When building with EXIV2_ENABLE_NLS, these files always get updated.
Commit these changes.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-26 23:14:30 -07:00
Miloš Komarčević 8001807f4d CI: cancel running jobs on updates 2022-07-26 23:14:05 -07:00
Kevin Backhouse 1958e70a71 Use int32_t in TimeValue 2022-07-26 23:13:42 -07:00
Kevin Backhouse 3db7598e29 Don't use long in floatToRationalCast 2022-07-26 23:12:15 -07:00
Rosen Penev 49679640e8 make_unique conversions
Requires pointer hack for MSVC.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-25 06:02:43 -07:00
Rosen Penev 3ae1d3b48e return make_unique directly
Simpler

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 23:00:02 -07:00
Rosen Penev 02b0ff39d7 Make headers compatible with C++11
Remove is_signed_v and CTAD for std::array as they are in C++17

Remove remove_cv_t, remove_pointer_t, and make_unsigned_t as they are in
C++14

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:37:25 -07:00
Rosen Penev 9ca7f861cf remove string_view from headers
This should allow usage with C++11 projects. It's also wrong. The only
user of this assigns an std::string from a string_view, which is not
safe.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:37:25 -07:00
Rosen Penev 5479792d50 remove pointless &*
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev f3b08d506e const ref conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev a6c30dd1dd make upper the same as lower
Small cleanup

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev b8eaae649d use some auto
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev b793409eb6 find_if and lambda conversions
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev 932d59a984 find_if conversion
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev 9766c4532d fix some gcc -Weffc++ warnings
Mostly deleted member functions

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Rosen Penev 543c951bde clang-tidy: use '' for find
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-24 16:34:00 -07:00
Miloš Komarčević 4544fd826c Add more Nikon Z lenses 2022-07-23 20:32:49 -07:00
Miloš Komarčević ca5f88d519 Add Nikon LensData v0802 2022-07-23 20:32:49 -07:00
Rosen Penev 176210567f remove friend operator
Seems to be unused. It's also inconsistent between various clang-format
versions.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2022-07-21 19:47:57 -07:00
Peter 94f8889cd3 Update olympus tags (#2246) (#2249)
Update translation output of `Exif.OlympusCs.ArtFilter`/`Exif.OlympusCs.MagicFilter`, `Exif.OlympusCs.ImageStabilization` and `Exif.OlympusCs.WhiteBalance` tags.

Fix `Exif.OlympusCs.ImageStabilization` type from `unsignedShort` to `unsignedLong`.

Closes #2246.

Ref: Exiftool Olympus tags and Olympus E-M10 Mark II instuction manual.
2022-07-19 15:42:00 +01:00
Peter dc4ae73013 Add tag description option to exiv2 app (#2279)
* Add `tagDesc()` to (Exif|Xmp|Iptc) Datums and Keys
* Add `--Print d` option to exiv2 app
* Add testing for all exiv2 application `--Print` options
* Update manpage
2022-07-12 15:31:43 +01:00
Kevin Backhouse 05586628b2 Merge pull request #2276 from kevinbackhouse/TagInfo-enums
Move enums from tags_int.hpp to tags.hpp
2022-07-12 10:23:26 +01:00
Kevin Backhouse 3ef783e02a Convert IfdId and SectionId to enum classes. 2022-07-11 22:37:52 +01:00
Kevin Backhouse 90f794f13e Merge pull request #2277 from kevinbackhouse/iptcDataSegs
Simplify the iptcDataSegs logic in jpgimage.cpp
2022-07-09 23:35:44 +01:00
Kevin Backhouse 97e58a4573 Merge pull request #2267 from neheb/clang
mostly clang-tidy fixes
2022-07-09 21:50:50 +01:00
Kevin Backhouse 8e5b8113e7 Use emplace_back 2022-07-09 21:45:58 +01:00
Kevin Backhouse 2c31430ecd Merge pull request #2275 from kevinbackhouse/vector-access
Fix some "unsafe vector access" warnings
2022-07-09 11:41:31 +01:00
Kevin Backhouse a608138f5f Simplify the iptcDataSegs logic 2022-07-08 13:51:34 +01:00
Kevin Backhouse 62043c18ab clang-format 2022-07-08 12:52:02 +01:00
Kevin Backhouse b9b2d7741b Fix some "unsafe vector access" warnings. 2022-07-08 12:48:42 +01:00
Kevin Backhouse 3f7cb78a3b Move enums from tags_int.hpp to tags.hpp 2022-07-08 12:03:53 +01:00
Kevin Backhouse a22aea0a96 Merge pull request #2272 from Exiv2/mergify/bp/main/pr-2269
Replace assert with enforce (backport #2269)
2022-07-08 10:30:51 +01:00
Kevin Backhouse 58cef7516e Add issue_2268_poc.jp2 to the exclude list. 2022-07-07 19:55:28 +01:00
Kevin Backhouse 0c3da129f2 Replace assert with enforce. (Fix for https://github.com/Exiv2/exiv2/issues/2268) 2022-07-07 17:31:38 +01:00
Kevin Backhouse 6b5453c9d5 Regression test for https://github.com/Exiv2/exiv2/issues/2268 2022-07-07 17:29:49 +01:00
Kevin Backhouse 75c53ea2e9 Merge pull request #2273 from kevinbackhouse/unsafe-vector-access
Eliminate some false positive results
2022-07-07 13:26:48 +01:00