Commit Graph

4223 Commits

Author SHA1 Message Date
Rosen Penev
839c03fe37 use find()
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
3fe6d78014 Remove some constructors
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
2205a14a06 clang-tidy: default init various members
Found with cppcoreguidelines-pro-type-member-init

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
dd25d9999b direct init structs
No need to deal with individual members

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
48caa32017 close socket before return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
393150c0cd cast expression
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Rosen Penev
f2c879333e fix off by 1 error
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-25 15:46:42 -08:00
Kevin Backhouse
230fbaf421 Use toInt64() for hours and minutes, because they should be integer valued. 2023-02-23 13:23:25 -08:00
Kevin Backhouse
c20ee1a7f5 Use double type to improve floating point accuracy. 2023-02-23 13:23:25 -08:00
Rosen Penev
9f21b78311 add contains function
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-14 00:48:41 -08:00
Rosen Penev
28358cd209 template second parameter for startsWith
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-14 00:48:41 -08:00
Rosen Penev
d7bf72634e use std::replace
shorter

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
0d50e444f2 use count_if
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
2d1691c1e2 replace array with vector
Using the constructor is one less line. Plus it seems to fix bugs in
Apple's clang.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
63b32ba3fb fix wrong snprintf format
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
61e5aefcc4 explicit conversion
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
75dae3fb96 replace localtime with _s/_r variant
cppcheck warns on localtime which is not necessarily threadsafe.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
625a2b8167 fix memory leak
Found with cppcheck.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
968a546dcb use upper() function
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
5eebbbcbfb make conversions explicit
Found with MSVC's C4244

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:35:03 -08:00
Rosen Penev
31165b6a01 remove base constructor
Maybe works now

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-13 09:30:11 -08:00
Mohamed Ali Chebbi
c555a70127 fuzz issue : add debug message for futur use 2023-02-13 16:45:40 +01:00
Mohamed Ali Chebbi
03fcc6cad2 fuzz issue : check that block is not corrupted before decoding 2023-02-13 12:13:12 +01:00
Rosen Penev
5b1bc2ef6d clang-tidy: no else after return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
4e3a63d9b7 replace std::pair and tuple with C structs
fixes internal MSVC libc++ warnings

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
36e848d4fe clang-tidy: replace memcpy with copy_n
Found with bugprone-not-null-terminated-result

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
7f5430a7d4 use lower()
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
35b6780d02 clang-tidy: don't assign in if
Found with bugprone-assignment-in-if-condition

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
d1a2cd0b76 clang-tidy: cast initial variable
Fixes: bugprone-integer-division

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
e188df1e14 fix implicit conversion
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
b3ff42f2d5 use if constexpr
Suggested by MSVC.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
629f94eea3 unreachable code
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
d2ddf228ad replace switch with if/return
Fixes warning C4702: unreachable code

No other way to make all compilers gappy.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
dde8765a49 don't assign in while
Fixes MSVC's warning C4706: assignment within conditional expression

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
b324f80443 use numeric limits instead of -1
Fixes MSVC warning.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Rosen Penev
a10c08ba1d swap variables
These are the wrong way around. MSVC warns with /W4.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-11 10:44:20 -08:00
Mohamed Ali Chebbi
b8b4a041a1 compilation issue on Windows 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
51ef600fe6 compilation issue on Mac OS 2 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
c7aec66195 compilation issue on Mac OS 2023-02-10 21:55:24 -08:00
Mohamed Ali Chebbi
bed8d3d93c rework of aspectRatio calculation for all video formats and rework the decoding of asf tags 2023-02-10 21:55:24 -08:00
Rosen Penev
dee0598edf
clang-tidy fixes for recent stuff
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:27 -08:00
Rosen Penev
f21b2a2170
std to Exiv2 find
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:18 -08:00
Rosen Penev
b665574634
simplify loop
Just use upper

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:32:18 -08:00
Rosen Penev
33e5ef5ffd
remove constructors
Just direct initialize

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-09 17:30:53 -08:00
Mohamed Ali Chebbi
6690e2e8f3
Merge branch 'Exiv2:main' into TestVideoData 2023-02-09 21:27:49 +01:00
Miloš Komarčević
13e6671de2
Update some Canon IDs (#2501) 2023-02-08 16:49:53 +01:00
Rosen Penev
be387a60c3 add missing &
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-08 07:42:31 -08:00
Rosen Penev
0f30198d9b remove mmap/munmap checks
Just check the header

Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-07 08:47:56 -08:00
Rosen Penev
2ddf00e7a2 use EXV_ICONV_CONST
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2023-02-07 08:47:56 -08:00
Mohamed Ali Chebbi
32576a3edf add test/data for video support : rework readStringWcharTag method 2 2023-02-07 12:12:15 +01:00