Commit Graph

7167 Commits

Author SHA1 Message Date
Miloš Komarčević
bf43c6cfd1 Replace tabs to fix indentation issues 2021-03-17 09:42:43 +01:00
Robin Mills
1fad29e11f Fix typos. 2021-03-17 08:21:32 +00:00
Robin Mills
310369505a Add test/ReadMe.txt 2021-03-17 07:41:21 +00:00
Robin Mills
21b73b4207 Refactor CMakeList.txt to run all tests using tests/runner.py 2021-03-17 07:30:59 +00:00
Robin Mills
5e82f260a1 Add python scripts equivalent to test/version_test.sh and unit_test.sh 2021-03-17 07:11:55 +00:00
Robin Mills
ccaa50909a Add unit_tests to suite.conf 2021-03-17 07:09:45 +00:00
Robin Mills
0c4c3a0213 use raise from test_pr1475*.py 2021-03-17 07:05:04 +00:00
Robin Mills
6fad24cd11
Merge pull request #1491 from Exiv2/fix_1486_effort2
fix_1486_effort2
2021-03-12 13:59:53 +00:00
Robin Mills
717fc098be fix_1486_effort2 https://github.com/Exiv2/exiv2/pull/1486#discussion_r593161473 2021-03-12 13:16:17 +00:00
Miloš Komarčević
201e7d3fee
Merge pull request #1490 from kmilos/issue_1489_bmff_mime_major
Include a few more BMFF major brands
2021-03-12 10:53:45 +01:00
Miloš Komarčević
f95d97a0bf Add mif1 brand to heif mime type 2021-03-12 09:20:14 +01:00
Miloš Komarčević
fcb3066950 Include a few more BMFF major brands 2021-03-11 22:30:03 +01:00
Miloš Komarčević
b3dfabdde0
Merge pull request #1486 from Exiv2/fix_1484_empty_ascii
Terminate empty ASCII strings
2021-03-11 21:43:20 +01:00
clanmills
ba6a577ab9 https://github.com/Exiv2/exiv2/pull/1486#issuecomment-796843835 2021-03-11 18:31:52 +00:00
Robin Mills
09567b477b
Merge pull request #1487 from kmilos/housekeep_bmff
Include HEIC type explicitly
2021-03-11 15:07:40 +00:00
Miloš Komarčević
fa41e52c8a Add comment and test case 2021-03-11 14:26:50 +01:00
Robin Mills
aaa075f3d4
Merge pull request #1488 from Exiv2/fix_1473_LocationShown
fix_1473_LocationShown
2021-03-11 12:06:20 +00:00
clanmills
bf1be5cb50 fix_1473_LocationShown 2021-03-11 11:02:10 +00:00
Miloš Komarčević
e3c78623f7 Include HEIC type explicitly 2021-03-10 22:23:01 +01:00
Miloš Komarčević
26ba26e241 Terminate empty ASCII strings as well 2021-03-10 21:44:12 +01:00
Robin Mills
9e2ac47cf9
Merge pull request #1475 from 1div0/BMFF
Base Media File Format
2021-03-10 10:34:21 +00:00
Robin Mills
19aab434a5 Move system_tests.runTest() and system_tests.verbose_version() to system_tests.BT 2021-03-10 10:23:34 +00:00
Robin Mills
02477faf4e Following review by @hassec, I use static base64_encoding vector in both Exiv2::base64encode() and Exiv2::base64decode().
I'm a little uneasy about changes to the API of the shared object/DLL.  I will investigate #890 during the release process.  So I have a plan to identify this if it's an issue.  I think it's OK.

```
703 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm --demangle lib/libexiv2.dylib  | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
00000000001c33a0 s Exiv2::base64_encode
704 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $ nm -g --demangle lib/libexiv2.dylib  | grep base64
00000000000384a0 T Exiv2::base64decode(char const*, char*, unsigned long)
0000000000038340 T Exiv2::base64encode(void const*, unsigned long, char*, unsigned long)
705 rmills@rmillsmm-local:~/gnu/github/exiv2/bmff/build $
```
2021-03-10 10:02:01 +00:00
clanmills
212f1b5ebb Following review by @piponazo, I am clarifying the bool return from Exiv2::enableBMFF(). 2021-03-10 08:59:17 +00:00
Robin Mills
301f3c51ba
Merge pull request #1483 from Exiv2/add_SECURITY_md
Add SECURITY.md
2021-03-09 18:23:28 +00:00
Robin Mills
062177d092 Add SECURITY.md and reference it from the Security Tab in the GitHub Web UI. 2021-03-09 18:21:14 +00:00
Robin Mills
822eb1a2dd
Merge pull request #1482 from postscript-dev/fix_langAlt_read_func
Fix langAltValue::read() parsing
2021-03-09 17:33:42 +00:00
postscript-dev
2917b83d0e Update exiv2 man page - langAlt format 2021-03-09 15:59:48 +00:00
clanmills
e3fd0c633e Thank You @piponazo for the code review. I've made the changes you requested. 2021-03-09 14:10:52 +00:00
postscript-dev
5f563b5255 Fix spelling mistakes in LangAltValue::read()
Removed unneeded comments and empty space.
2021-03-09 12:13:48 +00:00
LeoHsiao
9d28943b63 Simplify functions: runTest(), verbose_version() 2021-03-09 20:10:05 +08:00
postscript-dev
207a0d65c9 Change LangAltValue::read() tests to unitTests
Removed previous Python tests.
2021-03-09 11:58:55 +00:00
Miloš Komarčević
0da1a50afe Revert style changes 2021-03-08 18:18:17 +01:00
clanmills
4c52861a74 Fix msvc build breaker. 2021-03-08 16:01:26 +00:00
Miloš Komarčević
e09d093ccf Minor whitespace formatting 2021-03-08 11:58:06 +01:00
Miloš Komarčević
2c0f3c2bbc Include HEIC type in docs 2021-03-08 11:41:08 +01:00
postscript-dev
282d1d6995 Add static to LangAltValue::read() const values 2021-03-08 10:27:11 +00:00
clanmills
ae66869695 Updated to adopt Review suggestions by @kmilos. Thank You, Milos. 2021-03-08 10:04:27 +00:00
clanmills
f1303cbcda Another effort to fix base64decode and associated unit test. 2021-03-08 08:58:24 +00:00
clanmills
87e536dadf Fix #1358. This should be in a different PR. Keep changes to base64 encode/decode together. 2021-03-08 08:45:45 +00:00
clanmills
db9bec3e01 Restore -pC --binary to output everything. Test suite updated to suit. 2021-03-07 20:26:09 +00:00
clanmills
21c610e952 Restoring i < dataLength trigraph that I should not have removed. 2021-03-07 20:25:04 +00:00
clanmills
2f2dd7d56c Fix ICC profile handling (my bad, iOS files are correct). 2021-03-07 20:23:50 +00:00
clanmills
c59c53acf5 Trick to avoid msvc issue with final line of base64 data. 2021-03-06 21:18:58 +00:00
clanmills
3bfea0c5d1 This should be it. Test suite fixed. 2021-03-06 20:30:59 +00:00
clanmills
1eeeecea50 Replaced Exiv2::base64encode() because last effort failed unit test on msvc. 2021-03-06 20:23:19 +00:00
postscript-dev
6cd9263fa7 Fix langAltValue::read() parsing
+ Fix segmentation faults in langAlt parse
+ Fix mismatched quotation marks and incorrect values
+ Add Python testing
  + Some tests commented out as quotation marks are filtered, preventing them
    from running.
Closes #1481.
2021-03-06 18:59:31 +00:00
clanmills
80e20304cb Fix Linux build breakers. 2021-03-06 18:38:09 +00:00
clanmills
5410395576 Replaced the ugly code in Exiv2::base64encode() and update the test suite. 2021-03-06 18:13:30 +00:00
clanmills
0ad46453ed With good fortune, bmffimage is ready for review. 2021-03-06 16:12:02 +00:00