Luis Díaz Más
c80b1b9d51
New documentation about how to use Conan
2018-04-11 21:59:54 +02:00
Luis Díaz Más
a923b067b5
Minor updates in README.md
2018-04-11 21:59:54 +02:00
Luis Díaz Más
fbd8e2669e
sort alphabetically the sources in src/CMakelists.txt
2018-04-09 23:04:35 +02:00
Luis Díaz Más
de5b9ebf89
Remove duplication of sources in src/CMakeLists.txt
2018-04-09 23:04:35 +02:00
Luis Díaz Más
5a6e66fd5b
Update RADME-CMAKE.
...
- Some notes about how to pass -DDEBUG via CMake.
- Update comments about conan.
- Some other minor modifications.
2018-04-09 18:53:00 +02:00
Luis Díaz Más
71ecc44a5e
Remove from -DDEBUG from Debug builds in Mac and Linux
2018-04-09 18:53:00 +02:00
Luis Díaz Más
ffbcaa2e6d
Fix MSVC warning C4267: conversion from 'size_t' to 'long'
2018-04-09 15:54:27 +02:00
Luis Díaz Más
794fea2639
Replaced way to check buffer after calling DateValue::copy
2018-04-08 10:10:12 +02:00
Luis Díaz Más
bd40c18f1c
Use variable in TimeValue::copy to remove -Wunused-variable warning
2018-04-08 10:10:12 +02:00
Luis Diaz Mas
a246c73d6f
Use unused variable instead of hard-coded values in DateValue::copy
2018-04-08 10:10:12 +02:00
Luis Diaz Mas
bf0b7affaa
Add few basic unit tests for DateValue
...
I feel more confortable doing changes in a code that I do not know by
having some unit tests around it. These characterisation tests will
also be useful as documentation.
2018-04-08 10:10:12 +02:00
Mario Emmenlauer
548d7688c7
samples/geotag.cpp: fixed debugging code to be in the correct ifdef
2018-04-08 07:45:48 +02:00
Luis Díaz Más
bf7047a71b
clang-format XmpKey code
2018-04-07 20:04:22 +02:00
Luis Díaz Más
b545605d25
Add characterisation tests for XmpKey
2018-04-07 20:04:22 +02:00
Luis Díaz Más
336b759cc0
Remove 'using namespace' from public header
2018-04-06 09:23:58 +02:00
Luis Díaz Más
28ca8aa529
Fix Appveyor builds by disabling the search of Iconv on Windows
...
Note that Iconv has not been used on AppVeyor until now.
2018-04-06 09:05:01 +02:00
Fredrik Lingvall
db5bb66d06
CONTRUBUTING.md updates ( #234 )
...
* Restructured the file: added TOC, new sections: lens data and bug reports, and removed coding guidelines.
* Added a CODING_GUIDELINES.md file (which previously was a part of the CONTRIBUTING.md file).
2018-04-04 09:55:03 +02:00
Luis Diaz Mas
07d75cd0e8
Check if ExifData::findKey return valid iterators
2018-04-02 17:46:29 +02:00
Luis Diaz Mas
ffab622633
Add reproducer for #247
2018-04-02 17:46:29 +02:00
D4N
314d2f91a7
Merge pull request #256 from piponazo/fix253
...
Fix for #253
2018-04-01 09:56:49 +02:00
Luis Diaz Mas
08aa27ae37
Add reproducers for #253 and #246
2018-04-01 09:21:20 +02:00
Luis Díaz Más
858c99b4df
Add enforce before calling REPORT_MARKER with invalid marker
2018-04-01 08:20:22 +02:00
Luis Díaz Más
5e5d76ad0a
clang format function
2018-03-30 08:10:58 +02:00
Dan Čermák
8b7941b733
[cmake] Add EXTRA_COMPILE_FLAGS to samples & unitTests
...
Add the additional compiler flags added by -DEXIV2_TEAM_EXTRA_WARNINGS=ON to
the targets in samples/ & unitTests/
This fixes #204
2018-03-29 13:17:24 +02:00
D4N
1e016f82e7
Merge pull request #249 from D4N/port_github_issues
...
Port GitHub issues to the new test suite
2018-03-28 15:02:57 +02:00
Dan Čermák
e78982c81a
[testsuite] simplify test/Makefile
2018-03-28 10:07:41 +02:00
Dan Čermák
1f32207271
[testsuite] rename test_issue_208 -> test_CVE_2017_17722
...
the issue got a CVE assigned
2018-03-28 10:07:41 +02:00
Dan Čermák
4533d60e74
[testsuite] Added helper function for system_tests.Case.compare_stderr
2018-03-28 10:07:41 +02:00
Dan Čermák
02f60f11ae
[testsuite] Reimplemented a part of system_tests.CopyFiles
...
- main file handling functionality is performed by a base class => can
be easier extended if required
2018-03-28 10:07:41 +02:00
Dan Čermák
3b01d5205a
[testsuite] Port all regression tests for github issues
2018-03-28 10:07:41 +02:00
Dan Čermák
3cbb031442
[testsuite] Unified CVE test cases
2018-03-28 10:07:41 +02:00
Dan Čermák
e597e5b811
[testsuite] Fixed CVE number
2018-03-28 10:07:41 +02:00
Dan Čermák
c754ca6d14
[testsuite] Corrected class name, issue had no CVE assigned
2018-03-28 10:07:41 +02:00
Dan Čermák
71f9a24027
[testsuite] Unified variable names
2018-03-28 10:07:32 +02:00
D4N
bdbab63531
Merge pull request #239 from D4N/fix_CVE_2017_1000126
...
Fix CVE-2017-1000126
2018-03-28 09:27:42 +02:00
Dan Čermák
48982697b0
Add reproducer for CVE-2017-1000126 to the test suite
2018-03-27 23:46:13 +02:00
Dan Čermák
3c20cc06a9
Fix CVE-2017-1000126
...
CVE-2017-1000126 is a Stack out of bounds read in the WebP parser caused by the
parameter size & filesize being too large, causing the parser to land in an
infinite loop and eventually crash. Enforcing that the size over which the
parser iterates is smaller than the file fixes this issue.
This fixes #175 .
2018-03-27 23:46:13 +02:00
Dan Čermák
49db96cd58
[webp] Fix wrong filesize parameter being extracted from the header
...
The webp header contains the filesize of the image starting at the 8th byte in
bytes 4 to 8 encoded as a little endian 32 bit unsigned integer. The code was
erroneously assuming that the extracted filesize is starting at the 12th byte,
i.e. at the end of the WebP file header.
Source: https://developers.google.com/speed/webp/docs/riff_container
2018-03-27 23:46:13 +02:00
D4N
be992520b1
Merge pull request #252 from D4N/add_enforce
...
Add enforce() from D
2018-03-27 22:30:28 +02:00
Dan Čermák
842dd4cecc
Add a unit tests for enforce()
2018-03-25 23:25:23 +02:00
Dan Čermák
5de9a7b562
Add a port of enforce() from D
...
enforce is a function comparable to assert(), it ensures that a condition is
true. However, while assert() should be used for conditions where we can be
certain that they are true, enforce is intended to be used for conditions that
can fail (like on invalid input). Therefore enforce() throws an exception when
the condition is false and does not abort the program's execution. Also, it is
not turned off by defining NDEBUG.
- add a new file enforce.hpp
- implement enforce()
2018-03-25 23:25:11 +02:00
HumanDynamo
22a0b32c01
Fix typo of Xmp.video.AspectRatio's value type
2018-03-24 09:11:32 +01:00
Luis Díaz Más
eb61e57de0
[conan] Update to conan 1.1.1 and recipes in which we depend on
...
* Update dependency on libexpat to version 2.2.5
This new version of the conan recipe contain packages for new compilers
* Get gtest and libcurl from bincrafters
* Update the zlib dependency
* Use clang-5.0
2018-03-22 22:52:59 +01:00
Dan Čermák
59b148aee9
Add regression test for CVE-2017-18005
2018-03-20 21:30:06 +01:00
Luis Díaz Más
d21e794239
Do not deference value when it does not exist (Thanks D4N)
2018-03-20 21:30:06 +01:00
Luis Díaz Más
01a5d863ad
Apply clang-format to Print::printMetadatum
2018-03-20 21:30:06 +01:00
Luis Díaz Más
45fe44aa2f
Move condition in if statement to discard work earlier
2018-03-20 21:30:06 +01:00
Luis Díaz Más
d82b9434e1
Only print items (Params::prValue) when size > 0
2018-03-20 21:30:06 +01:00
Robin Mills
185d0e9482
#199 Fix for getopt(). Use src/getopt_win32 code instead of libc/getopt()
2018-03-20 18:49:16 +01:00
D4N
a4a0516dc4
Merge pull request #238 from D4N/safe_op_improvements
...
Addition overflow checks improvements
2018-03-17 00:39:21 +01:00